70244[TASK] Run Grunt scripts in parallel
Commit message
Review
-
Code review CR +2 Done
- Tymoteusz Motylewski +2
- Oli Bartsch +1
-
Verified V +2 Done
- Tymoteusz Motylewski +2
- Oli Bartsch +1
- Jonas Eberle +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1721
-
Andreas Kienast uploaded patch set 1 08/06/21, 09:00
-
core-ci voted on patch set 1 V -1 08/06/21, 09:13 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14189
-
Andreas Kienast uploaded patch set 2 08/06/21, 09:19
-
core-ci voted on patch set 2 V -1 08/06/21, 09:34 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14191
-
Mathias Brodala commented on patch set 2 08/06/21, 09:59
Maybe I'm missing something but isn't this slower (user+system) than before? Also why are there 2 build lines here instead of 1? My understanding: https://stackoverflow.com/a/556411/6812729 -
Andreas Kienast commented on patch set 2 08/06/21, 10:23
Reply
First of all: I've triggered two builds before and after that change to get different build times. The builds are faster, please see the "total" time at the end of each output in the commit message. The patch currently saves roughly 10 seconds per build. The execution time for "user" is higher because more CPU cores are used, the execution time is cumulated across all cores. -
Mathias Brodala commented on patch set 2 08/06/21, 10:26
Reply Unresolved
Understood, seems like I still don't understand "time" fully. ;-) -
Andreas Kienast commented on patch set 2 08/27/21, 14:30
I figured out why the build fails. Since TYPO3 v10 the imagemin step fails with > Warning: Error: spawn /builds/typo3/CI/cms/Build/node_modules/optipng-bin/vendor/optipng ENOENT in file ../typo3/sysext/core/Resources/Public/Icons/Flags/AD.png Use --force to continue. but that didn't let the whole CI fail. Since these steps are run in parallel now, imagemin let's the whole group fail, leaving other files untouched. -
Andreas Kienast uploaded patch set 3 08/27/21, 14:46
-
core-ci voted on patch set 3 V +1 08/27/21, 15:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15732
-
Tymoteusz Motylewski commented on patch set 3 08/27/21, 18:37
parallel is longer than seq? -
Andreas Kienast commented on patch set 3 08/27/21, 18:46
Reply
No, please read the previous comments in this PR. The "user" time is the CPU time. As more CPUs are involved in parallel builds, it's the logical consequence the user time is higher. The important metric here is "total", which is lower than in sequential builds. -
Andreas Kienast uploaded patch set 4 08/30/21, 20:37
-
core-ci voted on patch set 4 V +1 08/30/21, 20:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15897
-
Jonas Eberle voted on patch set 4 V +1 08/31/21, 06:14
-
Tymoteusz Motylewski voted on patch set 4 V +1 CR +1 08/31/21, 10:46
-
Tymoteusz Motylewski commented on patch set 4 08/31/21, 10:47
tested it with: - no patch cd Build yarn install grunt build git status -> no changes in files cherry pick change yarn install grunt build git status -> no changes in files -
Oli Bartsch commented on patch set 4 V +1 CR +1 08/31/21, 10:54
Before: 98.48s After: 80.50s Thanks a lot :) -
Tymoteusz Motylewski voted on patch set 4 V +2 CR +2 08/31/21, 11:04
-
Tymoteusz Motylewski commented on patch set 4 08/31/21, 11:05
Reply
Ack -
Tymoteusz Motylewski merged patch set 5 08/31/21, 11:06