70256[BUGFIX] Correct return type for FileReference methods
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 89
-
Anja Leichsenring commented on patch set 1 08/09/21, 18:09
Cherry Picked from branch master. -
core-ci voted on patch set 1 V +1 08/09/21, 18:21 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14394
-
Chris Müller voted on patch set 1 CR +1 08/10/21, 15:52
-
Stefan Bürk voted on patch set 1 CR +1 08/14/21, 13:46
-
Stefan Bürk voted on patch set 1 V +1 08/14/21, 13:46
-
Oli Bartsch commented on patch set 1 08/17/21, 12:41
I think it can not be ruled out that extension currently rely on those methods returning null - even if PHPDoc tells different. What do you think about making this master only? This way we could also add return types. -
Oliver Klee voted on patch set 1 CR +1 08/17/21, 12:48
-
Chris Müller commented on patch set 1 08/17/21, 14:19
Reply Unresolved
I am fine with master-only. -
Anja Leichsenring abandoned the change 08/23/21, 15:59
master only