Review main Merged

70281[TASK] Add declare(strict_types=1) in all FunctionalTests

Wouter Wolters CR +2 V +2 Hard +440 −1 updated 08/24/21, 19:08

Commit message

Strip declare declaration from concatenated ext_localconf files.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 220

Show 200 more files

Review log 1723

  1. Wouter Wolters uploaded patch set 1 08/07/21, 07:08

  2. core-ci voted on patch set 1 V -1 08/07/21, 07:21 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14232

  3. Wouter Wolters commented on patch set 1 08/07/21, 07:23

    This fails now because the ext_localconf cache file contains multiple declare strict declarations. Should we remove them in createExtLocalconfCacheEntry() function as we do with PHP start and end tag?
  4. Oliver Klee commented on patch set 1 08/07/21, 11:22

    Reply

    I like that idea. I propose having this as a separate bugfix change that goes into master and 10.4.
  5. Wouter Wolters uploaded patch set 2 08/07/21, 15:42

  6. core-ci voted on patch set 2 V -1 08/07/21, 16:05 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14246

  7. Wouter Wolters uploaded patch set 3 08/07/21, 16:50

  8. Wouter Wolters updated the commit message in patch set 4 08/07/21, 17:06

  9. core-ci voted on patch set 3 V -1 08/07/21, 17:13 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14248

  10. Wouter Wolters uploaded patch set 5 08/07/21, 17:18

  11. core-ci voted on patch set 5 V -1 08/07/21, 17:28 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14249

  12. Wouter Wolters uploaded patch set 6 08/07/21, 17:35

  13. core-ci voted on patch set 6 V -1 08/07/21, 17:38 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14250

  14. Wouter Wolters uploaded patch set 7 08/07/21, 17:40

  15. core-ci voted on patch set 7 V +1 08/07/21, 17:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14251

  16. Christian Kuhn voted on patch set 7 V +1 CR +1 08/08/21, 10:38

  17. Benni Mack voted on patch set 7 V +2 CR +2 08/08/21, 10:38

  18. Benni Mack commented on patch set 7 V 0 CR -1 08/08/21, 10:39

    Should we exclude ext_emconf, and TCA files?
  19. Benni Mack commented on patch set 7 V +2 CR +2 08/08/21, 10:40

    Let's get it in and see what needs adaption then.
  20. Benni Mack merged patch set 8 08/08/21, 10:40

  21. Benni Mack commented on patch set 8 08/08/21, 10:41

    ExtensionManagementUtility.php:1551

    this could indeed be made as backport to 10.4
  22. Wouter Wolters commented on patch set 8 08/13/21, 11:15

    ExtensionManagementUtility.php:1551 Reply

  23. Markus Klein commented on patch set 8 08/24/21, 19:08

    ExtensionManagementUtility.php:1551 Reply

    Please see comments in the backport on the regex.