Review main Merged

70282[BUGFIX] Correctly add uids to clearCacheForTables

Torben Hansen CR +2 V +2 Easy +1 −1 updated 08/08/21, 10:20

Commit message

In clearCacheForRecord() record uids are not added
to the previously initialized array, but they overwrite
the array resulting in an exception when
clearCachesOfRegisteredPageIds is called.

This change ensures uids are correctly added to the array.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 79

  1. Torben Hansen uploaded patch set 1 08/07/21, 12:11

  2. core-ci voted on patch set 1 V -1 08/07/21, 12:36 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14239

  3. Torben Hansen updated the commit message in patch set 2 08/08/21, 05:29

  4. core-ci voted on patch set 2 V +1 08/08/21, 05:43 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14262

  5. Benni Mack voted on patch set 2 V +1 CR +1 08/08/21, 07:17

  6. Benni Mack commented on patch set 2 08/08/21, 07:17

    Thanks for the findings!
  7. Christian Kuhn voted on patch set 2 V +1 CR +1 08/08/21, 10:19

  8. Benni Mack voted on patch set 2 V +2 CR +2 08/08/21, 10:20

  9. Benni Mack merged patch set 3 08/08/21, 10:20