Review main Merged

70283[BUGFIX] Fix some php 8 undefined array key errors

Nikita Hovratov CR +2 V +2 Easy +14 −14 updated 08/09/21, 17:21

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1218

  1. Nikita Hovratov uploaded patch set 1 08/07/21, 21:15

  2. core-ci voted on patch set 1 V +1 08/07/21, 21:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14254

  3. Nikita Hovratov uploaded patch set 2 08/07/21, 22:54

  4. core-ci voted on patch set 2 V +1 08/07/21, 23:04 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14257

  5. Nikita Hovratov uploaded patch set 3 08/07/21, 23:25

  6. core-ci voted on patch set 3 V +1 08/07/21, 23:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14258

  7. Benni Mack uploaded patch set 4 08/09/21, 08:25

  8. Benni Mack voted on patch set 4 V +1 CR +1 08/09/21, 08:26

  9. core-ci voted on patch set 4 V +1 08/09/21, 08:46 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14305

  10. Benni Mack uploaded patch set 5 08/09/21, 12:32

  11. core-ci voted on patch set 5 V +1 08/09/21, 12:44 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14328

  12. Nikita Hovratov commented on patch set 5 08/09/21, 13:49

    DatabaseIntegrityController.php:260

    Correct would be !empty here? If the value is 0, it would be true now.
  13. Benni Mack commented on patch set 6 08/09/21, 14:27

    Published edit on patch set 5.
  14. core-ci voted on patch set 6 V +1 08/09/21, 14:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14334

  15. Benni Mack commented on patch set 6 V +1 CR +1 08/09/21, 14:46

    DatabaseIntegrityController.php:260 Reply

    Ack
  16. Jochen Roth voted on patch set 6 V +1 CR +1 08/09/21, 16:30

  17. Benni Mack voted on patch set 6 V +2 CR +2 08/09/21, 17:21

  18. Benni Mack merged patch set 7 08/09/21, 17:21