Review 10.4 Merged

70284[BUGFIX] Only allow to edit metadata in FileList if metadata exists

Benni Mack CR +2 V +2 Easy +28 −22 updated 08/09/21, 08:19

Commit message

The pencil icon on the file list should only show up if
a metadata record exists, in order to avoid an error.

This case happens if a file wasn't indexed correctly
and the Indexer cannot open the file to create metadata
via the Scheduler, e.g. if the folder of the file has
an invalid character, such as "(blabla)" as suffix and
was uploaded externally via FTP.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Oli Bartsch +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Benni Mack uploaded patch set 1 08/08/21, 07:45

  2. core-ci voted on patch set 1 V +1 08/08/21, 07:55 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14263

  3. Wouter Wolters updated the commit message in patch set 2 08/08/21, 12:12

  4. Wouter Wolters voted on patch set 2 CR +1 08/08/21, 12:12

  5. core-ci voted on patch set 2 V +1 08/08/21, 12:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14272

  6. Daniel Goerz voted on patch set 2 V +1 CR +1 08/09/21, 08:14

  7. Oli Bartsch voted on patch set 2 V +1 CR +1 08/09/21, 08:18

  8. Benni Mack voted on patch set 2 V +2 CR +2 08/09/21, 08:19

  9. Benni Mack merged patch set 3 08/09/21, 08:19