Review main Merged

70288[TASK] Avoid root-only fields in extensions composer.json

Christian Kuhn CR +2 V +2 Normal +0 −209 updated 08/10/21, 06:26

Commit message

composer.json fields marked as root-only in
https://getcomposer.org/doc/04-schema.md are only
used if the composer.json is used as project root.

Core extensions and split repositories are never used
as project root directly and also won't work as such.
Testing is always performed on the monorepo.

All root-only fields are thus obsolete in extensions
composer.json, namely: require-dev, autoload-dev,
minimum-stability, prefer-stable, repositories,
config, scripts.

sortpackages: true in config field is kept since
this is useful when updating packages using
componer req something -d typo3/sysext/core_ext

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 32

Review log 911

  1. Christian Kuhn uploaded patch set 1 08/08/21, 12:24

  2. core-ci voted on patch set 1 V +1 08/08/21, 12:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14273

  3. Wouter Wolters voted on patch set 1 V +1 CR +1 08/08/21, 12:51

  4. Helmut Hummel commented on patch set 1 08/08/21, 16:41

    composer.json:18

    This is the only option, I'd likely keep as we sometimes use composer commands to add or remove packages from those and then this option will take effect. But also maybe only for core, as having dependencies of the other packages is questionable tbh.
  5. Christian Kuhn commented on patch set 1 CR -1 08/08/21, 16:46

    will update

    composer.json:18 Reply

    good point. config sort-packages has impact when doing "composer whatever -d typo3/sysext/something --no-update". will take care it's properly configured in all of them instead.
  6. Christian Kuhn uploaded patch set 2 08/09/21, 21:58

  7. Christian Kuhn commented on patch set 2 08/09/21, 21:59

    composer.json:18 Reply

    Done
  8. Wouter Wolters voted on patch set 2 V +1 CR +1 08/09/21, 22:00

  9. core-ci voted on patch set 2 V +1 08/09/21, 22:15 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14413

  10. Georg Ringer voted on patch set 2 V +2 CR +2 08/10/21, 06:26

  11. Georg Ringer merged patch set 3 08/10/21, 06:26