Review main Merged

70289[TASK] Avoid request dependent data in scheduler test task

Christian Kuhn CR +2 V +2 Easy +0 −10 updated 08/09/21, 08:34

Commit message

Accessing request dependent data in a scheduler
task is problematic on CLI. For this reason tasks
have no setRequest() method or similar.

The task does not loose much information avoiding
a GU::getIndpEnv() for the test mail, and the
setRequest() on the mail object is unused.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 69

  1. Christian Kuhn uploaded patch set 1 08/08/21, 13:08

  2. Christian Kuhn updated the commit message in patch set 2 08/08/21, 13:09

  3. core-ci voted on patch set 1 V -1 08/08/21, 13:11 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14274

  4. core-ci voted on patch set 2 V -1 08/08/21, 13:11 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14275

  5. Christian Kuhn uploaded patch set 3 08/08/21, 13:36

  6. core-ci voted on patch set 3 V +1 08/08/21, 13:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14276

  7. Anja Leichsenring voted on patch set 3 V +1 CR +1 08/09/21, 05:10

  8. Benni Mack voted on patch set 3 V +2 CR +2 08/09/21, 08:34

  9. Benni Mack merged patch set 4 08/09/21, 08:34