Review main Merged

70291[TASK] Remove usage of deprecated method `setMethods` in UnitTests

Wouter Wolters CR +2 V +2 Expert +541 −521 updated 08/12/21, 11:15

Commit message

The function `setMethods` in the MockBuilder class of PHPunit is deprecated.
Use `onlyMethods` or `addMethods` instead.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Marvin Dosse +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Marvin Dosse +1
    • core-ci +1 CI

Issues 1

Files 124

Show 104 more files

Review log 710

  1. Wouter Wolters uploaded patch set 1 08/08/21, 18:24

  2. Wouter Wolters uploaded patch set 2 08/08/21, 18:33

  3. core-ci voted on patch set 1 V -1 08/08/21, 18:36 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14287

  4. Wouter Wolters uploaded patch set 3 08/08/21, 18:43

  5. core-ci voted on patch set 2 V -1 08/08/21, 18:44 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14288

  6. core-ci voted on patch set 3 V +1 08/08/21, 18:54 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14289

  7. Marvin Dosse commented on patch set 3 V +1 CR +1 08/12/21, 10:54

    All tests passed successfully
  8. Oli Bartsch voted on patch set 3 V +2 CR +2 08/12/21, 11:15

  9. Oli Bartsch commented on patch set 3 08/12/21, 11:15

    Reply

    Ack
  10. Oli Bartsch merged patch set 4 08/12/21, 11:15