70291[TASK] Remove usage of deprecated method `setMethods` in UnitTests
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Marvin Dosse +1
-
Verified V +2 Done
- Oli Bartsch +2
- Marvin Dosse +1
- core-ci +1 CI
Issues 1
Files 124
- typo3/sysext/backend/Tests/Unit/Controller/File/FileControllerTest.php+3 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseDefaultLanguagePageRowTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseEditRowTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseLanguageRowsTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabasePageLanguageOverlayRowsTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseParentPageRowTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseRecordTypeValueTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/NodeFactoryTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/View/BackendLayout/BackendLayoutCollectionTest.php+4 −4
- typo3/sysext/backend/Tests/Unit/View/BackendLayout/DataProviderCollectionTest.php+4 −4
- typo3/sysext/belog/Tests/Unit/Domain/Repository/LogEntryRepositoryTest.php+2 −1
- typo3/sysext/belog/Tests/Unit/Domain/Repository/WorkspaceRepositoryTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Cache/Backend/Typo3DatabaseBackendTest.php+8 −8
- typo3/sysext/core/Tests/Functional/Error/ErrorHandlerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Authentication/AbstractUserAuthenticationTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Authentication/BackendUserAuthenticationTest.php+12 −12
- typo3/sysext/core/Tests/Unit/Cache/Backend/FileBackendTest.php+33 −33
- typo3/sysext/core/Tests/Unit/Cache/Frontend/AbstractFrontendTest.php+21 −17
- typo3/sysext/core/Tests/Unit/Cache/Frontend/PhpFrontendTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Cache/Frontend/VariableFrontendTest.php+17 −9
Show 104 more files
- typo3/sysext/core/Tests/Unit/Cache/CacheManagerTest.php+12 −12
- typo3/sysext/core/Tests/Unit/Command/SendEmailCommandTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Configuration/FlexForm/FlexFormToolsTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Configuration/ConfigurationManagerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/ConnectionTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/RelationHandlerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+5 −5
- typo3/sysext/core/Tests/Unit/Error/DebugExceptionHandlerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Error/ProductionExceptionHandlerTest.php+2 −2
- typo3/sysext/core/Tests/Unit/FormProtection/AbstractFormProtectionTest.php+6 −6
- typo3/sysext/core/Tests/Unit/Log/Processor/AbstractProcessorTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Log/Writer/DatabaseWriterTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Log/Writer/FileWriterTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Log/LoggerTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Mail/MailerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Package/PackageManagerTest.php+3 −2
- typo3/sysext/core/Tests/Unit/Page/PageRendererTest.php+2 −1
- typo3/sysext/core/Tests/Unit/Resource/Driver/LocalDriverTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/Index/ExtractorRegistryTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/Index/IndexerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/Processing/LocalPreviewHelperTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Resource/Rendering/RendererRegistryTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Resource/Service/ExtractorServiceTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Resource/TextExtraction/TextExtractorRegistryTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/AbstractFileTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/BaseTestCase.php+8 −8
- typo3/sysext/core/Tests/Unit/Resource/FileTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Resource/FolderTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/MetaDataAspectTest.php+5 −4
- typo3/sysext/core/Tests/Unit/Resource/ResourceStorageTest.php+11 −11
- typo3/sysext/core/Tests/Unit/Routing/SiteMatcherTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Service/FlexFormServiceTest.php+1 −1
- typo3/sysext/core/Tests/Unit/TypoScript/TemplateServiceTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Utility/File/ExtendedFileUtilityTest.php+6 −6
- typo3/sysext/core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php+29 −29
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+6 −6
- typo3/sysext/extbase/Tests/Unit/Configuration/FrontendConfigurationManagerTest.php+4 −4
- typo3/sysext/extbase/Tests/Unit/Hook/DataHandler/CheckFlexFormValueTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/ActionControllerTest.php+11 −8
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/MvcPropertyMappingConfigurationServiceTest.php+7 −7
- typo3/sysext/extbase/Tests/Unit/Mvc/View/JsonViewTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Object/Container/ContainerTest.php+3 −2
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapFactoryTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php+7 −7
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Storage/Typo3DbBackendTest.php+7 −6
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Storage/Typo3DbQueryParserTest.php+11 −11
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/BackendTest.php+3 −3
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/PersistenceManagerTest.php+5 −8
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryFactoryTest.php+3 −2
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/SessionTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Persistence/RepositoryTest.php+6 −6
- typo3/sysext/extbase/Tests/Unit/Utility/DebuggerUtilityTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/AlphanumericValidatorTest.php+4 −4
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/BooleanValidatorTest.php+8 −8
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/CollectionValidatorTest.php+3 −3
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/ConjunctionValidatorTest.php+11 −11
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/DateTimeValidatorTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/DisjunctionValidatorTest.php+4 −4
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/FloatValidatorTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/GenericObjectValidatorTest.php+5 −5
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/IntegerValidatorTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/NotEmptyValidatorTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/NumberRangeValidatorTest.php+4 −4
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/NumberValidatorTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/StringLengthValidatorTest.php+4 −4
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/StringValidatorTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/TextValidatorTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/UrlValidatorTest.php+1 −1
- typo3/sysext/extbase/Tests/UnitDeprecated/Configuration/FrontendConfigurationManagerTest.php+1 −1
- typo3/sysext/extbase/Tests/UnitDeprecated/Domain/Repository/BackendUserGroupRepositoryTest.php+1 −1
- typo3/sysext/extbase/Tests/UnitDeprecated/Domain/Repository/BackendUserRepositoryTest.php+1 −1
- typo3/sysext/extbase/Tests/UnitDeprecated/Object/Container/ContainerTest.php+4 −3
- typo3/sysext/extbase/Tests/UnitDeprecated/SignalSlot/DispatcherTest.php+10 −10
- typo3/sysext/extensionmanager/Tests/Unit/Utility/DependencyUtilityTest.php+8 −8
- typo3/sysext/extensionmanager/Tests/Unit/Utility/InstallUtilityTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/Core/Cache/FluidTemplateCacheTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/Core/Rendering/RenderingContextTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/View/AbstractTemplateViewTest.php+2 −2
- typo3/sysext/fluid/Tests/Unit/View/TemplatePathsTest.php+1 −1
- typo3/sysext/form/Tests/Unit/Domain/Finishers/SaveToDatabaseFinisherTest.php+2 −2
- typo3/sysext/form/Tests/Unit/Domain/FormElements/AbstractSectionTest.php+5 −5
- typo3/sysext/form/Tests/Unit/Mvc/Persistence/FormPersistenceManagerTest.php+6 −6
- typo3/sysext/form/Tests/Unit/Mvc/Property/PropertyMappingConfigurationTest.php+4 −4
- typo3/sysext/form/Tests/Unit/Mvc/Validation/CountValidatorTest.php+5 −5
- typo3/sysext/form/Tests/Unit/Mvc/Validation/DateRangeValidatorTest.php+9 −9
- typo3/sysext/form/Tests/Unit/Mvc/Validation/EmptyValidatorTest.php+7 −7
- typo3/sysext/form/Tests/Unit/Mvc/Validation/FileSizeValidatorTest.php+6 −6
- typo3/sysext/form/Tests/Unit/Mvc/Validation/MimeTypeValidatorTest.php+6 −6
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+5 −5
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php+3 −3
- typo3/sysext/frontend/Tests/Unit/ContentObject/CaseContentObjectTest.php+1 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+39 −39
- typo3/sysext/frontend/Tests/Unit/ContentObject/FilesContentObjectTest.php+7 −7
- typo3/sysext/frontend/Tests/Unit/ContentObject/FluidTemplateContentObjectTest.php+5 −5
- typo3/sysext/frontend/Tests/Unit/ContentObject/ImageContentObjectTest.php+4 −4
- typo3/sysext/frontend/Tests/Unit/Controller/TypoScriptFrontendControllerTest.php+3 −3
- typo3/sysext/frontend/Tests/Unit/Middleware/PageResolverTest.php+6 −6
- typo3/sysext/frontend/Tests/Unit/Plugin/AbstractPluginTest.php+1 −1
- typo3/sysext/frontend/Tests/Unit/Processor/GalleryProcessorTest.php+1 −1
- typo3/sysext/install/Tests/Unit/Controller/UpgradeControllerTest.php+1 −1
- typo3/sysext/install/Tests/Unit/FolderStructure/DirectoryNodeTest.php+2 −2
- typo3/sysext/install/Tests/Unit/Service/SilentConfigurationUpgradeServiceTest.php+1 −1
- typo3/sysext/recycler/Tests/Unit/Task/CleanerFieldProviderTest.php+4 −4
- typo3/sysext/scheduler/Tests/Unit/Task/CachingFrameworkGarbageCollectionTest.php+2 −2
Review log 710
-
Wouter Wolters uploaded patch set 1 08/08/21, 18:24
-
Wouter Wolters uploaded patch set 2 08/08/21, 18:33
-
core-ci voted on patch set 1 V -1 08/08/21, 18:36 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14287
-
Wouter Wolters uploaded patch set 3 08/08/21, 18:43
-
core-ci voted on patch set 2 V -1 08/08/21, 18:44 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14288
-
core-ci voted on patch set 3 V +1 08/08/21, 18:54 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14289
-
Marvin Dosse commented on patch set 3 V +1 CR +1 08/12/21, 10:54
All tests passed successfully -
Oli Bartsch voted on patch set 3 V +2 CR +2 08/12/21, 11:15
-
Oli Bartsch commented on patch set 3 08/12/21, 11:15
Reply
Ack -
Oli Bartsch merged patch set 4 08/12/21, 11:15