70292[TASK] Improve PHPunit used assertions
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Roman Büchler +1
-
Verified V +2 Done
- Georg Ringer +2
- Roman Büchler +1
- core-ci +1 CI
Issues 1
Files 90
- typo3/sysext/beuser/Tests/Unit/Domain/Model/BackendUserTest.php+4 −4
- typo3/sysext/core/Tests/Acceptance/Backend/InstallTool/LoginCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Backend/Login/BackendLoginCest.php+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DefaultValuesTest.php+7 −7
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DeleteTranslatedSubpagesTest.php+1 −1
- typo3/sysext/core/Tests/Functional/IO/PharStreamWrapperInterceptorTest.php+8 −2
- typo3/sysext/core/Tests/Functional/Messaging/FlashMessageQueueTest.php+2 −2
- typo3/sysext/core/Tests/Functional/Resource/ResourceStorageTest.php+3 −3
- typo3/sysext/core/Tests/Functional/Session/Backend/DatabaseSessionBackendTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Session/Backend/RedisSessionBackendTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Crypto/PasswordHashing/Argon2idPasswordHashTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Crypto/PasswordHashing/Argon2iPasswordHashTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Crypto/PasswordHashing/BcryptPasswordHashTest.php+1 −1
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/DependencyInjection/FailsafeContainerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/EventDispatcher/ListenerProviderTest.php+2 −2
- typo3/sysext/core/Tests/Unit/FormProtection/FormProtectionFactoryTest.php+4 −1
- typo3/sysext/core/Tests/Unit/Http/MessageTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Http/RequestFactoryTest.php+0 −6
- typo3/sysext/core/Tests/Unit/Http/RequestTest.php+1 −1
Show 70 more files
- typo3/sysext/core/Tests/Unit/Http/ResponseFactoryTest.php+0 −12
- typo3/sysext/core/Tests/Unit/Http/ResponseTest.php+0 −21
- typo3/sysext/core/Tests/Unit/Http/ServerRequestFactoryTest.php+5 −8
- typo3/sysext/core/Tests/Unit/Http/StreamFactoryTest.php+0 −33
- typo3/sysext/core/Tests/Unit/Http/StreamTest.php+6 −2
- typo3/sysext/core/Tests/Unit/Http/UploadedFileFactoryTest.php+0 −12
- typo3/sysext/core/Tests/Unit/Http/UploadedFileTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Http/UriFactoryTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Imaging/IconRegistryTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Locking/FileLockStrategyTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Locking/SemaphoreLockStrategyTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Locking/SimpleLockStrategyTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Package/AbstractServiceProviderTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Package/PackageManagerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Page/PageRendererTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/Driver/LocalDriverTest.php+10 −10
- typo3/sysext/core/Tests/Unit/Resource/Index/ExtractorRegistryTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Resource/Rendering/RendererRegistryTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Resource/ResourceCompressorTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/ResourceStorageTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Site/Entity/SiteTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+36 −40
- typo3/sysext/core/Tests/Unit/Utility/MailUtilityTest.php+2 −2
- typo3/sysext/core/Tests/UnitDeprecated/Category/CategoryRegistryTest.php+3 −3
- typo3/sysext/extbase/Tests/Functional/Mvc/Web/RequestBuilderTest.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/ImplementationClassNameTest.php2+0 −6
- typo3/sysext/extbase/Tests/Functional/Persistence/QueryParserTest.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Persistence/RelationTest.php+3 −3
- typo3/sysext/extbase/Tests/Functional/Persistence/TranslationTest.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Persistence/WorkspaceTest.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Validation/ValidatorResolverTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Mvc/View/JsonViewTest.php+0 −3
- typo3/sysext/extbase/Tests/Unit/Mvc/Web/Routing/UriBuilderTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Object/Container/ContainerTest.php+0 −9
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php+0 −3
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryFactoryTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/SessionTest.php+3 −3
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Typo3QuerySettingsTest.php+10 −7
- typo3/sysext/extbase/Tests/Unit/Persistence/ObjectStorageTest.php+29 −29
- typo3/sysext/extbase/Tests/Unit/Persistence/RepositoryTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Reflection/ObjectAccessTest.php+5 −5
- typo3/sysext/extbase/Tests/Unit/Security/Cryptography/HashServiceTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Utility/ExtensionUtilityTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/AlphanumericValidatorTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/ConjunctionValidatorTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/FloatValidatorTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/IntegerValidatorTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/NotEmptyValidatorTest.php+2 −2
- typo3/sysext/extbase/Tests/UnitDeprecated/Domain/Model/BackendUserGroupTest.php+4 −4
- typo3/sysext/extbase/Tests/UnitDeprecated/Domain/Model/FrontendUserGroupTest.php+5 −5
- typo3/sysext/extbase/Tests/UnitDeprecated/Domain/Model/FrontendUserTest.php+4 −4
- typo3/sysext/extensionmanager/Tests/Unit/Controller/ActionControllerTest.php+7 −7
- typo3/sysext/extensionmanager/Tests/Unit/Domain/Model/DownloadQueueTest.php+2 −2
- typo3/sysext/extensionmanager/Tests/Unit/Domain/Repository/ExtensionRepositoryTest.php+1 −1
- typo3/sysext/extensionmanager/Tests/Unit/Report/ExtensionStatusTest.php+8 −8
- typo3/sysext/extensionmanager/Tests/Unit/Utility/FileHandlingUtilityTest.php+8 −8
- typo3/sysext/form/Tests/Unit/Domain/Finishers/AbstractFinisherTest.php+4 −1
- typo3/sysext/form/Tests/Unit/Domain/Finishers/SaveToDatabaseFinisherTest.php+1 −1
- typo3/sysext/form/Tests/Unit/Domain/FormElements/AbstractFormElementTest.php+7 −7
- typo3/sysext/form/Tests/Unit/Domain/FormElements/SectionTest.php+4 −4
- typo3/sysext/form/Tests/Unit/Mvc/Persistence/FormPersistenceManagerTest.php+2 −2
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php+3 −3
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+3 −3
- typo3/sysext/frontend/Tests/Unit/ContentObject/ImageContentObjectTest.php+4 −4
- typo3/sysext/frontend/Tests/Unit/Page/PageLayoutResolverTest.php+7 −7
- typo3/sysext/indexed_search/Tests/Unit/IndexerTest.php+5 −5
- typo3/sysext/install/Tests/Functional/Updates/RowUpdater/WorkspaceVersionRecordMigrationTest.php+1 −1
- typo3/sysext/install/Tests/Unit/Service/SilentConfigurationUpgradeServiceTest.php+6 −6
- typo3/sysext/linkvalidator/Tests/Functional/Repository/BrokenLinkRepositoryTest.php+1 −1
- typo3/sysext/workspaces/Tests/Functional/Service/WorkspaceServiceTest.php+5 −5
Review log 1115
-
Wouter Wolters uploaded patch set 1 08/08/21, 22:52
-
core-ci voted on patch set 1 V -1 08/08/21, 22:54 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14291
-
Wouter Wolters uploaded patch set 2 08/08/21, 22:58
-
Wouter Wolters uploaded patch set 3 08/08/21, 23:10
-
core-ci voted on patch set 2 V -1 08/08/21, 23:11 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14292
-
core-ci voted on patch set 3 V -1 08/08/21, 23:23 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14293
-
Wouter Wolters uploaded patch set 4 08/09/21, 09:03
-
core-ci voted on patch set 4 V +1 08/09/21, 09:19 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14311
-
Andreas Kienast commented on patch set 4 08/09/21, 09:52
This looks like php-cs-fixer - does it make sense to update the configuration as well, or does it have any negative side effects? -
Wouter Wolters commented on patch set 4 08/09/21, 09:54
Reply
This is not php-cs-fixer. Most of the stuff is PHPstorm or PHP EA extended plugin related. -
Roman Büchler voted on patch set 4 V +1 CR +1 08/12/21, 12:08
-
Georg Ringer voted on patch set 4 V +2 CR +2 08/12/21, 12:18
-
Georg Ringer merged patch set 5 08/12/21, 12:18
-
Christian Kuhn commented on patch set 5 08/12/21, 12:27
ImplementationClassNameTest.php:44post -1. i think this breaks counting of tests in the functional splitter?! -
Wouter Wolters commented on patch set 5 08/13/21, 09:53
ImplementationClassNameTest.php:44ReplyDone