Review main Merged

70292[TASK] Improve PHPunit used assertions

Wouter Wolters CR +2 V +2 Hard +295 −391 updated 08/13/21, 09:53

Commit message

Main changes are:

* Use assertArrayHasKey/assertArrayNotHasKey instead of array_key_exists.
* Fix misordered assertEquals/assertNotEquals arguments.
* Use assertCount instead of assertEquals and count() method.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Roman Büchler +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Roman Büchler +1
    • core-ci +1 CI

Issues 1

Files 90

Show 70 more files

Review log 1115

  1. Wouter Wolters uploaded patch set 1 08/08/21, 22:52

  2. core-ci voted on patch set 1 V -1 08/08/21, 22:54 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14291

  3. Wouter Wolters uploaded patch set 2 08/08/21, 22:58

  4. Wouter Wolters uploaded patch set 3 08/08/21, 23:10

  5. core-ci voted on patch set 2 V -1 08/08/21, 23:11 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14292

  6. core-ci voted on patch set 3 V -1 08/08/21, 23:23 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14293

  7. Wouter Wolters uploaded patch set 4 08/09/21, 09:03

  8. core-ci voted on patch set 4 V +1 08/09/21, 09:19 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14311

  9. Andreas Kienast commented on patch set 4 08/09/21, 09:52

    This looks like php-cs-fixer - does it make sense to update the configuration as well, or does it have any negative side effects?
  10. Wouter Wolters commented on patch set 4 08/09/21, 09:54

    Reply

    This is not php-cs-fixer. Most of the stuff is PHPstorm or PHP EA extended plugin related.
  11. Roman Büchler voted on patch set 4 V +1 CR +1 08/12/21, 12:08

  12. Georg Ringer voted on patch set 4 V +2 CR +2 08/12/21, 12:18

  13. Georg Ringer merged patch set 5 08/12/21, 12:18

  14. Christian Kuhn commented on patch set 5 08/12/21, 12:27

    ImplementationClassNameTest.php:44

    post -1. i think this breaks counting of tests in the functional splitter?!
  15. Wouter Wolters commented on patch set 5 08/13/21, 09:53

    ImplementationClassNameTest.php:44 Reply

    Done