Review main Merged

70299[TASK] Remove unused goto label self in SaveToDatabaseFinisherTest

Wouter Wolters CR +2 V +2 Easy +1 −1 updated 08/10/21, 04:04

Commit message

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Wouter Wolters uploaded patch set 1 08/09/21, 09:56

  2. core-ci voted on patch set 1 V +1 08/09/21, 10:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14317

  3. Oliver Hader voted on patch set 1 CR +1 08/09/21, 10:31

  4. Christian Kuhn commented on patch set 1 V +1 CR +1 08/09/21, 11:10

    out of curiosity:
  5. Christian Kuhn commented on patch set 1 08/09/21, 22:10

    Reply

    > out of curiosity: ... what did self:self:: do (one colon?). does not need to be answered, though. patch is obviously fine.
  6. Oli Bartsch voted on patch set 1 V +2 CR +2 08/10/21, 04:04

  7. Oli Bartsch merged patch set 2 08/10/21, 04:04