Review main Merged

70300[TASK] Remove unused iconRegistry in CheckboxLabeledToggleElement

Wouter Wolters CR +2 V +2 Easy +0 −18 updated 08/09/21, 15:30

Commit message

Constructor is removed as well because it is the same as the parent class.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Wouter Wolters uploaded patch set 1 08/09/21, 10:01

  2. core-ci voted on patch set 1 V +1 08/09/21, 10:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14318

  3. Oliver Hader voted on patch set 1 CR +1 08/09/21, 10:33

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 08/09/21, 11:11

  5. Benni Mack voted on patch set 1 V +2 CR +2 08/09/21, 15:30

  6. Benni Mack merged patch set 2 08/09/21, 15:30