Review main Abandoned

70302[BUGFIX] Add fallback for undefined array keys in PHP8

Jochen Roth CR 0 V 0 Easy +13 −13 updated 08/12/21, 12:43

Commit message

In EXT:impexp several undefined array key warning
have been fixed by adding a fallback value.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 79

  1. Jochen Roth uploaded patch set 1 08/09/21, 10:45

  2. core-ci voted on patch set 1 V +1 08/09/21, 10:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14322

  3. Oli Bartsch commented on patch set 1 08/10/21, 19:05

    ExportController.php:412

    In case the previous behaviour is important this hast to be: $GLOBALS['TCA'][$table]['ctrl']['sortby'] ?? '') ?: $GLOBALS['TCA'][$table]['ctrl']['default_sortby'] ?? '';
  4. Jochen Roth uploaded patch set 2 08/11/21, 09:45

  5. Jochen Roth commented on patch set 2 08/11/21, 09:46

    ExportController.php:412 Reply

    Ack
  6. core-ci voted on patch set 2 V +1 08/11/21, 10:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14565

  7. Christian Kuhn commented on patch set 2 CR -1 08/11/21, 17:25

  8. Jochen Roth abandoned the change 08/12/21, 12:43

    Changes are already included in the mentioned patch
  9. Jochen Roth commented on patch set 2 08/12/21, 12:43

    Reply

    All changes are already done in the mentioned patch. I'll abandon this one.