70304[TASK] Remove inappropriate @inheritDoc usages
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Christian Kuhn +1
-
Verified V +2 Done
- Georg Ringer +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1215
-
Wouter Wolters uploaded patch set 1 08/09/21, 11:37
-
core-ci voted on patch set 1 V -1 08/09/21, 11:40 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14324
-
Wouter Wolters commented on patch set 2 08/09/21, 11:45
Published edit on patch set 1. -
core-ci voted on patch set 2 V +1 08/09/21, 11:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14326
-
Oliver Klee commented on patch set 2 08/09/21, 12:18
RenderViewHelper.php:20UnresolvedI propose removing the comment altogether. (The comment looks auto-generated, and it does not provide any information.) -
Wouter Wolters commented on patch set 3 08/09/21, 12:20
Published edit on patch set 2. -
core-ci voted on patch set 3 V +1 08/09/21, 12:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14327
-
Benni Mack commented on patch set 3 08/09/21, 15:11
Why arePreviewModule.php:48why is this one "inappropriate" while the next one isn't? -
Wouter Wolters commented on patch set 3 08/09/21, 15:33
PreviewModule.php:48Replybecause this method is not in a parent class or interface. The getIdentifier is in ModuleInterface -
Christian Kuhn commented on patch set 3 08/09/21, 21:38
RenderViewHelper.php:21don't understand this one: \TYPO3Fluid\Fluid\ViewHelpers\RenderViewHelper does have a rather useful class header.AbstractFormFactory.php:31good. -
Christian Kuhn commented on patch set 3 08/09/21, 21:39
PreviewModule.php:48Replyyeah. good to go.AbstractFormFactory.php:31Replygood. -
Wouter Wolters commented on patch set 3 08/09/21, 21:48
RenderViewHelper.php:21Reply@inheritDoc should be used only on class members -
Christian Kuhn commented on patch set 3 V +1 CR +1 08/09/21, 22:40
RenderViewHelper.php:21Replyalright. wasn't aware of that. -
Georg Ringer voted on patch set 3 V +2 CR +2 08/10/21, 06:25
-
Georg Ringer merged patch set 4 08/10/21, 06:25