Review main Merged

70304[TASK] Remove inappropriate @inheritDoc usages

Wouter Wolters CR +2 V +2 Easy +0 −9 updated 08/10/21, 06:25

Commit message

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1215

  1. Wouter Wolters uploaded patch set 1 08/09/21, 11:37

  2. core-ci voted on patch set 1 V -1 08/09/21, 11:40 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14324

  3. Wouter Wolters commented on patch set 2 08/09/21, 11:45

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 08/09/21, 11:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14326

  5. Oliver Klee commented on patch set 2 08/09/21, 12:18

    RenderViewHelper.php:20 Unresolved

    I propose removing the comment altogether. (The comment looks auto-generated, and it does not provide any information.)
  6. Wouter Wolters commented on patch set 3 08/09/21, 12:20

    Published edit on patch set 2.
  7. core-ci voted on patch set 3 V +1 08/09/21, 12:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14327

  8. Benni Mack commented on patch set 3 08/09/21, 15:11

    Why are

    PreviewModule.php:48

    why is this one "inappropriate" while the next one isn't?
  9. Wouter Wolters commented on patch set 3 08/09/21, 15:33

    PreviewModule.php:48 Reply

    because this method is not in a parent class or interface. The getIdentifier is in ModuleInterface
  10. Christian Kuhn commented on patch set 3 08/09/21, 21:38

    RenderViewHelper.php:21

    don't understand this one: \TYPO3Fluid\Fluid\ViewHelpers\RenderViewHelper does have a rather useful class header.

    AbstractFormFactory.php:31

    good.
  11. Christian Kuhn commented on patch set 3 08/09/21, 21:39

    PreviewModule.php:48 Reply

    yeah. good to go.

    AbstractFormFactory.php:31 Reply

    good.
  12. Wouter Wolters commented on patch set 3 08/09/21, 21:48

    RenderViewHelper.php:21 Reply

    @inheritDoc should be used only on class members
  13. Christian Kuhn commented on patch set 3 V +1 CR +1 08/09/21, 22:40

    RenderViewHelper.php:21 Reply

    alright. wasn't aware of that.
  14. Georg Ringer voted on patch set 3 V +2 CR +2 08/10/21, 06:25

  15. Georg Ringer merged patch set 4 08/10/21, 06:25