70306[BUGFIX] Add fallback for undefined array keys in cli
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 11
- typo3/sysext/core/Tests/Acceptance/Application/Cli/CommandCest.php1new+74 −0
- typo3/sysext/core/Tests/Acceptance/Application/DbCheck/DbCheckModuleCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Application.suite.yml+1 −0
- typo3/sysext/install/Classes/Command/LanguagePackCommand.php3+1 −1
- typo3/sysext/lowlevel/Classes/Command/ListSysLogCommand.php+1 −1
- typo3/sysext/lowlevel/Classes/Command/MissingRelationsCommand.php+1 −1
- typo3/sysext/lowlevel/Classes/Command/OrphanRecordsCommand.php+1 −1
- typo3/sysext/redirects/Classes/Service/IntegrityService.php+1 −1
- typo3/sysext/workspaces/Classes/Command/WorkspaceVersionRecordsCommand.php+1 −1
- composer.json+1 −0
- composer.lock+48 −1
Review log 2339
Show 714 earlier messages
-
Jochen Roth uploaded patch set 1 08/09/21, 13:32
-
core-ci voted on patch set 1 V -1 08/09/21, 13:48 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14331
-
Jochen Roth uploaded patch set 2 08/09/21, 13:54
-
core-ci voted on patch set 2 V -1 08/09/21, 14:13 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14333
-
Jochen Roth uploaded patch set 3 08/09/21, 14:29
-
core-ci voted on patch set 3 V -1 08/09/21, 14:47 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14335
-
Jochen Roth uploaded patch set 4 08/10/21, 10:50
-
core-ci voted on patch set 4 V -1 08/10/21, 10:55 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14470
-
Jochen Roth uploaded patch set 5 08/12/21, 13:10
-
Jochen Roth updated the commit message in patch set 6 08/12/21, 13:23
-
core-ci voted on patch set 5 V -1 08/12/21, 13:29 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14730
-
core-ci voted on patch set 6 V -1 08/12/21, 13:38 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14732
-
Jochen Roth uploaded patch set 7 08/12/21, 13:52
-
core-ci voted on patch set 7 V +1 08/12/21, 14:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14744
-
Jochen Roth uploaded patch set 8 08/13/21, 09:00
-
core-ci voted on patch set 8 V +1 08/13/21, 09:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14899
-
Jochen Roth uploaded patch set 9 08/14/21, 16:23
-
core-ci voted on patch set 9 V +1 08/14/21, 16:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15098
-
Jochen Roth uploaded patch set 10 08/17/21, 14:40
-
core-ci voted on patch set 10 V +1 08/17/21, 14:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15239
-
Jochen Roth uploaded patch set 11 08/24/21, 08:53
-
core-ci voted on patch set 11 V -1 08/24/21, 09:17 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15481
-
Jochen Roth uploaded patch set 12 08/24/21, 13:29
-
core-ci voted on patch set 12 V +1 08/24/21, 13:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15510
-
Jochen Roth uploaded patch set 13 08/26/21, 08:43
-
core-ci voted on patch set 13 V -1 08/26/21, 08:49 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15655
-
Jochen Roth uploaded patch set 14 08/26/21, 12:59
-
core-ci voted on patch set 14 V +1 08/26/21, 13:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15673
-
Oli Bartsch commented on patch set 14 08/26/21, 14:19
LanguagePackCommand.php:129Why do we need to write an empty line? -
Jochen Roth uploaded patch set 15 08/26/21, 14:58
-
core-ci voted on patch set 15 V +1 08/26/21, 15:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15680
-
Jochen Roth uploaded patch set 16 08/26/21, 15:42
-
core-ci voted on patch set 16 V +1 08/26/21, 16:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15681
-
Jochen Roth commented on patch set 16 08/26/21, 16:07
PageTreeFilterCest.php:58ReplyFor whatever reason this works now without waiting for elements. Therefore remove that change.LanguagePackCommand.php:129ReplyTo make sure the command prompt is clean, without it the output looks like this ``` ./bin/typo3 language:update ... ... ... 70/70 [============================] 100%jochen@typo3-dev-web:/var/www/html$ ``` -
Oli Bartsch commented on patch set 16 08/26/21, 16:23
LanguagePackCommand.php:129Reply UnresolvedAll right, could we add a comment for this? -
Christian Kuhn commented on patch set 16 08/26/21, 16:27
CommandCest.php:62Unresolvedlanguage:update "phones home". So this will fail when typo3.org translations system is down. I'll accept that for now, but me may have to disable that, if it shows flakiness. -
Oli Bartsch voted on patch set 16 V +1 CR +1 08/26/21, 16:48
-
Christian Kuhn voted on patch set 16 V +2 CR +2 08/26/21, 16:53
-
Christian Kuhn merged patch set 17 08/26/21, 16:53
PageTreeFilterCest.php:58