Review main Merged

70306[BUGFIX] Add fallback for undefined array keys in cli

Jochen Roth CR +2 V +2 Normal +132 −9 updated 08/26/21, 16:53

Commit message

Cli commands were fixed by adding a fallback where
undefined array key warning occured. Added tests
as well to make sure it will work ever after.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 2339

Show 714 earlier messages
  1. Jochen Roth uploaded patch set 1 08/09/21, 13:32

  2. core-ci voted on patch set 1 V -1 08/09/21, 13:48 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14331

  3. Jochen Roth uploaded patch set 2 08/09/21, 13:54

  4. core-ci voted on patch set 2 V -1 08/09/21, 14:13 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14333

  5. Jochen Roth uploaded patch set 3 08/09/21, 14:29

  6. core-ci voted on patch set 3 V -1 08/09/21, 14:47 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14335

  7. Jochen Roth uploaded patch set 4 08/10/21, 10:50

  8. core-ci voted on patch set 4 V -1 08/10/21, 10:55 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14470

  9. Jochen Roth uploaded patch set 5 08/12/21, 13:10

  10. Jochen Roth updated the commit message in patch set 6 08/12/21, 13:23

  11. core-ci voted on patch set 5 V -1 08/12/21, 13:29 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14730

  12. core-ci voted on patch set 6 V -1 08/12/21, 13:38 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14732

  13. Jochen Roth uploaded patch set 7 08/12/21, 13:52

  14. core-ci voted on patch set 7 V +1 08/12/21, 14:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14744

  1. Jochen Roth uploaded patch set 8 08/13/21, 09:00

  2. core-ci voted on patch set 8 V +1 08/13/21, 09:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14899

  3. Jochen Roth uploaded patch set 9 08/14/21, 16:23

  4. core-ci voted on patch set 9 V +1 08/14/21, 16:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15098

  5. Jochen Roth uploaded patch set 10 08/17/21, 14:40

  6. core-ci voted on patch set 10 V +1 08/17/21, 14:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15239

  7. Jochen Roth uploaded patch set 11 08/24/21, 08:53

  8. core-ci voted on patch set 11 V -1 08/24/21, 09:17 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15481

  9. Jochen Roth uploaded patch set 12 08/24/21, 13:29

  10. core-ci voted on patch set 12 V +1 08/24/21, 13:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15510

  11. Jochen Roth uploaded patch set 13 08/26/21, 08:43

  12. core-ci voted on patch set 13 V -1 08/26/21, 08:49 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15655

  13. Jochen Roth uploaded patch set 14 08/26/21, 12:59

  14. core-ci voted on patch set 14 V +1 08/26/21, 13:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15673

  15. Oli Bartsch commented on patch set 14 08/26/21, 14:19

    PageTreeFilterCest.php:58

    Wouldn't a `waitForElement` be a better solution? Just asking as such calls might lead to arbitrary test failures depending on the current test env performance.

    LanguagePackCommand.php:129

    Why do we need to write an empty line?
  16. Jochen Roth uploaded patch set 15 08/26/21, 14:58

  17. core-ci voted on patch set 15 V +1 08/26/21, 15:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15680

  18. Jochen Roth uploaded patch set 16 08/26/21, 15:42

  19. core-ci voted on patch set 16 V +1 08/26/21, 16:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15681

  20. Jochen Roth commented on patch set 16 08/26/21, 16:07

    PageTreeFilterCest.php:58 Reply

    For whatever reason this works now without waiting for elements. Therefore remove that change.

    LanguagePackCommand.php:129 Reply

    To make sure the command prompt is clean, without it the output looks like this ``` ./bin/typo3 language:update ... ... ... 70/70 [============================] 100%jochen@typo3-dev-web:/var/www/html$ ```
  21. Oli Bartsch commented on patch set 16 08/26/21, 16:23

    LanguagePackCommand.php:129 Reply Unresolved

    All right, could we add a comment for this?
  22. Christian Kuhn commented on patch set 16 08/26/21, 16:27

    CommandCest.php:62 Unresolved

    language:update "phones home". So this will fail when typo3.org translations system is down. I'll accept that for now, but me may have to disable that, if it shows flakiness.
  23. Oli Bartsch voted on patch set 16 V +1 CR +1 08/26/21, 16:48

  24. Christian Kuhn voted on patch set 16 V +2 CR +2 08/26/21, 16:53

  25. Christian Kuhn merged patch set 17 08/26/21, 16:53