Review main Merged

70308[TASK] Restore newRecord level button behaviour

Oli Bartsch CR +2 V +2 Easy +7 −28 updated 08/09/21, 20:33

Commit message

Since #82489 the "enabledControls['new']" option
did not longer hide the "New record" button of inline
containers as this was considered a misuse and led
to some misbehaviour. This option should only affect
the action buttons of each inline record.

However since this can be considered a breaking change,
especially because there is currently no option available
to only hide the "New record" button, the whole change
is reverted now and will only be fixed in a separate patch
for v11. This will be done by introducing a dedicated option
for the "new record" button and by deprecating the "none"
value of the "levelLinksPosition" option.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 1013

  1. Oli Bartsch uploaded patch set 1 08/09/21, 15:56

  2. Oli Bartsch updated the commit message in patch set 2 08/09/21, 15:56

  3. core-ci voted on patch set 1 V +1 08/09/21, 16:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14340

  4. core-ci voted on patch set 2 V +1 08/09/21, 17:02 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14341

  5. Christian Kuhn voted on patch set 2 CR +1 08/09/21, 17:19

  6. Andreas Kienast voted on patch set 2 CR +1 08/09/21, 17:30

  7. Oli Bartsch updated the commit message in patch set 3 08/09/21, 18:14

  8. Benni Mack voted on patch set 3 V +1 CR +1 08/09/21, 18:21

  9. core-ci voted on patch set 3 V +1 08/09/21, 18:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14396

  10. Andreas Kienast voted on patch set 3 CR +1 08/09/21, 18:30

  11. Christian Kuhn voted on patch set 3 V +1 CR +1 08/09/21, 20:30

  12. Oli Bartsch voted on patch set 3 V +2 CR +2 08/09/21, 20:33

  13. Oli Bartsch merged patch set 4 08/09/21, 20:33