Review 10.4 Merged

70309[TASK] Restore newRecord level button behaviour

Oli Bartsch CR +2 V +2 Easy +7 −28 updated 08/09/21, 20:35

Commit message

Since #82489 the "enabledControls['new']" option
did not longer hide the "New record" button of inline
containers as this was considered a misuse and led
to some misbehaviour. This option should only affect
the action buttons of each inline record.

However since this can be considered a breaking change,
especially because there is currently no option available
to only hide the "New record" button, the whole change
is reverted now and will only be fixed in a separate patch
for v11. This will be done by introducing a dedicated option
for the "new record" button and by deprecating the "none"
value of the "levelLinksPosition" option.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 3

Files 2

Review log 46

  1. Oli Bartsch uploaded patch set 1 08/09/21, 16:01

  2. core-ci voted on patch set 1 V +1 08/09/21, 17:03 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14342

  3. Oli Bartsch updated the commit message in patch set 2 08/09/21, 18:14

  4. core-ci voted on patch set 2 V +1 08/09/21, 18:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14395

  5. Oli Bartsch voted on patch set 2 V +2 CR +2 08/09/21, 20:35

  6. Oli Bartsch merged patch set 3 08/09/21, 20:35