Review main Merged

70313[TASK] Remove obsolete inline JavaScript related to BE routing

Benni Mack CR +2 V +2 Normal +29 −93 updated 08/09/21, 19:51

Commit message

Various functionality regarding inline jumping to
Backend modules / Page Module is now obsolete
due to the introduced backend routing with TYPO3 v11.2.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1012

  1. Benni Mack uploaded patch set 1 08/09/21, 16:53

  2. Benni Mack updated the commit message in patch set 2 08/09/21, 16:53

  3. Wouter Wolters commented on patch set 2 08/09/21, 17:02

    Build/types/TYPO3/index.d.ts contains a hit on loadEditId which I thin can be removed too.
  4. Benni Mack commented on patch set 2 08/09/21, 17:11

    Reply

    will take care.
  5. Benni Mack uploaded patch set 3 08/09/21, 17:21

  6. core-ci voted on patch set 2 V +1 08/09/21, 17:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14381

  7. Wouter Wolters voted on patch set 3 CR +1 08/09/21, 17:24

  8. core-ci voted on patch set 3 V +1 08/09/21, 17:47 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14387

  9. Andreas Kienast voted on patch set 3 V +1 CR +1 08/09/21, 18:44

  10. Oli Bartsch voted on patch set 3 V +1 CR +1 08/09/21, 19:01

  11. Benni Mack voted on patch set 3 V +2 CR +2 08/09/21, 19:51

  12. Benni Mack merged patch set 4 08/09/21, 19:51