Review main Merged

70315[FEATURE] Add TCA option showNewRecordLink

Oli Bartsch CR +2 V +2 Normal +233 −10 updated 08/12/21, 16:24

Commit message

This introduces a new TCA option "showNewRecordLink"
for TCA type "inline". It can be used to disable the
"New record" link of inline elements, without any
side effects for other links/buttons.

As a consequence, the "levelLinksPosition" option
does not longer support the value "none", as this
behaviour (disabling all level links) should be achieved
by setting the link specific options to FALSE. This means,
the  "levelLinksPosition" options should only be used to
position the links, if shown at all. A TCA migration
is in place.

As another side effect, the previously - undocumented -
misuse of ['enabledControls']['new'] is resolved. The
mentioned option does now only affect the "+" button
in each records' header.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 4

Files 6

Review log 1218

  1. Oli Bartsch uploaded patch set 1 08/09/21, 17:35

  2. core-ci voted on patch set 1 V +1 08/09/21, 18:02 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14390

  3. Stephan Großberndt updated the commit message in patch set 2 08/09/21, 18:32

  4. core-ci voted on patch set 2 V +1 08/09/21, 18:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14398

  5. Oli Bartsch uploaded patch set 3 08/09/21, 18:53

  6. core-ci voted on patch set 3 V +1 08/09/21, 19:06 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14402

  7. Oli Bartsch uploaded patch set 4 08/09/21, 20:39

  8. core-ci voted on patch set 4 V +1 08/09/21, 20:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14409

  9. Christian Kuhn updated the commit message in patch set 5 08/09/21, 23:05

  10. Christian Kuhn commented on patch set 5 08/09/21, 23:07

    InlineControlContainer.php:288

    stupid me needs a comment here: "default for showNewRecordLink is 'true'", so we render the button if showNewRecordLink is not set or evaluates to true.
  11. core-ci voted on patch set 5 V +1 08/09/21, 23:15 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14415

  12. Oli Bartsch uploaded patch set 6 08/10/21, 07:53

  13. Oli Bartsch commented on patch set 6 08/10/21, 07:54

    InlineControlContainer.php:288 Reply

    Done
  14. core-ci voted on patch set 6 V +1 08/10/21, 08:15 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14444

  15. Jochen Roth voted on patch set 6 V +1 CR +1 08/11/21, 09:25

  16. Christian Kuhn voted on patch set 6 V +2 CR +2 08/12/21, 16:22

  17. Oli Bartsch voted on patch set 6 V +2 CR +2 08/12/21, 16:24

  18. Oli Bartsch merged patch set 7 08/12/21, 16:24