Review 11.3 Merged

70316[TASK] Restore newRecord level button behaviour

Oli Bartsch CR +2 V +2 Easy +7 −28 updated 08/09/21, 20:34

Commit message

Since #82489 the "enabledControls['new']" option
did not longer hide the "New record" button of inline
containers as this was considered a misuse and led
to some misbehaviour. This option should only affect
the action buttons of each inline record.

However since this can be considered a breaking change,
especially because there is currently no option available
to only hide the "New record" button, the whole change
is reverted now and will only be fixed in a separate patch
for v11. This will be done by introducing a dedicated option
for the "new record" button and by deprecating the "none"
value of the "levelLinksPosition" option.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jo Hasenau +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jo Hasenau +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 45

  1. Oli Bartsch uploaded patch set 1 08/09/21, 18:15

  2. core-ci voted on patch set 1 V +1 08/09/21, 18:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14397

  3. Jo Hasenau commented on patch set 1 V +1 CR +1 08/09/21, 19:36

    Thanks for taking care so fast and for the constructive discussion :-)
  4. Oli Bartsch commented on patch set 1 V +2 CR +2 08/09/21, 20:34

    Reply

    You're welcome, and thanks for testing.
  5. Oli Bartsch merged patch set 2 08/09/21, 20:34