Review main Merged

70318[TASK] Avoid GeneralUtility::linkThisScript in Clipboard

Oli Bartsch CR +2 V +2 Normal +45 −23 updated 08/10/21, 13:58

Commit message

Replace GeneralUtility::linkThisScript with proper
usage of UriBuilder in combination with the PSR-7
Request.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 68

  1. Oli Bartsch uploaded patch set 1 08/09/21, 20:00

  2. core-ci voted on patch set 1 V -1 08/09/21, 20:14 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14404

  3. Oli Bartsch uploaded patch set 2 08/09/21, 20:31

  4. core-ci voted on patch set 2 V +1 08/09/21, 20:54 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14407

  5. Jochen Roth voted on patch set 2 V +1 CR +1 08/10/21, 07:25

  6. Wouter Wolters voted on patch set 2 CR +1 08/10/21, 09:01

  7. Benni Mack voted on patch set 2 V +2 CR +2 08/10/21, 13:58

  8. Benni Mack merged patch set 3 08/10/21, 13:58