70332[TASK] Cleanup EXT:impexp
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 123
- Build/Sources/Sass/typo3/_element_tree.scss2+2 −2
- Build/Sources/TypeScript/impexp/Resources/Public/TypeScript/ContextMenuActions.ts+2 −1
- typo3/sysext/adminpanel/Resources/Public/Css/adminpanel.css+1 −1
- typo3/sysext/backend/Classes/ContextMenu/ItemProviders/PageProvider.php+1 −1
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/core/Tests/Acceptance/Backend/Impexp/Fixtures/404_page_and_records.xmlnew+469 −0
- typo3/sysext/core/Tests/Acceptance/Backend/Impexp/Fixtures/sys_category_record.xmlnew+61 −0
- typo3/sysext/core/Tests/Acceptance/Backend/Impexp/Fixtures/sys_category_table.xmlnew+240 −0
- typo3/sysext/core/Tests/Acceptance/Backend/Impexp/Fixtures/sys_category_table_with_bootstrap_package.xmlnew+242 −0
- typo3/sysext/core/Tests/Acceptance/Backend/Impexp/Fixtures/unsupported.jsonnew+3 −0
- typo3/sysext/core/Tests/Acceptance/Backend/Impexp/AbstractCest.phpnew+97 −0
- typo3/sysext/core/Tests/Acceptance/Backend/Impexp/ExportCest.phpnew+308 −0
- typo3/sysext/core/Tests/Acceptance/Backend/Impexp/ImportCest.phpnew+406 −0
- typo3/sysext/core/Tests/Acceptance/Backend/Impexp/UsersCest.phpnew+217 −0
- typo3/sysext/core/Tests/Acceptance/Support/Extension/BackendCoreEnvironment.php+1 −0
- typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php+2 −2
- typo3/sysext/impexp/Classes/Command/Exception/InvalidFileException.phpdeleted+0 −23
- typo3/sysext/impexp/Classes/Command/ImportCommand.php2+86 −46
- typo3/sysext/impexp/Classes/ContextMenu/ItemProvider.php1+3 −2
- typo3/sysext/impexp/Classes/Controller/ExportController.php+209 −382
Show 103 more files
- typo3/sysext/impexp/Classes/Controller/ImportController.php5+179 −189
- typo3/sysext/impexp/Classes/Controller/ImportExportController.php+65 −97
- typo3/sysext/impexp/Classes/Domain/Repository/PresetRepository.php+144 −141
- typo3/sysext/impexp/Classes/Exception/ImportFailedException.php1renamed+8 −2
- typo3/sysext/impexp/Classes/Exception/InsufficientUserPermissionsException.phpnew+29 −0
- typo3/sysext/impexp/Classes/Exception/LoadingFileFailedException.phprenamed+8 −2
- typo3/sysext/impexp/Classes/Exception/MalformedPresetException.phpcopied+9 −3
- typo3/sysext/impexp/Classes/Exception/PrerequisitesNotMetException.phprenamed+8 −2
- typo3/sysext/impexp/Classes/Exception/PresetNotFoundException.phpcopied+9 −3
- typo3/sysext/impexp/Classes/Hook/BackendControllerHook.php+8 −13
- typo3/sysext/impexp/Classes/Utility/ImportExportUtility.php2+26 −37
- typo3/sysext/impexp/Classes/View/ExportPageTreeView.php+120 −44
- typo3/sysext/impexp/Classes/Exception.phpcopied+8 −3
- typo3/sysext/impexp/Classes/Export.php+1287 −712
- typo3/sysext/impexp/Classes/Import.php+1120 −1070
- typo3/sysext/impexp/Classes/ImportExport.php+1251 −707
- typo3/sysext/impexp/Resources/Private/Language/locallang.xlf3+3 −15
- typo3/sysext/impexp/Resources/Private/Language/locallang_csh.xlf+2 −3
- typo3/sysext/impexp/Resources/Private/Layouts/Default.html+5 −0
- typo3/sysext/impexp/Resources/Private/Partials/Export/AdvancedOptions.html+32 −13
- typo3/sysext/impexp/Resources/Private/Partials/Export/Configuration.html+79 −40
- typo3/sysext/impexp/Resources/Private/Partials/Export/Save.html+65 −34
- typo3/sysext/impexp/Resources/Private/Partials/Import/Import.html+70 −36
- typo3/sysext/impexp/Resources/Private/Partials/Import/MetaData.html+43 −21
- typo3/sysext/impexp/Resources/Private/Partials/Import/Upload.html+26 −13
- typo3/sysext/impexp/Resources/Private/Partials/ContentOverview.htmldeleted+0 −96
- typo3/sysext/impexp/Resources/Private/Partials/Preview.htmlnew+157 −0
- typo3/sysext/impexp/Resources/Private/Templates/ImportExport/Export.html+19 −7
- typo3/sysext/impexp/Resources/Private/Templates/ImportExport/Import.html+23 −12
- typo3/sysext/impexp/Resources/Public/JavaScript/ContextMenuActions.js+1 −1
- typo3/sysext/impexp/Tests/Functional/Command/ImportCommandTest.phpnew+151 −0
- typo3/sysext/impexp/Tests/Functional/Export/ExportControllerTest.php+1 −4
- typo3/sysext/impexp/Tests/Functional/Export/ExportPageTreeViewTest.phpnew+92 −0
- typo3/sysext/impexp/Tests/Functional/Export/IrreTutorialRecordsTest.php+15 −261
- typo3/sysext/impexp/Tests/Functional/Export/PagesAndTtContentTest.php+72 −66
- typo3/sysext/impexp/Tests/Functional/Export/PagesAndTtContentWithImagesTest.php+69 −58
- typo3/sysext/impexp/Tests/Functional/Export/PagesAndTtContentWithRelationsAndSoftrefsTest.phpnew+240 −0
- typo3/sysext/impexp/Tests/Functional/Export/PresetsTest.phpnew+115 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewExportPageAndRecords.phpnew+426 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewExportPageAndRecordsWithSoftRefs.phpnew+279 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewExportRecords.phpnew+130 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewExportTable.phpnew+189 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecords.phpnew+216 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecordsByUpdate.phpnew+164 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecordsByUpdateWithDiff.phpnew+496 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecordsWithDiff.phpnew+446 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecordsWithSoftRefs.phpnew+140 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/DatabaseAssertions/importImagesWithStorages.csvnew+10 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/DatabaseAssertions/importPagesAndRelatedTtContentWithDifferentImageToExistingData.csv+5 −4
- typo3/sysext/impexp/Tests/Functional/Fixtures/DatabaseAssertions/importPagesAndRelatedTtContentWithEditedFlexFormSoftReference.csvnew+18 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/DatabaseAssertions/importPagesAndRelatedTtContentWithExcludedFlexFormSoftReference.csvnew+18 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/DatabaseAssertions/importPagesAndRelatedTtContentWithFlexFormSoftReference.csvnew+18 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/DatabaseAssertions/importPagesAndRelatedTtContentWithSameImageToExistingData.csv+5 −4
- typo3/sysext/impexp/Tests/Functional/Fixtures/DatabaseAssertions/updatePagesAndRelatedTtContentKeepsRelationsBetweenImportedPagesAndRecords.csvnew+30 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/DatabaseAssertions/updatePagesAndRelatedTtContentWithDifferentImageToExistingData.csvnew+28 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/DatabaseAssertions/updatePagesAndRelatedTtContentWithDifferentImageToExistingDataAndPagesAsNew.csvnew+30 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/DatabaseImports/form_sys_file.xmlnew+19 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/DatabaseImports/irre_tutorial.xml+35 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/DatabaseImports/pages.xml+10 −1
- typo3/sysext/impexp/Tests/Functional/Fixtures/DatabaseImports/sys_file_invalid_hash.xmlnew+19 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/DatabaseImports/sys_file_storages.xmlnew+60 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/DatabaseImports/tt_content-with-flexform-relation.xmlnew+26 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/DatabaseImports/tt_content-with-flexform-softrefs.xmlnew+26 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/DatabaseImports/tt_content-with-softrefs.xmlnew+26 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/DatabaseImports/tt_content.xml+15 −1
- typo3/sysext/impexp/Tests/Functional/Fixtures/Folders/fileadmin/form_definitions/flexFormWithSoftReference.form.yamlnew+22 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/T3dExports/empty-with-wrong-checksum.t3dnew+1 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/T3dExports/empty-z.t3dnewbinary
- typo3/sysext/impexp/Tests/Functional/Fixtures/T3dExports/empty.t3dnew+1 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/empty.xmlnew+13 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/irre-records.xml+439 −432
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-complex.xmlnew+365 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-corrupt-image.xml+114 −106
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-flexform-relation.xmlnew+159 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-flexform-softrefs.xmlnew+260 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-image-but-not-included.xml+100 −92
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-image.xml+100 −92
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-softrefs.xmlnew+408 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent.xml+308 −41
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/images-with-static-and-fallback-storages.xmlnew+601 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/images-with-storages.xmlnew+658 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/irre-records.xml+442 −435
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/pages-and-ttcontent-with-flexform-relation.xmlnew+152 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/pages-and-ttcontent-with-image-with-invalid-storage.xmlnew+593 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/pages-and-ttcontent-with-missing-image.xmlnew+327 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/pages-and-ttcontent-with-softrefs.xmlnew+168 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/sys_category_table_with_news.xmlnew+242 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/sys_language.xmlnew+49 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/unsupported.jsonnew+3 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/IrreRecordsIncludeFields.phpnew+235 −0
- typo3/sysext/impexp/Tests/Functional/Import/ImagesWithStoragesTest.phpnew+70 −0
- typo3/sysext/impexp/Tests/Functional/Import/IrreTutorialRecordsTest.php+5 −8
- typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContentTest.php+5 −8
- typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContentWithImagesInEmptyDatabaseTest.php+96 −42
- typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContentWithImagesInFilledDatabaseTest.php+315 −29
- typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContentWithRteImagesAndFileLinkTest.php+5 −8
- typo3/sysext/impexp/Tests/Functional/Utility/ImportExportUtilityTest.phpnew+79 −0
- typo3/sysext/impexp/Tests/Functional/AbstractImportExportTestCase.php+29 −109
- typo3/sysext/impexp/Tests/Functional/ExportTest.phpnew+421 −0
- typo3/sysext/impexp/Tests/Functional/ImportExportTest.phpnew+72 −0
- typo3/sysext/impexp/Tests/Functional/ImportTest.phpnew+313 −0
- typo3/sysext/impexp/Tests/Unit/ExportTest.php2new+373 −0
- typo3/sysext/impexp/ext_emconf.php+1 −1
Review log 6194
Show 4369 earlier messages
-
Alexander Nitsche uploaded patch set 1 08/09/21, 22:48
-
core-ci voted on patch set 1 V -1 08/09/21, 22:51 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14414
-
Alexander Nitsche commented on patch set 1 08/09/21, 22:51
This is a squashed commit. The separate commits can be looked up at https://github.com/alexander-nitsche/TYPO3.CMS/commits/impexp-improved-rebased-2. -
Sybille Peters commented on patch set 1 08/10/21, 06:27
This is a huge change (with lots of merge conflicts). Have you talked with someone in core team? Otherwise I would be concerned with it not getting merged (because of bulk changes and difficult to review) and would break it down into individual changes, each addressing one point of concern (e.g. test cleanup, refactoring, CLI). -
Benni Mack commented on patch set 1 08/10/21, 06:57
Reply
Yes. This is mentored by me, and also part of TYPO3 Association's "Innovation Budget Pool" which was initiated by T3A in late last year. -
Benni Mack uploaded patch set 2 08/10/21, 11:14
-
core-ci voted on patch set 2 V -1 08/10/21, 11:24 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14474
-
Benni Mack uploaded patch set 3 08/10/21, 11:49
-
core-ci voted on patch set 3 V -1 08/10/21, 11:52 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14477
-
Benni Mack uploaded patch set 4 08/10/21, 11:54
-
core-ci voted on patch set 4 V -1 08/10/21, 12:11 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14478
-
Oliver Klee commented on patch set 4 08/10/21, 12:22
ExportTest.php:3Please let's make the new PHP files strict to begin with. -
Wouter Wolters commented on patch set 4 08/10/21, 13:22
ImportController.php:45public const?ImportExportUtility.php:65Maybe catch a more appropriate exception here than this one. This is too generic IMO -
Oliver Klee wrote 08/10/21, 13:32
Removed reviewer Oliver Klee. -
Sybille Peters wrote 08/10/21, 14:50
Removed reviewer Sybille Peters. -
Alexander Nitsche uploaded patch set 5 08/10/21, 23:16
-
core-ci voted on patch set 5 V -1 08/10/21, 23:18 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14526
-
Alexander Nitsche uploaded patch set 6 08/10/21, 23:27
-
core-ci voted on patch set 6 V -1 08/10/21, 23:44 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14527
-
Christian Kuhn commented on patch set 6 CR -1 08/11/21, 08:06
working on it. -
Alexander Nitsche uploaded patch set 7 08/11/21, 08:49
-
core-ci voted on patch set 7 V -1 08/11/21, 09:03 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14557
-
Christian Kuhn uploaded patch set 8 08/11/21, 09:46
-
Christian Kuhn commented on patch set 8 08/11/21, 09:49
* fixed duplicate exception code * moved ac tests to ext:core (still red, though) -
Christian Kuhn uploaded patch set 9 08/11/21, 10:13
-
Christian Kuhn commented on patch set 9 08/11/21, 10:14
lintHtml happy -
core-ci voted on patch set 8 V -1 08/11/21, 10:15 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14566
-
Christian Kuhn uploaded patch set 10 08/11/21, 10:25
-
Christian Kuhn commented on patch set 10 08/11/21, 10:26
phpstan happy -
core-ci voted on patch set 9 V -1 08/11/21, 10:32 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14570
-
Christian Kuhn commented on patch set 10 08/11/21, 10:44
_element_tree.scss:209sure here? possible side-effects on other modules?ItemProvider.php:121not needed for methods that declare a return typeImportFailedException.php:23those should extend a generic impexp exception. -
Christian Kuhn uploaded patch set 11 08/11/21, 10:45
-
Christian Kuhn commented on patch set 10 08/11/21, 10:45
exception inheritance. -
core-ci voted on patch set 10 V -1 08/11/21, 10:51 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14573
-
core-ci voted on patch set 11 V -1 08/11/21, 11:03 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14574
-
Christian Kuhn uploaded patch set 12 08/11/21, 11:47
-
Christian Kuhn commented on patch set 11 08/11/21, 11:47
_element_tree.scss:209Replyis ok.ImportController.php:43add visibility. -
core-ci voted on patch set 12 V -1 08/11/21, 12:14 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14579
-
Christian Kuhn uploaded patch set 13 08/11/21, 13:54
-
core-ci voted on patch set 13 V -1 08/11/21, 14:22 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14598
-
Christian Kuhn uploaded patch set 14 08/11/21, 15:54
-
Christian Kuhn uploaded patch set 15 08/11/21, 15:57
-
core-ci voted on patch set 14 V -1 08/11/21, 15:57 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14614
-
Christian Kuhn uploaded patch set 16 08/11/21, 15:59
-
core-ci voted on patch set 15 V -1 08/11/21, 16:00 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14615
-
core-ci voted on patch set 16 V -1 08/11/21, 16:29 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14616
-
Christian Kuhn uploaded patch set 17 08/11/21, 16:41
-
core-ci voted on patch set 17 V -1 08/11/21, 16:58 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14619
-
Christian Kuhn uploaded patch set 18 08/11/21, 17:30
-
core-ci voted on patch set 18 V -1 08/11/21, 17:50 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14621
-
Christian Kuhn commented on patch set 18 08/11/21, 17:54
ImportCommand.php:129unsure about the try/catch here: shouldn't we exceptions maybe fully bubble up, or at least only catch core\exception and impexp\exception?ImportController.php:138drop reference, return $inData. -
Alexander Nitsche uploaded patch set 19 08/11/21, 18:28
-
Christian Kuhn commented on patch set 19 08/11/21, 18:32
ImportCommand.php:129Replywill be kept for now. -
Christian Kuhn uploaded patch set 20 08/11/21, 18:33
-
core-ci voted on patch set 19 V -1 08/11/21, 18:42 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14622
-
core-ci voted on patch set 20 V -1 08/11/21, 18:50 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14624
-
Christian Kuhn uploaded patch set 21 08/11/21, 19:17
-
core-ci voted on patch set 21 V -1 08/11/21, 19:34 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14627
-
Christian Kuhn uploaded patch set 22 08/11/21, 19:47
-
core-ci voted on patch set 22 V -1 08/11/21, 20:03 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14631
-
Christian Kuhn uploaded patch set 23 08/11/21, 20:15
-
Christian Kuhn uploaded patch set 24 08/11/21, 20:23
-
core-ci voted on patch set 23 V +1 08/11/21, 20:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14633
-
core-ci voted on patch set 24 V +1 08/11/21, 20:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14636
-
Christian Kuhn uploaded patch set 25 08/11/21, 21:15
-
core-ci voted on patch set 25 V +1 08/11/21, 21:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14643
-
Christian Kuhn uploaded patch set 26 08/11/21, 21:35
-
Christian Kuhn uploaded patch set 27 08/11/21, 21:42
-
core-ci voted on patch set 26 V -1 08/11/21, 21:52 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14644
-
core-ci voted on patch set 27 V -1 08/11/21, 22:08 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14645
-
core-ci commented on patch set 27 08/11/21, 22:19 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14645
-
Christian Kuhn commented on patch set 27 08/11/21, 22:26
think we fixed all comments. -
core-ci commented on patch set 27 08/11/21, 22:28 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14645
-
Christian Kuhn commented on patch set 27 08/11/21, 22:54
unable to greenify with fsMod patch applied. -
Christian Kuhn commented on patch set 27 08/11/21, 22:55
. -
Christian Kuhn commented on patch set 27 08/11/21, 22:56
ImportController.php:43ReplyDoneImportController.php:45ReplyDoneImportExportUtility.php:65ReplyDoneExportTest.php:3ReplyDone -
core-ci commented on patch set 27 08/11/21, 23:22 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14645
-
Christian Kuhn commented on patch set 27 08/11/21, 23:35
patch is ready, latest pushes running into side-effects of https://review.typo3.org/c/Packages/TYPO3.CMS/+/67680, though (SearchCest.php & BookmarkCest ac test fails). -
Christian Kuhn voted on patch set 27 V +1 CR +1 08/12/21, 08:04
-
Christian Kuhn voted on patch set 27 V 0 CR 0 08/12/21, 08:06
-
Christian Kuhn uploaded patch set 28 08/12/21, 08:13
-
core-ci voted on patch set 28 V +1 08/12/21, 08:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14656
-
Christian Kuhn voted on patch set 28 V +1 CR +1 08/12/21, 08:31
-
Georg Ringer commented on patch set 28 CR -1 08/12/21, 08:53
locallang.xlf:186can we please stick to the same id because otherwise we loose all translations and the real benefit is minimal when looking at all other keys in this file -
Christian Kuhn commented on patch set 28 08/12/21, 08:57
locallang.xlf:186Replythe issue is that parts of that key are generated on-the-fly. streamlining the naming makes the code significantly easier. would like to keep that renaming in this case. -
Georg Ringer commented on patch set 28 08/12/21, 09:01
locallang.xlf:186Replyok -
Georg Ringer voted on patch set 28 CR 0 08/12/21, 09:01
-
Alexander Nitsche updated the commit message in patch set 29 08/12/21, 09:21
-
core-ci voted on patch set 29 V -1 08/12/21, 10:00 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14663
-
core-ci voted on patch set 29 V +1 08/12/21, 10:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14663
-
Christian Kuhn voted on patch set 29 V +1 CR +1 08/12/21, 10:39
-
Benni Mack voted on patch set 29 V +2 CR +2 08/12/21, 10:43
-
Benni Mack commented on patch set 29 08/12/21, 10:43
Great patch! Thanks for the work -
Benni Mack merged patch set 30 08/12/21, 10:43