Review main Merged

70332[TASK] Cleanup EXT:impexp

Alexander Nitsche CR +2 V +2 Impossible +18338 −5579 updated 08/12/21, 10:43

Commit message

This patch serves as a basis for further improving
the UX and new features for import / export.

* Better separation between controllers and worker services
* Refactor code & streamline wording
* More strict typing and some PHP 8 related fixes
* Streamline exception handling
* Support full import configuration in CLI command impexp:import
* Functional tests with increased coverage and less mocking
* A set of acceptance tests for the backend interface
* Minor bug fixes

Note: The output of the extension has not been changed
in any way, e.g. the format of the export file remains
the same. Only the internal processes have been optimized.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 123

Show 103 more files

Review log 6194

Show 4369 earlier messages
  1. Alexander Nitsche uploaded patch set 1 08/09/21, 22:48

  2. core-ci voted on patch set 1 V -1 08/09/21, 22:51 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14414

  3. Alexander Nitsche commented on patch set 1 08/09/21, 22:51

    This is a squashed commit. The separate commits can be looked up at https://github.com/alexander-nitsche/TYPO3.CMS/commits/impexp-improved-rebased-2.
  4. Sybille Peters commented on patch set 1 08/10/21, 06:27

    This is a huge change (with lots of merge conflicts). Have you talked with someone in core team? Otherwise I would be concerned with it not getting merged (because of bulk changes and difficult to review) and would break it down into individual changes, each addressing one point of concern (e.g. test cleanup, refactoring, CLI).
  5. Benni Mack commented on patch set 1 08/10/21, 06:57

    Reply

    Yes. This is mentored by me, and also part of TYPO3 Association's "Innovation Budget Pool" which was initiated by T3A in late last year.
  6. Benni Mack uploaded patch set 2 08/10/21, 11:14

  7. core-ci voted on patch set 2 V -1 08/10/21, 11:24 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14474

  8. Benni Mack uploaded patch set 3 08/10/21, 11:49

  9. core-ci voted on patch set 3 V -1 08/10/21, 11:52 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14477

  10. Benni Mack uploaded patch set 4 08/10/21, 11:54

  11. core-ci voted on patch set 4 V -1 08/10/21, 12:11 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14478

  12. Oliver Klee commented on patch set 4 08/10/21, 12:22

    ExportTest.php:3

    Please let's make the new PHP files strict to begin with.
  13. Wouter Wolters commented on patch set 4 08/10/21, 13:22

    ImportController.php:45

    public const?

    ImportExportUtility.php:65

    Maybe catch a more appropriate exception here than this one. This is too generic IMO
  14. Oliver Klee wrote 08/10/21, 13:32

    Removed reviewer Oliver Klee.
  15. Sybille Peters wrote 08/10/21, 14:50

    Removed reviewer Sybille Peters.
  16. Alexander Nitsche uploaded patch set 5 08/10/21, 23:16

  17. core-ci voted on patch set 5 V -1 08/10/21, 23:18 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14526

  18. Alexander Nitsche uploaded patch set 6 08/10/21, 23:27

  19. core-ci voted on patch set 6 V -1 08/10/21, 23:44 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14527

  20. Christian Kuhn commented on patch set 6 CR -1 08/11/21, 08:06

    working on it.
  21. Alexander Nitsche uploaded patch set 7 08/11/21, 08:49

  22. core-ci voted on patch set 7 V -1 08/11/21, 09:03 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14557

  23. Christian Kuhn uploaded patch set 8 08/11/21, 09:46

  24. Christian Kuhn commented on patch set 8 08/11/21, 09:49

    * fixed duplicate exception code * moved ac tests to ext:core (still red, though)
  25. Christian Kuhn uploaded patch set 9 08/11/21, 10:13

  26. Christian Kuhn commented on patch set 9 08/11/21, 10:14

    lintHtml happy
  27. core-ci voted on patch set 8 V -1 08/11/21, 10:15 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14566

  28. Christian Kuhn uploaded patch set 10 08/11/21, 10:25

  29. Christian Kuhn commented on patch set 10 08/11/21, 10:26

    phpstan happy
  30. core-ci voted on patch set 9 V -1 08/11/21, 10:32 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14570

  31. Christian Kuhn commented on patch set 10 08/11/21, 10:44

    _element_tree.scss:209

    sure here? possible side-effects on other modules?

    ItemProvider.php:121

    not needed for methods that declare a return type

    ImportFailedException.php:23

    those should extend a generic impexp exception.
  32. Christian Kuhn uploaded patch set 11 08/11/21, 10:45

  33. Christian Kuhn commented on patch set 10 08/11/21, 10:45

    exception inheritance.
  34. core-ci voted on patch set 10 V -1 08/11/21, 10:51 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14573

  35. core-ci voted on patch set 11 V -1 08/11/21, 11:03 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14574

  36. Christian Kuhn uploaded patch set 12 08/11/21, 11:47

  37. Christian Kuhn commented on patch set 11 08/11/21, 11:47

    _element_tree.scss:209 Reply

    is ok.

    ImportController.php:43

    add visibility.
  38. core-ci voted on patch set 12 V -1 08/11/21, 12:14 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14579

  39. Christian Kuhn uploaded patch set 13 08/11/21, 13:54

  40. core-ci voted on patch set 13 V -1 08/11/21, 14:22 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14598

  41. Christian Kuhn uploaded patch set 14 08/11/21, 15:54

  42. Christian Kuhn uploaded patch set 15 08/11/21, 15:57

  43. core-ci voted on patch set 14 V -1 08/11/21, 15:57 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14614

  44. Christian Kuhn uploaded patch set 16 08/11/21, 15:59

  45. core-ci voted on patch set 15 V -1 08/11/21, 16:00 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14615

  46. core-ci voted on patch set 16 V -1 08/11/21, 16:29 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14616

  47. Christian Kuhn uploaded patch set 17 08/11/21, 16:41

  48. core-ci voted on patch set 17 V -1 08/11/21, 16:58 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14619

  49. Christian Kuhn uploaded patch set 18 08/11/21, 17:30

  50. core-ci voted on patch set 18 V -1 08/11/21, 17:50 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14621

  51. Christian Kuhn commented on patch set 18 08/11/21, 17:54

    ImportCommand.php:129

    unsure about the try/catch here: shouldn't we exceptions maybe fully bubble up, or at least only catch core\exception and impexp\exception?

    ImportController.php:138

    drop reference, return $inData.
  52. Alexander Nitsche uploaded patch set 19 08/11/21, 18:28

  53. Christian Kuhn commented on patch set 19 08/11/21, 18:32

    ImportCommand.php:129 Reply

    will be kept for now.
  54. Christian Kuhn uploaded patch set 20 08/11/21, 18:33

  55. core-ci voted on patch set 19 V -1 08/11/21, 18:42 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14622

  56. core-ci voted on patch set 20 V -1 08/11/21, 18:50 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14624

  57. Christian Kuhn uploaded patch set 21 08/11/21, 19:17

  58. core-ci voted on patch set 21 V -1 08/11/21, 19:34 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14627

  59. Christian Kuhn uploaded patch set 22 08/11/21, 19:47

  60. core-ci voted on patch set 22 V -1 08/11/21, 20:03 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14631

  61. Christian Kuhn uploaded patch set 23 08/11/21, 20:15

  62. Christian Kuhn uploaded patch set 24 08/11/21, 20:23

  63. core-ci voted on patch set 23 V +1 08/11/21, 20:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14633

  64. core-ci voted on patch set 24 V +1 08/11/21, 20:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14636

  65. Christian Kuhn uploaded patch set 25 08/11/21, 21:15

  66. core-ci voted on patch set 25 V +1 08/11/21, 21:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14643

  67. Christian Kuhn uploaded patch set 26 08/11/21, 21:35

  68. Christian Kuhn uploaded patch set 27 08/11/21, 21:42

  69. core-ci voted on patch set 26 V -1 08/11/21, 21:52 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14644

  1. core-ci voted on patch set 27 V -1 08/11/21, 22:08 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14645

  2. core-ci commented on patch set 27 08/11/21, 22:19 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14645

  3. Christian Kuhn commented on patch set 27 08/11/21, 22:26

    think we fixed all comments.
  4. core-ci commented on patch set 27 08/11/21, 22:28 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14645

  5. Christian Kuhn commented on patch set 27 08/11/21, 22:54

    unable to greenify with fsMod patch applied.
  6. Christian Kuhn commented on patch set 27 08/11/21, 22:55

    .
  7. Christian Kuhn commented on patch set 27 08/11/21, 22:56

    ImportController.php:43 Reply

    Done

    ImportController.php:45 Reply

    Done

    ImportExportUtility.php:65 Reply

    Done

    ExportTest.php:3 Reply

    Done
  8. core-ci commented on patch set 27 08/11/21, 23:22 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14645

  9. Christian Kuhn commented on patch set 27 08/11/21, 23:35

    patch is ready, latest pushes running into side-effects of https://review.typo3.org/c/Packages/TYPO3.CMS/+/67680, though (SearchCest.php & BookmarkCest ac test fails).
  10. Christian Kuhn voted on patch set 27 V +1 CR +1 08/12/21, 08:04

  11. Christian Kuhn voted on patch set 27 V 0 CR 0 08/12/21, 08:06

  12. Christian Kuhn uploaded patch set 28 08/12/21, 08:13

  13. core-ci voted on patch set 28 V +1 08/12/21, 08:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14656

  14. Christian Kuhn voted on patch set 28 V +1 CR +1 08/12/21, 08:31

  15. Georg Ringer commented on patch set 28 CR -1 08/12/21, 08:53

    locallang.xlf:186

    can we please stick to the same id because otherwise we loose all translations and the real benefit is minimal when looking at all other keys in this file
  16. Christian Kuhn commented on patch set 28 08/12/21, 08:57

    locallang.xlf:186 Reply

    the issue is that parts of that key are generated on-the-fly. streamlining the naming makes the code significantly easier. would like to keep that renaming in this case.
  17. Georg Ringer commented on patch set 28 08/12/21, 09:01

    locallang.xlf:186 Reply

    ok
  18. Georg Ringer voted on patch set 28 CR 0 08/12/21, 09:01

  19. Alexander Nitsche updated the commit message in patch set 29 08/12/21, 09:21

  20. core-ci voted on patch set 29 V -1 08/12/21, 10:00 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14663

  21. core-ci voted on patch set 29 V +1 08/12/21, 10:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14663

  22. Christian Kuhn voted on patch set 29 V +1 CR +1 08/12/21, 10:39

  23. Benni Mack voted on patch set 29 V +2 CR +2 08/12/21, 10:43

  24. Benni Mack commented on patch set 29 08/12/21, 10:43

    Great patch! Thanks for the work
  25. Benni Mack merged patch set 30 08/12/21, 10:43