Review main Merged

70340[TASK] Rename runTests.sh suites and optimize php linting

Andreas Kienast CR +2 V +2 Normal +84 −104 updated 08/13/21, 19:54

Commit message

To be more consistent:
* Rename "-s install" to "-s acceptanceInstall"
* Rename "-s cglAll" to "-s cgl"
* Rename "-s lint" to "-s lintPhp"

Apart from that, the cgl checker also lints the files
before checking cgl. The explicit pre-merge lint jobs
are thus obsolete in pre-merge.
We keep "lint everything" for nightlies to be sure.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Wouter Wolters +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1319

  1. Andreas Kienast uploaded patch set 1 08/10/21, 06:09

  2. Andreas Kienast updated the commit message in patch set 2 08/10/21, 06:14

  3. core-ci voted on patch set 1 V +1 08/10/21, 06:20 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14428

  4. core-ci voted on patch set 2 V +1 08/10/21, 06:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14429

  5. Stephan Großberndt voted on patch set 2 CR +1 08/10/21, 07:42

  6. Wouter Wolters voted on patch set 2 CR +1 08/10/21, 09:03

  7. Christian Kuhn commented on patch set 2 CR -1 08/12/21, 17:44

    have minor ideas here. will update ... tomorrow?!
  8. Christian Kuhn uploaded patch set 3 08/13/21, 17:47

  9. core-ci voted on patch set 3 V +1 08/13/21, 18:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15010

  10. Christian Kuhn uploaded patch set 4 08/13/21, 18:22

  11. core-ci voted on patch set 4 V -1 08/13/21, 18:25 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15016

  12. Christian Kuhn uploaded patch set 5 08/13/21, 18:50

  13. core-ci voted on patch set 5 V +1 08/13/21, 19:02 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15017

  14. Christian Kuhn voted on patch set 5 V +1 CR +1 08/13/21, 19:21

  15. Wouter Wolters voted on patch set 5 V +1 CR +1 08/13/21, 19:22

  16. Andreas Kienast voted on patch set 5 V +1 CR +1 08/13/21, 19:32

  17. core-ci commented on patch set 5 08/13/21, 19:46 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15018

  18. Andreas Kienast voted on patch set 5 V +2 CR +2 08/13/21, 19:54

  19. Andreas Kienast merged patch set 6 08/13/21, 19:54