Review main Merged

70341[TASK] Avoid inline JavaScript in Constant Editor

Benni Mack CR +2 V +2 Normal +36 −29 updated 08/10/21, 12:51

Commit message

This change replaces an inline JavaScript
code to update the form URL of the constant
editor to jump to the last changed field when
saving the Constant Editor module.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Wouter Wolters +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1012

  1. Benni Mack uploaded patch set 1 08/10/21, 07:42

  2. core-ci voted on patch set 1 V +1 08/10/21, 07:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14438

  3. Benni Mack uploaded patch set 2 08/10/21, 08:02

  4. core-ci voted on patch set 2 V +1 08/10/21, 08:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14450

  5. Wouter Wolters voted on patch set 2 CR +1 08/10/21, 08:56

  6. Oli Bartsch commented on patch set 2 08/10/21, 09:35

    Main.html:1

    Is there a specific reason why we don't build this url in the controller?
  7. Benni Mack commented on patch set 2 08/10/21, 09:44

    Main.html:1 Reply

    mainly because we don't need it there, I'd say :)
  8. Oli Bartsch commented on patch set 2 V +1 CR +1 08/10/21, 10:49

    Main.html:1 Reply

    Ok, just thought about reducing ViewHelper usage.
  9. Oliver Hader voted on patch set 2 CR +1 08/10/21, 10:50

  10. Christian Kuhn voted on patch set 2 V +1 08/10/21, 12:50

  11. Benni Mack voted on patch set 2 V +2 CR +2 08/10/21, 12:51

  12. Benni Mack merged patch set 3 08/10/21, 12:51