70341[TASK] Avoid inline JavaScript in Constant Editor
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Wouter Wolters +1
- Oliver Hader +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/TypeScript/tstemplate/Resources/Public/TypeScript/ConstantEditor.ts+17 −0
- typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php+15 −16
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php+2 −11
- typo3/sysext/tstemplate/Resources/Private/Templates/Main.html3+1 −1
- typo3/sysext/tstemplate/Resources/Public/JavaScript/ConstantEditor.js+1 −1
Review log 1012
-
Benni Mack uploaded patch set 1 08/10/21, 07:42
-
core-ci voted on patch set 1 V +1 08/10/21, 07:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14438
-
Benni Mack uploaded patch set 2 08/10/21, 08:02
-
core-ci voted on patch set 2 V +1 08/10/21, 08:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14450
-
Wouter Wolters voted on patch set 2 CR +1 08/10/21, 08:56
-
Oli Bartsch commented on patch set 2 08/10/21, 09:35
-
Benni Mack commented on patch set 2 08/10/21, 09:44
Main.html:1Replymainly because we don't need it there, I'd say :) -
Oli Bartsch commented on patch set 2 V +1 CR +1 08/10/21, 10:49
Main.html:1ReplyOk, just thought about reducing ViewHelper usage. -
Oliver Hader voted on patch set 2 CR +1 08/10/21, 10:50
-
Christian Kuhn voted on patch set 2 V +1 08/10/21, 12:50
-
Benni Mack voted on patch set 2 V +2 CR +2 08/10/21, 12:51
-
Benni Mack merged patch set 3 08/10/21, 12:51
Main.html:1