70393[FEATURE] Add new CLI command "impexp:export"
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Wouter Wolters +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Documentation/Changelog/master/Feature-84718-AddCLIExportCommandToImpExpExtension.rst14new+62 −0
- typo3/sysext/impexp/Classes/Command/ExportCommand.php6new+212 −0
- typo3/sysext/impexp/Classes/Command/ImportCommand.php+1 −1
- typo3/sysext/impexp/Configuration/Services.yaml+6 −0
- typo3/sysext/impexp/Tests/Functional/Command/ExportCommandTest.phpnew+114 −0
Review log 3039
Show 914 earlier messages
-
Benni Mack uploaded patch set 1 08/10/21, 11:14
-
core-ci voted on patch set 1 V -1 08/10/21, 11:38 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14475
-
Benni Mack rebased onto patch set 2 08/12/21, 10:43
-
Christian Kuhn commented on patch set 2 CR -1 08/12/21, 11:12
There was a Test file in the previous patch that should be integrated here. I guess Alexander will take care. -
core-ci voted on patch set 2 V +1 08/12/21, 11:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14701
-
Alexander Nitsche uploaded patch set 3 08/12/21, 14:21
-
Benni Mack commented on patch set 3 08/12/21, 14:37
ExportCommand.php:217please use dependency injection here. -
core-ci voted on patch set 3 V +1 08/12/21, 14:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14758
-
Alexander Nitsche uploaded patch set 4 08/12/21, 19:23
-
core-ci voted on patch set 4 V -1 08/12/21, 19:27 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14838
-
Alexander Nitsche commented on patch set 4 08/12/21, 19:28
Added the reST file.ExportCommand.php:217ReplyOk. -
Alexander Nitsche uploaded patch set 5 08/12/21, 19:30
-
core-ci voted on patch set 5 V +1 08/12/21, 19:50 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14841
-
Alexander Nitsche uploaded patch set 6 08/12/21, 19:51
-
core-ci commented on patch set 6 08/12/21, 20:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14846
-
Wouter Wolters commented on patch set 6 08/12/21, 20:39
ExportCommand.php:202Command::SUCCESSExportCommand.php:209Command::FAILURE -
Alexander Nitsche commented on patch set 6 08/13/21, 08:36
ExportCommand.php:202Reply UnresolvedI would skip that in this patch as no TYPO3 Core command currently uses that constant but simple integers 0 and 1 at the moment. I suggest to replace it in all commands at once or keep it as is.ExportCommand.php:209Reply UnresolvedThe same here: Skip it in this patch. -
Wouter Wolters voted on patch set 6 CR +1 08/13/21, 08:40
-
Benni Mack commented on patch set 6 08/13/21, 09:51
Feature-84718-AddCLIExportCommandToImpExpExtension.rst:35call the argument "target" I'd say.Feature-84718-AddCLIExportCommandToImpExpExtension.rst:36I would drop the short prefixes in general, as they are very specific to this, and feel very cryptic to use in short-hand prefix.Feature-84718-AddCLIExportCommandToImpExpExtension.rst:37I would not use `-f` as this could / should be reserved to --force (later-on to overwrite an existing export file for example)? and name this to "--type"Feature-84718-AddCLIExportCommandToImpExpExtension.rst:43I would call this option `--included-related`Feature-84718-AddCLIExportCommandToImpExpExtension.rst:46--exclude-disabled-recordsFeature-84718-AddCLIExportCommandToImpExpExtension.rst:47--exclude-html-css -
Alexander Nitsche uploaded patch set 7 08/14/21, 08:59
-
Alexander Nitsche commented on patch set 7 08/14/21, 09:09
Feature-84718-AddCLIExportCommandToImpExpExtension.rst:35Reply Unresolvedi would like to stick to "file.." both to align with the `impexp:import` argument and to align with the internal naming conventions. i changed it to "filename" to mark a difference to the "file" of `impexp:import` and to provide even more clarity of what is expected.Feature-84718-AddCLIExportCommandToImpExpExtension.rst:36ReplyDoneFeature-84718-AddCLIExportCommandToImpExpExtension.rst:37ReplyDoneFeature-84718-AddCLIExportCommandToImpExpExtension.rst:43ReplyUsing "related" instead of "relative" is much better, thank you, applied. The lowerCamelCased options are in line with the `impexp:import` command. I would move the transformation to lower-cased into an own issue which will handle both commands at once and use proper deprecation.Feature-84718-AddCLIExportCommandToImpExpExtension.rst:46Reply UnresolvedWould move lowerCamelCased -> lower-cased renaming into own issue.Feature-84718-AddCLIExportCommandToImpExpExtension.rst:47Reply UnresolvedWould move lowerCamelCased -> lower-cased renaming into own issue. -
core-ci voted on patch set 7 V -1 08/14/21, 09:26 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15042
-
Alexander Nitsche rebased onto patch set 8 08/14/21, 09:38
-
core-ci voted on patch set 8 V +1 08/14/21, 10:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15047
-
Benni Mack commented on patch set 8 08/14/21, 11:11
Feature-84718-AddCLIExportCommandToImpExpExtension.rst:43ReplyAlright. Fine by me! -
Alexander Nitsche rebased onto patch set 9 08/15/21, 14:20
-
core-ci voted on patch set 9 V +1 08/15/21, 14:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15118
-
Alexander Nitsche commented on patch set 9 08/15/21, 14:37
Feature-84718-AddCLIExportCommandToImpExpExtension.rst:43ReplyThe lowerCamelCased options get marked deprecated and replaced by lower-cased options in this follow-up patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/70599. -
Benni Mack voted on patch set 9 CR +1 08/16/21, 09:09
-
Wouter Wolters voted on patch set 9 CR +1 08/19/21, 12:21
-
Oli Bartsch commented on patch set 9 08/20/21, 11:22
With following arguments/options: $ bin/typo3 impexp:export custom-name --type t3d --pid 411 --levels 999 I get: Uncaught TYPO3 Exception Call to a member function getAttribute() on null thrown in file /var/www/html/typo3/sysext/backend/Classes/Tree/View/AbstractTreeView.php in line 180 Reason seems to be the initialization of ExportPageTreeView which extends AbstractTreeView which calls $GLOBALS['TYPO3_REQUEST'] in its constructor. -
Alexander Nitsche commented on patch set 9 08/20/21, 16:18
Reply
This seems to be a regression introduced in #93158. If i revert the change of that patch in AbstractTreeView, the CLI command runs smoothly again (for an existing PID). How should we proceed here? -
Oli Bartsch commented on patch set 9 08/20/21, 16:34
Reply
Nice this was my patch ;) Seems I wasn't aware AbstractTreeView is used in CLI context. Will make a follow up patch. -
Oli Bartsch commented on patch set 9 08/20/21, 17:07
Reply
Have a look at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70689 -
Alexander Nitsche commented on patch set 9 08/23/21, 15:01
Reply Unresolved
The related patch #94947 got resolved and merged into master. this patch has been tested already with #94947 manually. Is anything left to merge this patch into master? -
Christian Kuhn voted on patch set 9 V +1 CR +1 08/23/21, 15:40
-
Benni Mack voted on patch set 9 V +2 CR +2 08/23/21, 15:59
-
Oli Bartsch voted on patch set 9 V +1 CR +1 08/23/21, 16:00
-
Benni Mack merged patch set 10 08/23/21, 16:16