Review main Merged

70394[BUGFIX] Add space below "new element" button

Jochen Roth CR +2 V +2 Easy +3 −2 updated 08/13/21, 20:53

Commit message

The "create new element" button in the form
editor was cut off.

This is fixed by calculating the height
minus the doc-header height.

Review

  • Code review CR +2 Done
    • waldhacker +2
    • Björn Jacob +1
  • Verified V +2 Done
    • waldhacker +2
    • Björn Jacob +1

Issues 1

Files 2

Review log 1114

  1. Jochen Roth uploaded patch set 1 08/10/21, 11:41

  2. core-ci voted on patch set 1 V +1 08/10/21, 11:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14476

  3. Wouter Wolters voted on patch set 1 CR +1 08/10/21, 13:28

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 08/10/21, 19:03

  5. Björn Jacob commented on patch set 1 V +1 CR +1 08/13/21, 15:23

    Just experienced the problem a couple of minutes ago and there it is: your patch. Great!
  6. waldhacker uploaded patch set 2 08/13/21, 20:15

  7. waldhacker voted on patch set 2 V +1 CR +1 08/13/21, 20:17

  8. Björn Jacob voted on patch set 2 V +1 CR +1 08/13/21, 20:20

  9. waldhacker uploaded patch set 3 08/13/21, 20:22

  10. Björn Jacob voted on patch set 3 V +1 CR +1 08/13/21, 20:29

  11. core-ci voted on patch set 2 V +1 08/13/21, 20:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15025

  12. waldhacker voted on patch set 3 V +2 CR +2 08/13/21, 20:32

  13. waldhacker merged patch set 4 08/13/21, 20:32

  14. core-ci voted on patch set 3 V +1 08/13/21, 20:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15027