70397[TASK] Scale custom backend logo to fit into given div
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1826
Show 1 earlier messages
-
Jochen Roth uploaded patch set 1 08/10/21, 13:35
-
core-ci voted on patch set 1 V +1 08/10/21, 14:27
-
Benni Mack commented on patch set 1 08/10/21, 15:40
I opt for master-only_topbar.scss:198if you have a "wide" logo, this isn't the perfect solution, what do you think? -
Jochen Roth uploaded patch set 2 08/11/21, 11:34
-
Jochen Roth commented on patch set 2 08/11/21, 11:46
Reply
Ok, removed 10.4_topbar.scss:198Reply UnresolvedImo, this will never be "perfect". Best solution is to have a properly cropped/sized image for this purpose. Tested a rather wide image (1756×386px) which looked good. -
core-ci voted on patch set 2 V +1 08/11/21, 11:47 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14576
-
Benni Mack updated the commit message in patch set 3 08/11/21, 15:26
-
Benni Mack voted on patch set 3 V +1 CR +1 08/11/21, 15:26
-
core-ci voted on patch set 3 V +1 08/11/21, 15:43 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14610
-
Jochen Roth uploaded patch set 4 08/12/21, 08:56
-
Oli Bartsch commented on patch set 4 08/12/21, 09:06
_topbar.scss:198Where does this value come from? For square images this now looks odd as the image is centered in the 180px frame. Will send you a screenshot on slack. -
core-ci voted on patch set 4 V +1 08/12/21, 09:09 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14661
-
Jochen Roth uploaded patch set 5 08/12/21, 11:22
-
Oli Bartsch uploaded patch set 6 08/12/21, 11:28
-
Jochen Roth uploaded patch set 7 08/12/21, 11:28
-
Oli Bartsch commented on patch set 7 V +1 CR +1 08/12/21, 11:30
_topbar.scss:198ReplyDone -
Jochen Roth commented on patch set 7 V +1 CR +1 08/12/21, 11:30
_topbar.scss:198ReplyThis value is the max width an should use. Basically just a limiter. -
core-ci voted on patch set 5 V +1 08/12/21, 11:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14705
-
core-ci voted on patch set 6 V +1 08/12/21, 11:45 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14707
-
core-ci voted on patch set 7 V -1 08/12/21, 11:50 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14708
-
Oli Bartsch uploaded patch set 8 08/12/21, 12:16
-
core-ci voted on patch set 8 V +1 08/12/21, 12:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14718
-
Oli Bartsch voted on patch set 8 V +1 CR +1 08/12/21, 12:43
-
Benni Mack voted on patch set 8 CR +2 08/12/21, 12:43
-
Benni Mack voted on patch set 8 V +2 08/12/21, 12:43
-
Benni Mack merged patch set 9 08/12/21, 12:43