Review main Merged

70397[TASK] Scale custom backend logo to fit into given div

Jochen Roth CR +2 V +2 Easy +9 −1 updated 08/12/21, 12:43

Commit message

The custom backend logo could break the layout if
not properly scaled.

This issue is fixed by setting max-width
and max-height for the image.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1826

Show 1 earlier messages
  1. Jochen Roth uploaded patch set 1 08/10/21, 13:35

  1. core-ci voted on patch set 1 V +1 08/10/21, 14:27

  2. Benni Mack commented on patch set 1 08/10/21, 15:40

    I opt for master-only

    _topbar.scss:198

    if you have a "wide" logo, this isn't the perfect solution, what do you think?
  3. Jochen Roth uploaded patch set 2 08/11/21, 11:34

  4. Jochen Roth commented on patch set 2 08/11/21, 11:46

    Reply

    Ok, removed 10.4

    _topbar.scss:198 Reply Unresolved

    Imo, this will never be "perfect". Best solution is to have a properly cropped/sized image for this purpose. Tested a rather wide image (1756×386px) which looked good.
  5. core-ci voted on patch set 2 V +1 08/11/21, 11:47 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14576

  6. Benni Mack updated the commit message in patch set 3 08/11/21, 15:26

  7. Benni Mack voted on patch set 3 V +1 CR +1 08/11/21, 15:26

  8. core-ci voted on patch set 3 V +1 08/11/21, 15:43 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14610

  9. Jochen Roth uploaded patch set 4 08/12/21, 08:56

  10. Oli Bartsch commented on patch set 4 08/12/21, 09:06

    _topbar.scss:198

    Where does this value come from? For square images this now looks odd as the image is centered in the 180px frame. Will send you a screenshot on slack.
  11. core-ci voted on patch set 4 V +1 08/12/21, 09:09 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14661

  12. Jochen Roth uploaded patch set 5 08/12/21, 11:22

  13. Oli Bartsch uploaded patch set 6 08/12/21, 11:28

  14. Jochen Roth uploaded patch set 7 08/12/21, 11:28

  15. Oli Bartsch commented on patch set 7 V +1 CR +1 08/12/21, 11:30

    _topbar.scss:198 Reply

    Done
  16. Jochen Roth commented on patch set 7 V +1 CR +1 08/12/21, 11:30

    _topbar.scss:198 Reply

    This value is the max width an should use. Basically just a limiter.
  17. core-ci voted on patch set 5 V +1 08/12/21, 11:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14705

  18. core-ci voted on patch set 6 V +1 08/12/21, 11:45 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14707

  19. core-ci voted on patch set 7 V -1 08/12/21, 11:50 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14708

  20. Oli Bartsch uploaded patch set 8 08/12/21, 12:16

  21. core-ci voted on patch set 8 V +1 08/12/21, 12:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14718

  22. Oli Bartsch voted on patch set 8 V +1 CR +1 08/12/21, 12:43

  23. Benni Mack voted on patch set 8 CR +2 08/12/21, 12:43

  24. Benni Mack voted on patch set 8 V +2 08/12/21, 12:43

  25. Benni Mack merged patch set 9 08/12/21, 12:43