7040[BUGFIX] Unlimited memory limit handling in system status report
Commit message
Review
-
Code review CR +2
- Tolleiv Nietsch +2
- Wouter Wolters +1
- Philipp Gampe +1
-
Verified V +2
- Tolleiv Nietsch +2
- Philipp Gampe +1
Files 2
Review log 25
-
Mario Rimann commented on patch set 1 01/14/12, 10:58
Sure, just go ahead and push a revised patch. -
Markus Klein commented on patch set 1 01/14/12, 10:58
Looks good to me, but someone else must approveclass.tx_reports_reports_status_systemstatus.php:90use t3lib_div::getBytesFromSizeMeasurement() here as it is done in the Installer checks. -
Markus Klein commented on patch set 1 1 comment 01/14/12, 10:58
No score I've some suggestions for this one. Do you mind if I push a modified version? -
Stefan Neufeind commented on patch set 2 01/14/12, 10:58
Looks good to me, but someone else must approve fine by reading -
Markus Klein uploaded patch set 2 01/14/12, 10:58
-
Philipp Gampe uploaded patch set 3 01/14/12, 10:58
-
Philipp Gampe commented on patch set 3 01/14/12, 10:58
I would prefer that you didn't submit this Patch makes value not human readable ... please stand by. -
Markus Klein commented on patch set 4 01/14/12, 10:58
I would prefer that you didn't submit this @Philipp: You are introducing a newline at the end of the file. Please make sure your environment is configured properly! -
Markus Klein uploaded patch set 5 01/14/12, 10:58
-
Tolleiv Nietsch commented on patch set 6 V 0 01/14/12, 10:58
by team member; Looks good to me, approved -
Markus Klein commented on patch set 6 01/14/12, 10:58
Looking at the unified patch set 3 again it says: -?> \No newline ... +?> Which means newline was introduced here. I cherry-picked set 2 and 3 and clearly in set 3 there appears a newline at the end. But never mind, I fixed 3 patches today already with this newline issue. -
Markus Klein uploaded patch set 6 01/14/12, 10:58
-
Markus Klein commented on patch set 6 01/14/12, 10:58
Newline and Resolves -> Fixes fixed. -
Philipp Gampe uploaded patch set 4 01/14/12, 10:58
-
Philipp Gampe commented on patch set 4 01/14/12, 10:58
Verified; Looks good to me, but someone else must approve Now works for me. -
Philipp Gampe commented on patch set 6 01/14/12, 10:58
@Markus No I didn't. Have a look at the real patch (unified). It says \No new line at end of file. I think this happens if some program (vim?) does this, but my git is set up to automatically fix this. Thus the hunk still exists, but does not introduce the newline. > color.whitespace=blank-at-eol,space-before-tab,intent-with-non-tab,blank-at-eof,trailing-space,cr-at-eof Or the old version had a \n\r linefeed instead of only \n. This could lead to the same problem. > core.autocrlf=input -
Philipp Gampe commented on patch set 6 01/14/12, 10:58
Verified; Looks good to me, but someone else must approve Renewing my vote. -
Mr. Jenkins commented on patch set 1 01/14/12, 10:58
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2581/ : SUCCESS -
Mr. Jenkins commented on patch set 2 01/14/12, 10:58
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2593/ : SUCCESS -
Mr. Jenkins commented on patch set 3 01/14/12, 10:58
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2825/ : SUCCESS -
Mr. Jenkins commented on patch set 4 01/14/12, 10:58
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2826/ : SUCCESS -
Mr. Jenkins commented on patch set 5 01/14/12, 10:58
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2828/ : SUCCESS -
Mr. Jenkins commented on patch set 6 01/14/12, 10:58
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2829/ : SUCCESS -
Wouter Wolters commented on patch set 6 01/14/12, 10:58
Looks good to me, but someone else must approve -
Tolleiv Nietsch merged patch set 6 01/14/12, 10:58