Review main Merged

70407[TASK] Merge cascading str_replace calls into one call

Wouter Wolters CR +2 V +2 Easy +21 −4 updated 09/11/21, 12:57

Commit message

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Wouter Wolters uploaded patch set 1 08/10/21, 17:15

  2. core-ci voted on patch set 1 V +1 08/10/21, 17:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14502

  3. crell commented on patch set 1 08/10/21, 19:42

    FileList.php:1153 Unresolved

    Possible way to make this even easier to read: $replacements['</a>'] = ' ' . $title[1] . '</a>'; $replacements['</button>'] = ' ' . $title[1] . '</button>'; $action = str_replace(array_keys($replacements), array_values($replacements), $action); Which... I suppose is almost strtr() at that point. :-) (Same for the other one, too.)
  4. Anja Leichsenring rebased onto patch set 2 09/11/21, 12:32

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 09/11/21, 12:46

  6. core-ci voted on patch set 2 V +1 09/11/21, 12:55 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16549

  7. Anja Leichsenring voted on patch set 2 V +2 CR +2 09/11/21, 12:57

  8. Anja Leichsenring merged patch set 3 09/11/21, 12:57