Review main Merged

7041[FEATURE] Integrate config.pageTitleSeparator

Mario Rimann CR +2 V +2 Easy +17 −11 updated 06/03/13, 20:49

Commit message

Adds a Typoscript option to make the the separator string that is
used between the site title and the page title configurable.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Markus Klein +1
  • Verified V +2
    • Steffen Ritter +2
    • Markus Klein +1

Issues 1

Files 1

Review log 25

  1. Mario Rimann commented on patch set 1 12/16/11, 17:47

    Open issues/questions regarding this first draft: - am I allowed to change $st to $siteTitle (readability) within this patch? Or should this go into a separate bug report + patch? - how to handle spaces around the pageTitleSeparator? I tried with | - | and the result was "siteTitle| - |pageTitle"
  2. Mario Rimann uploaded patch set 2 12/16/11, 17:47

  3. Mario Rimann commented on patch set 2 12/16/11, 17:47

    @Markus: Patch set 2 contains the mentioned changes to the variable names for readability I agree to the comments in the mentioned bug report. But I have no clue how to implement those changes :-/
  4. Mario Rimann uploaded patch set 3 12/16/11, 17:47

  5. Mario Rimann commented on patch set 3 12/16/11, 17:47

  6. Dmitry Dulepov commented on patch set 3 1 comment 12/16/11, 17:47

    I would prefer that you didn't submit this
  7. Dmitry Dulepov commented on patch set 4 12/16/11, 17:47

    Fixed the issue with missing space after the separator.
  8. Dmitry Dulepov uploaded patch set 4 12/16/11, 17:47

  9. Markus Klein commented on patch set 1 12/16/11, 17:47

    I would prefer that you didn't submit this Yes you can and should rename variables for better readability. But in this case, a more powerful possibility is suggested in http://forge.typo3.org/issues/31319 I think it's best to implement it that way as it is a new feature anyway and for 4.7 we can deprecate the old functions.
  10. Markus Klein commented on patch set 2 12/16/11, 17:47

    (1 inline comment)
  11. Markus Klein commented on patch set 3 12/16/11, 17:47

    @Mario: Can you please post the link to the documentation update ticket here?
  12. Markus Klein commented on patch set 5 12/16/11, 17:47

    Looks good to me, but someone else must approve Rebased and code streamlining.
  13. Markus Klein uploaded patch set 5 12/16/11, 17:47

  14. Markus Klein voted on patch set 5 V 0 12/16/11, 17:47

  15. Georg Ringer commented on patch set 2 12/16/11, 17:47

    (2 inline comments)

    class.t3lib_tstemplate.php:1193

    can you rename $no_title to $noTitle and $titleFirst to something like $showTitleFirst + make default value to FALSE as it should be boolean

    class.t3lib_tstemplate.php:1202

    can you do a strict comparison or a !empty()
  16. Steffen Gebert commented on patch set 5 12/16/11, 17:47

    Don't forget to update TSref and the XML file of t3editor! We once agreed to not merge changes until documentation has been added!
  17. Steffen Ritter commented on patch set 5 V 0 12/16/11, 17:47

    by team member; Looks good to me, approved
  18. Steffen Ritter commented on patch set 5 12/16/11, 17:47

    Did we? well Documentation issue is in place: http://forge.typo3.org/issues/32320 I just added the notice for the merge.
  19. Steffen Ritter merged patch set 5 12/16/11, 17:47

  20. Mr. Jenkins commented on patch set 1 12/16/11, 17:47

  21. Mr. Jenkins commented on patch set 2 12/16/11, 17:47

  22. Mr. Jenkins commented on patch set 3 12/16/11, 17:47

  23. Mr. Jenkins commented on patch set 4 12/16/11, 17:47

  24. Mr. Jenkins commented on patch set 5 12/16/11, 17:47

  25. Markus Klein commented on patch set 5 12/16/11, 17:47

    And Mario posted the link already on Dec 6th here. (as I asked him for this)