7041[FEATURE] Integrate config.pageTitleSeparator
Commit message
Review
-
Code review CR +2
- Steffen Ritter +2
- Markus Klein +1
-
Verified V +2
- Steffen Ritter +2
- Markus Klein +1
Issues 1
Files 1
Review log 25
-
Mario Rimann commented on patch set 1 12/16/11, 17:47
Open issues/questions regarding this first draft: - am I allowed to change $st to $siteTitle (readability) within this patch? Or should this go into a separate bug report + patch? - how to handle spaces around the pageTitleSeparator? I tried with | - | and the result was "siteTitle| - |pageTitle" -
Mario Rimann uploaded patch set 2 12/16/11, 17:47
-
Mario Rimann commented on patch set 2 12/16/11, 17:47
@Markus: Patch set 2 contains the mentioned changes to the variable names for readability I agree to the comments in the mentioned bug report. But I have no clue how to implement those changes :-/ -
Mario Rimann uploaded patch set 3 12/16/11, 17:47
-
Mario Rimann commented on patch set 3 12/16/11, 17:47
Documentation issue: http://forge.typo3.org/issues/32320 -
Dmitry Dulepov commented on patch set 3 1 comment 12/16/11, 17:47
I would prefer that you didn't submit this -
Dmitry Dulepov commented on patch set 4 12/16/11, 17:47
Fixed the issue with missing space after the separator. -
Dmitry Dulepov uploaded patch set 4 12/16/11, 17:47
-
Markus Klein commented on patch set 1 12/16/11, 17:47
I would prefer that you didn't submit this Yes you can and should rename variables for better readability. But in this case, a more powerful possibility is suggested in http://forge.typo3.org/issues/31319 I think it's best to implement it that way as it is a new feature anyway and for 4.7 we can deprecate the old functions. -
Markus Klein commented on patch set 2 12/16/11, 17:47
(1 inline comment) -
Markus Klein commented on patch set 3 12/16/11, 17:47
@Mario: Can you please post the link to the documentation update ticket here? -
Markus Klein commented on patch set 5 12/16/11, 17:47
Looks good to me, but someone else must approve Rebased and code streamlining. -
Markus Klein uploaded patch set 5 12/16/11, 17:47
-
Markus Klein voted on patch set 5 V 0 12/16/11, 17:47
-
Georg Ringer commented on patch set 2 12/16/11, 17:47
(2 inline comments)class.t3lib_tstemplate.php:1193can you rename $no_title to $noTitle and $titleFirst to something like $showTitleFirst + make default value to FALSE as it should be booleanclass.t3lib_tstemplate.php:1202can you do a strict comparison or a !empty() -
Steffen Gebert commented on patch set 5 12/16/11, 17:47
Don't forget to update TSref and the XML file of t3editor! We once agreed to not merge changes until documentation has been added! -
Steffen Ritter commented on patch set 5 V 0 12/16/11, 17:47
by team member; Looks good to me, approved -
Steffen Ritter commented on patch set 5 12/16/11, 17:47
Did we? well Documentation issue is in place: http://forge.typo3.org/issues/32320 I just added the notice for the merge. -
Steffen Ritter merged patch set 5 12/16/11, 17:47
-
Mr. Jenkins commented on patch set 1 12/16/11, 17:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2582/ : SUCCESS -
Mr. Jenkins commented on patch set 2 12/16/11, 17:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2585/ : SUCCESS -
Mr. Jenkins commented on patch set 3 12/16/11, 17:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2610/ : SUCCESS -
Mr. Jenkins commented on patch set 4 12/16/11, 17:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2616/ : SUCCESS -
Mr. Jenkins commented on patch set 5 12/16/11, 17:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2748/ : SUCCESS -
Markus Klein commented on patch set 5 12/16/11, 17:47
And Mario posted the link already on Dec 6th here. (as I asked him for this)