Review main Merged

70411[BUGFIX] Accept JS spam protected email addresses

Torben Hansen CR +2 V +2 Easy +16 −1 updated 08/11/21, 10:41

Commit message

When TYPO3 is configured to spam protect email
addresses using an offset, then the HTML sanitizer
introduced in #94375 will remove the generated
JavaScript in the href link attribute.

This change makes the HTML sanitizer aware of the
`javascript:linkTo_UnCryptMailto` pattern for href
attribute.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 912

  1. Torben Hansen uploaded patch set 1 08/10/21, 18:11

  2. core-ci voted on patch set 1 V +1 08/10/21, 18:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14508

  3. Oli Bartsch voted on patch set 1 CR +1 08/10/21, 18:42

  4. Oli Bartsch voted on patch set 1 V +1 08/10/21, 18:45

  5. Oliver Hader uploaded patch set 2 08/10/21, 18:47

  6. Oliver Hader commented on patch set 2 V +1 CR +1 08/10/21, 18:48

    Added the result of `config.spamProtectEmailAddresses = ascii` to test-cases, just to explicitly make the impact/result clear.
  7. core-ci voted on patch set 2 V -1 08/10/21, 19:04 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14513

  8. core-ci voted on patch set 2 V +1 08/10/21, 19:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14513

  9. Oli Bartsch voted on patch set 2 V +1 CR +1 08/10/21, 20:45

  10. Georg Ringer voted on patch set 2 V +2 CR +2 08/11/21, 06:51

  11. Georg Ringer merged patch set 3 08/11/21, 06:51

  12. Oliver Hader commented on patch set 3 08/11/21, 10:41

    @Georg: Back-ports did exist already... luckily nothing was overridden