70432[BUGFIX] Allow shortcut pages to pages of other sites
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 7
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php4+34 −6
- typo3/sysext/frontend/Classes/Middleware/ShortcutAndMountPointRedirect.php+6 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/PlainScenario.yaml+1 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/SlugScenario.yaml+1 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SiteRequestTest.php2+130 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugLinkGeneratorTest.php+1 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugSiteRequestTest.php+47 −0
Review log 2536
Show 811 earlier messages
-
Benni Mack uploaded patch set 1 08/10/21, 18:17
-
core-ci voted on patch set 1 V +1 08/10/21, 18:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14510
-
Oli Bartsch commented on patch set 1 08/10/21, 18:41
-
Benni Mack updated the commit message in patch set 2 08/10/21, 19:46
-
core-ci voted on patch set 2 V +1 08/10/21, 19:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14515
-
Benni Mack commented on patch set 2 CR -1 08/12/21, 10:29
I think some tests would be nice -
Stefan Bürk uploaded patch set 3 11/11/21, 21:42
-
Stefan Bürk commented on patch set 3 CR -1 11/11/21, 21:43
@Benni Tests should fail. Let's talk if my expectation are wrong (and as such done as tests) or if we need to change some tests to test that they are failing. -
core-ci voted on patch set 3 V -1 11/11/21, 21:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19194
-
Georg Ringer commented on patch set 3 11/12/21, 07:33
TypoScriptFrontendController.php:1484can we move the type cast up and we avoid it on both places? -
Benni Mack uploaded patch set 4 11/12/21, 08:17
-
Benni Mack commented on patch set 4 11/12/21, 08:18
TypoScriptFrontendController.php:1464ReplyDoneTypoScriptFrontendController.php:1484ReplyDone -
core-ci voted on patch set 4 V -1 11/12/21, 08:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19198
-
Stefan Bürk uploaded patch set 5 11/12/21, 10:48
-
core-ci voted on patch set 5 V -1 11/12/21, 11:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19200
-
Benni Mack updated the commit message in patch set 6 11/18/21, 10:46
-
core-ci voted on patch set 6 V -1 11/18/21, 12:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19471
-
Benni Mack uploaded patch set 7 11/27/21, 13:14
-
core-ci voted on patch set 7 V -1 11/27/21, 13:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19857
-
Benni Mack uploaded patch set 8 11/27/21, 14:16
-
core-ci voted on patch set 8 V -1 11/27/21, 16:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19866
-
Benni Mack uploaded patch set 9 11/28/21, 21:39
-
core-ci voted on patch set 9 V -1 11/28/21, 21:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19950
-
core-ci voted on patch set 9 V +1 11/28/21, 22:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19950
-
Benni Mack voted on patch set 9 CR +1 11/28/21, 22:10
-
Stefan Bürk voted on patch set 9 V +1 CR +1 11/29/21, 08:48
-
Benni Mack wrote 11/29/21, 10:23
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 10 11/29/21, 10:23
-
Benni Mack updated the commit message in patch set 11 11/29/21, 11:02
-
core-ci voted on patch set 11 V +1 11/29/21, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19969
-
Stefan Bürk voted on patch set 11 V +1 CR +1 11/29/21, 11:31
-
Oli Bartsch voted on patch set 11 V +1 CR +1 12/10/21, 14:12
-
Benni Mack voted on patch set 11 V +2 CR +2 12/10/21, 16:22
-
Benni Mack merged patch set 12 12/10/21, 16:23
-
Benjamin Franzke commented on patch set 12 12/10/21, 21:24
SiteRequestTest.php:1083internalRequestContext is not available since https://review.typo3.org/c/Packages/TYPO3.CMS/+/72506 (This patch was written and tested before that patch; now that both are applies, tests fail…) -
Stefan Bürk commented on patch set 12 12/11/21, 14:08
SiteRequestTest.php:1083ReplyFixed with followup: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72630
TypoScriptFrontendController.php:1464