Review main Merged

70432[BUGFIX] Allow shortcut pages to pages of other sites

Benni Mack CR +2 V +2 Normal +220 −7 updated 01/01/22, 20:03

Commit message

TYPO3 has had a long history of linking to
other pages in other pagetrees. Most of the issues
were solved with the TYPO3 v9 Routing and Site Handling.

Through this feature, it is now possible to
easily create a page of type shortcut and link to
a page in a different page tree.

This was previously not possible because TYPO3 Core
by default generated URLs like "/index.php?id=123"
where people could simply add ?id=355 (where page 355
resides on a different page tree).

Since this change has been resolved, links to
other pages can be allowed and are automatically
redirected.

If we ever get rid of allowing to call pages with
an `?id=123` query parameter, the $pageNotFound=3 case
can be removed completely.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 7

Review log 2536

Show 811 earlier messages
  1. Benni Mack uploaded patch set 1 08/10/21, 18:17

  2. core-ci voted on patch set 1 V +1 08/10/21, 18:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14510

  3. Oli Bartsch commented on patch set 1 08/10/21, 18:41

    TypoScriptFrontendController.php:1464

    According to the above comment and the commit message, only GET parameters should be considered, right?
  4. Benni Mack updated the commit message in patch set 2 08/10/21, 19:46

  5. core-ci voted on patch set 2 V +1 08/10/21, 19:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14515

  6. Benni Mack commented on patch set 2 CR -1 08/12/21, 10:29

    I think some tests would be nice
  7. Stefan Bürk uploaded patch set 3 11/11/21, 21:42

  8. Stefan Bürk commented on patch set 3 CR -1 11/11/21, 21:43

    @Benni Tests should fail. Let's talk if my expectation are wrong (and as such done as tests) or if we need to change some tests to test that they are failing.
  9. core-ci voted on patch set 3 V -1 11/11/21, 21:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19194

  10. Georg Ringer commented on patch set 3 11/12/21, 07:33

    TypoScriptFrontendController.php:1484

    can we move the type cast up and we avoid it on both places?
  11. Benni Mack uploaded patch set 4 11/12/21, 08:17

  1. Benni Mack commented on patch set 4 11/12/21, 08:18

    TypoScriptFrontendController.php:1464 Reply

    Done

    TypoScriptFrontendController.php:1484 Reply

    Done
  2. core-ci voted on patch set 4 V -1 11/12/21, 08:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19198

  3. Stefan Bürk uploaded patch set 5 11/12/21, 10:48

  4. core-ci voted on patch set 5 V -1 11/12/21, 11:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19200

  5. Benni Mack updated the commit message in patch set 6 11/18/21, 10:46

  6. core-ci voted on patch set 6 V -1 11/18/21, 12:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19471

  7. Benni Mack uploaded patch set 7 11/27/21, 13:14

  8. core-ci voted on patch set 7 V -1 11/27/21, 13:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19857

  9. Benni Mack uploaded patch set 8 11/27/21, 14:16

  10. core-ci voted on patch set 8 V -1 11/27/21, 16:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19866

  11. Benni Mack uploaded patch set 9 11/28/21, 21:39

  12. core-ci voted on patch set 9 V -1 11/28/21, 21:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19950

  13. core-ci voted on patch set 9 V +1 11/28/21, 22:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19950

  14. Benni Mack voted on patch set 9 CR +1 11/28/21, 22:10

  15. Stefan Bürk voted on patch set 9 V +1 CR +1 11/29/21, 08:48

  16. Benni Mack wrote 11/29/21, 10:23

    Change destination moved from master to main
  17. Benni Mack updated the commit message in patch set 10 11/29/21, 10:23

  18. Benni Mack updated the commit message in patch set 11 11/29/21, 11:02

  19. core-ci voted on patch set 11 V +1 11/29/21, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19969

  20. Stefan Bürk voted on patch set 11 V +1 CR +1 11/29/21, 11:31

  21. Oli Bartsch voted on patch set 11 V +1 CR +1 12/10/21, 14:12

  22. Benni Mack voted on patch set 11 V +2 CR +2 12/10/21, 16:22

  23. Benni Mack merged patch set 12 12/10/21, 16:23

  24. Benjamin Franzke commented on patch set 12 12/10/21, 21:24

    SiteRequestTest.php:1083

    internalRequestContext is not available since https://review.typo3.org/c/Packages/TYPO3.CMS/+/72506 (This patch was written and tested before that patch; now that both are applies, tests fail…)
  25. Stefan Bürk commented on patch set 12 12/11/21, 14:08

    SiteRequestTest.php:1083 Reply