Review main Merged

70437[TASK] Update to Guzzle 7.3.0 and guzzlehttp/psr7 2.0

Benni Mack CR +2 V +2 Normal +50 −38 updated 08/30/21, 11:20

Commit message

Our dependency guzzlehttp/psr7 is raised to 2.0,
however "LazyOpenStream" is now final, and that's
why we need to change our "SelfEmittableLazyOpenStream"
to become a decorator of the LazyOpenStream.

Used composer commands:

composer req guzzlehttp/guzzle:^7.3.0 guzzlehttp/psr7:^2.0
composer req guzzlehttp/guzzle:^7.3.0 guzzlehttp/psr7:^2.0 -d typo3/sysext/core --no-update

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 914

  1. Benni Mack uploaded patch set 1 08/10/21, 20:15

  2. core-ci voted on patch set 1 V -1 08/10/21, 20:37 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14520

  3. Benni Mack uploaded patch set 2 08/11/21, 08:02

  4. Benni Mack updated the commit message in patch set 3 08/11/21, 08:05

  5. core-ci voted on patch set 2 V -1 08/11/21, 08:25 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14549

  6. core-ci voted on patch set 3 V -1 08/11/21, 08:27 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14550

  7. Wouter Wolters uploaded patch set 4 08/12/21, 10:52

  8. Benni Mack commented on patch set 4 08/12/21, 11:16

    @wouter we need a testing framework change for this https://github.com/TYPO3/testing-framework/pull/255
  9. Wouter Wolters commented on patch set 4 08/12/21, 11:19

    Reply

    Ok, was not aware of that. I thought only an update of codeception was needed. Voted that patch too.
  10. core-ci voted on patch set 4 V -1 08/12/21, 11:24 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14702

  11. Wouter Wolters uploaded patch set 5 08/30/21, 08:35

  12. core-ci voted on patch set 5 V +1 08/30/21, 08:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15845

  13. Benni Mack voted on patch set 5 V +2 CR +2 08/30/21, 11:20

  14. Benni Mack merged patch set 6 08/30/21, 11:20