Review main Merged

70442[TASK] Update codeception dev-dependency

Benni Mack CR +2 V +2 Normal +74 −76 updated 08/11/21, 07:55

Commit message

This change is a pre-requisite for allowing
guzzle/psr7 2.0.

Used composer command:
  composer req --dev codeception/codeception:^4.1.22 -W

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 710

  1. Benni Mack uploaded patch set 1 08/11/21, 07:22

  2. Benni Mack uploaded patch set 2 08/11/21, 07:23

  3. core-ci voted on patch set 1 V +1 08/11/21, 07:35 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14540

  4. Christian Kuhn commented on patch set 2 08/11/21, 07:38

    +1 already saw that latest codeception patch level allows guzzle/psr7 2.0 - this recently triggered an issue with ext:container in core 11.2 (but has been resolved in core already, i'll relate the patch. should be good to go.
  5. Christian Kuhn updated the commit message in patch set 3 08/11/21, 07:39

  6. core-ci voted on patch set 2 V +1 08/11/21, 07:39 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14541

  7. Christian Kuhn voted on patch set 3 V +1 CR +1 08/11/21, 07:48

  8. core-ci voted on patch set 3 V +1 08/11/21, 07:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14543

  9. Benni Mack voted on patch set 3 V +2 CR +2 08/11/21, 07:55

  10. Benni Mack merged patch set 4 08/11/21, 07:55