Review main Merged

70443[TASK] Add button for table wizard to set row/col count

Jochen Roth CR +2 V +2 Normal +131 −3 updated 08/26/21, 14:45

Commit message

It's not possible to add rows/colums once all
have been deleted manually.

This has been fixed by adding a new button
next to this "Small fields" button which allows
a user to set the needed amount of columns
and rows.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 3344

Show 1519 earlier messages
  1. Jochen Roth uploaded patch set 1 08/11/21, 08:07

  2. Jochen Roth uploaded patch set 2 08/11/21, 08:17

  3. core-ci voted on patch set 1 V -1 08/11/21, 08:27 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14551

  4. core-ci voted on patch set 2 V +1 08/11/21, 08:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14553

  5. Benni Mack voted on patch set 2 V +1 CR +1 08/12/21, 20:22

  6. Benni Mack commented on patch set 2 V 0 CR 0 08/12/21, 20:42

    TableWizardElement.ts:249

    can we use `html` directly?
  7. Jochen Roth commented on patch set 2 08/13/21, 14:54

    TableWizardElement.ts:249 Reply Unresolved

    Tried it and it did not work. It spits out html as text.
  8. kharaf voted on patch set 2 V +1 08/14/21, 08:24

  9. Christian Kuhn commented on patch set 2 V -1 08/14/21, 11:44

    weird. this does not work for me at all - i receive the modal (imho when there is 'nothing' values should be init to 1/1), then apply, then nothing happens.
  10. Jochen Roth uploaded patch set 3 08/14/21, 14:41

  11. Jochen Roth commented on patch set 3 08/14/21, 14:50

    Reply

    Thanks... fixed the issue. And initial value is set to 1/1. Can you please try again?
  12. core-ci voted on patch set 3 V +1 08/14/21, 15:02 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15088

  13. Benni Mack voted on patch set 3 V +1 CR +1 08/23/21, 12:29

  14. Anja Leichsenring voted on patch set 3 V +1 CR +1 08/23/21, 17:01

  15. Andreas Kienast commented on patch set 3 V -1 08/23/21, 18:55

    TableWizardElement.ts:254 Unresolved

    Is it intended I can enter negative numbers and thus decrease the amount of rows and cols?
  16. Andreas Kienast uploaded patch set 4 08/23/21, 18:58

  17. Andreas Kienast voted on patch set 4 V +1 CR +1 08/23/21, 18:58

  18. core-ci voted on patch set 4 V +1 08/23/21, 19:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15451

  19. Andreas Kienast commented on patch set 4 V -1 CR 0 08/23/21, 19:27

    According to the JavaScript it's intended to remove rows and columns by providing negative numbers. However, as stated before, this clears the whole table.
  1. Jochen Roth uploaded patch set 5 08/24/21, 08:05

  2. Jochen Roth uploaded patch set 6 08/24/21, 08:11

  3. Jochen Roth commented on patch set 6 08/24/21, 08:16

    Reply

    Now a minimum value is used and validated. Thanks for for your review.
  4. core-ci voted on patch set 6 V +1 08/24/21, 08:24 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15476

  5. core-ci voted on patch set 5 V +1 08/24/21, 08:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15475

  6. Christian Kuhn voted on patch set 6 V +1 CR +1 08/25/21, 17:20

  7. Jochen Roth commented on patch set 6 CR -1 08/26/21, 10:09

    TableWizardElement.ts:251

    Get rid of jQuery!
  8. Christian Kuhn voted on patch set 6 V 0 CR 0 08/26/21, 10:10

  9. Jochen Roth uploaded patch set 7 08/26/21, 11:21

  10. Jochen Roth uploaded patch set 8 08/26/21, 11:29

  11. core-ci voted on patch set 7 V +1 08/26/21, 11:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15663

  12. Jochen Roth uploaded patch set 9 08/26/21, 11:38

  13. Jochen Roth commented on patch set 9 08/26/21, 11:43

    TableWizardElement.ts:251 Reply

    Done
  14. core-ci voted on patch set 9 V +1 08/26/21, 11:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15666

  15. Jochen Roth uploaded patch set 10 08/26/21, 12:02

  16. Jochen Roth uploaded patch set 11 08/26/21, 12:05

  17. core-ci voted on patch set 10 V +1 08/26/21, 12:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15669

  18. core-ci voted on patch set 11 V +1 08/26/21, 12:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15670

  19. Oli Bartsch commented on patch set 11 CR -1 08/26/21, 13:46

    On it
  20. Oli Bartsch uploaded patch set 12 08/26/21, 14:12

  21. Oli Bartsch voted on patch set 12 V +1 CR +1 08/26/21, 14:12

  22. Christian Kuhn voted on patch set 12 V +1 CR +1 08/26/21, 14:20

  23. core-ci voted on patch set 12 V +1 08/26/21, 14:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15679

  24. Oli Bartsch voted on patch set 12 V +2 CR +2 08/26/21, 14:44

  25. Oli Bartsch merged patch set 13 08/26/21, 14:45