70443[TASK] Add button for table wizard to set row/col count
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
-
Verified V +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 3
Review log 3344
Show 1519 earlier messages
-
Jochen Roth uploaded patch set 1 08/11/21, 08:07
-
Jochen Roth uploaded patch set 2 08/11/21, 08:17
-
core-ci voted on patch set 1 V -1 08/11/21, 08:27 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14551
-
core-ci voted on patch set 2 V +1 08/11/21, 08:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14553
-
Benni Mack voted on patch set 2 V +1 CR +1 08/12/21, 20:22
-
Benni Mack commented on patch set 2 V 0 CR 0 08/12/21, 20:42
-
Jochen Roth commented on patch set 2 08/13/21, 14:54
TableWizardElement.ts:249Reply UnresolvedTried it and it did not work. It spits out html as text. -
kharaf voted on patch set 2 V +1 08/14/21, 08:24
-
Christian Kuhn commented on patch set 2 V -1 08/14/21, 11:44
weird. this does not work for me at all - i receive the modal (imho when there is 'nothing' values should be init to 1/1), then apply, then nothing happens. -
Jochen Roth uploaded patch set 3 08/14/21, 14:41
-
Jochen Roth commented on patch set 3 08/14/21, 14:50
Reply
Thanks... fixed the issue. And initial value is set to 1/1. Can you please try again? -
core-ci voted on patch set 3 V +1 08/14/21, 15:02 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15088
-
Benni Mack voted on patch set 3 V +1 CR +1 08/23/21, 12:29
-
Anja Leichsenring voted on patch set 3 V +1 CR +1 08/23/21, 17:01
-
Andreas Kienast commented on patch set 3 V -1 08/23/21, 18:55
TableWizardElement.ts:254UnresolvedIs it intended I can enter negative numbers and thus decrease the amount of rows and cols? -
Andreas Kienast uploaded patch set 4 08/23/21, 18:58
-
Andreas Kienast voted on patch set 4 V +1 CR +1 08/23/21, 18:58
-
core-ci voted on patch set 4 V +1 08/23/21, 19:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15451
-
Andreas Kienast commented on patch set 4 V -1 CR 0 08/23/21, 19:27
According to the JavaScript it's intended to remove rows and columns by providing negative numbers. However, as stated before, this clears the whole table.
-
Jochen Roth uploaded patch set 5 08/24/21, 08:05
-
Jochen Roth uploaded patch set 6 08/24/21, 08:11
-
Jochen Roth commented on patch set 6 08/24/21, 08:16
Reply
Now a minimum value is used and validated. Thanks for for your review. -
core-ci voted on patch set 6 V +1 08/24/21, 08:24 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15476
-
core-ci voted on patch set 5 V +1 08/24/21, 08:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15475
-
Christian Kuhn voted on patch set 6 V +1 CR +1 08/25/21, 17:20
-
Jochen Roth commented on patch set 6 CR -1 08/26/21, 10:09
TableWizardElement.ts:251Get rid of jQuery! -
Christian Kuhn voted on patch set 6 V 0 CR 0 08/26/21, 10:10
-
Jochen Roth uploaded patch set 7 08/26/21, 11:21
-
Jochen Roth uploaded patch set 8 08/26/21, 11:29
-
core-ci voted on patch set 7 V +1 08/26/21, 11:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15663
-
Jochen Roth uploaded patch set 9 08/26/21, 11:38
-
Jochen Roth commented on patch set 9 08/26/21, 11:43
TableWizardElement.ts:251ReplyDone -
core-ci voted on patch set 9 V +1 08/26/21, 11:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15666
-
Jochen Roth uploaded patch set 10 08/26/21, 12:02
-
Jochen Roth uploaded patch set 11 08/26/21, 12:05
-
core-ci voted on patch set 10 V +1 08/26/21, 12:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15669
-
core-ci voted on patch set 11 V +1 08/26/21, 12:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15670
-
Oli Bartsch commented on patch set 11 CR -1 08/26/21, 13:46
On it -
Oli Bartsch uploaded patch set 12 08/26/21, 14:12
-
Oli Bartsch voted on patch set 12 V +1 CR +1 08/26/21, 14:12
-
Christian Kuhn voted on patch set 12 V +1 CR +1 08/26/21, 14:20
-
core-ci voted on patch set 12 V +1 08/26/21, 14:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15679
-
Oli Bartsch voted on patch set 12 V +2 CR +2 08/26/21, 14:44
-
Oli Bartsch merged patch set 13 08/26/21, 14:45
TableWizardElement.ts:249