Review main Merged

70445[BUGFIX] Extbase ObjectConverter properly handles instantiation

Oli Bartsch CR +2 V +2 Normal +68 −26 updated 08/23/21, 21:53

Commit message

The extbase ObjectConverter - typically used when mapping
request arguments to target domain models - needs more
fine grained handling to drop ObjectManager usages. We
missed some details with #94451.

The patch takes care of this and adds an explanation
together with possible future options to the codebase.

This fixes deprecation log entries triggered by the
belog module.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Anja Leichsenring +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1114

  1. Oli Bartsch uploaded patch set 1 08/11/21, 09:14

  2. Christian Kuhn commented on patch set 1 CR -1 08/11/21, 09:15

    ObjectConverter.php:257

    need to have a detailed look. my initial plan was to drop everything below, so everything below should be 'fallback, only.
  3. core-ci voted on patch set 1 V +1 08/11/21, 09:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14559

  4. Christian Kuhn uploaded patch set 2 08/23/21, 14:34

  5. core-ci voted on patch set 2 V +1 08/23/21, 14:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15413

  6. Anja Leichsenring commented on patch set 3 08/23/21, 16:26

    Published edit on patch set 2.
  7. Anja Leichsenring voted on patch set 3 CR +1 08/23/21, 16:26

  8. Nikita Hovratov commented on patch set 3 08/23/21, 16:36

    ObjectConverter.php:289

    double single
  9. core-ci voted on patch set 3 V +1 08/23/21, 16:43 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15421

  10. Christian Kuhn commented on patch set 3 08/23/21, 17:02

    ObjectConverter.php:257 Reply

    Done

    ObjectConverter.php:289 Reply

    Done
  11. Andreas Kienast voted on patch set 3 V +1 CR +1 08/23/21, 19:51

  12. Oli Bartsch voted on patch set 3 V +1 CR +1 08/23/21, 20:07

  13. Christian Kuhn voted on patch set 3 V +2 CR +2 08/23/21, 21:53

  14. Christian Kuhn merged patch set 4 08/23/21, 21:53