Review main Merged

70447[BUGFIX] Provide current table definition for Sqlite

Simon Gilli CR +2 V +2 Easy +13 −5 updated 08/11/21, 16:05

Commit message

Sqlite needs the current table definition in the alterTable() method to
be able to alter the table. This patch adds the current definition to
the upgrade wizard to work properly with Sqlite databases.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Daniel Siepmann +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 710

  1. Simon Gilli uploaded patch set 1 08/11/21, 12:16

  2. Simon Gilli updated the commit message in patch set 2 08/11/21, 12:19

  3. Simon Gilli updated the commit message in patch set 3 08/11/21, 12:19

  4. Daniel Siepmann commented on patch set 3 V +1 08/11/21, 12:23

    Testes on real world website coming from v10 and executing wizard via Backend -> install tool.
  5. core-ci voted on patch set 1 V +1 08/11/21, 12:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14585

  6. core-ci voted on patch set 2 V +1 08/11/21, 12:35 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14586

  7. core-ci voted on patch set 3 V +1 08/11/21, 12:40 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14587

  8. Markus Klein voted on patch set 3 V +1 CR +1 08/11/21, 14:58

  9. Benni Mack voted on patch set 3 V +2 CR +2 08/11/21, 16:05

  10. Benni Mack merged patch set 4 08/11/21, 16:05