Review main Merged

70450[TASK] Streamline and modernize form manager

Andreas Steiger CR +2 V +2 Normal +108 −104 updated 08/13/21, 15:30

Commit message

Streamline and optimize styling and markup of the form manager of form module.

* Clean up markup and classes of form list
* Optimize UX of the form list and use the new alternative action menu for better icon description
* Use new common styles and elements for better overview and modern look

Review

  • Code review CR +2 Done
    • waldhacker +2
    • Paul H +1
    • Björn Jacob +1
  • Verified V +2 Done
    • waldhacker +2
    • Paul H +1
    • Björn Jacob +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 2638

Show 1013 earlier messages
  1. Andreas Steiger uploaded patch set 1 08/11/21, 12:51

  2. core-ci voted on patch set 1 V -1 08/11/21, 13:06 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14591

  3. Andreas Steiger uploaded patch set 2 08/11/21, 13:39

  4. core-ci voted on patch set 2 V +1 08/11/21, 13:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14592

  5. Björn Jacob voted on patch set 2 V +1 CR +1 08/11/21, 15:06

  6. Paul H commented on patch set 2 CR -1 08/12/21, 14:13

    I would like to see the Edit and Copy icons grouped together, and the Delete function moved to the overflow menu. This prioritizes them based on frequency of use. It also prevents the UX problem where the most common action (edit) is too close to the most destructive action (delete). We are working on a similar change in the page module. Elsewhere in TYPO3, and previously in the form manager, clicking the reference count opens the info panel. Could we keep that functionality?
  7. Andreas Steiger commented on patch set 2 08/12/21, 15:43

    Reply

    Thanks for your nice review and your thoughts Paul! Yes, of course it is possible to keep the reference link around the label, but in gerneral this is not the best usability so we need it also in the overflow menu with a label. Your point with the delete button is absolutely right! I don`t like the delete button near to edit, but I tried to streamline it to the list module. there is also the delete button easy to click. But I like to put that also in the menu. What I wouldn`t do is to put the duplicate (copy) icon out of the overflow menu, because this icon is not so clear and needs a short description/label. So the place in the context menu will be better. Is it bad to see only the edit button in the list? Could be a solution...
  8. waldhacker rebased onto patch set 3 08/12/21, 23:10

  9. core-ci voted on patch set 3 V +1 08/12/21, 23:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14873

  10. Björn Jacob commented on patch set 3 08/13/21, 08:02

    My thoughts on your discussion: * Making the reference count clickable is a good idea. In addition, I would keep the function in the action menu. * Moving the delete action to the action menu would be fine with me. It is quite seldom that you have to delete forms.
  11. Andreas Steiger uploaded patch set 4 08/13/21, 10:50

  12. Björn Jacob commented on patch set 4 08/13/21, 11:11

    Now all the ideas of Paul are considered. Awesome patch. Let's get it in 😊
  13. Björn Jacob voted on patch set 4 V +1 CR +1 08/13/21, 11:11

  1. core-ci voted on patch set 4 V -1 08/13/21, 11:12 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14935

  2. core-ci voted on patch set 4 V +1 08/13/21, 12:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14935

  3. Andreas Steiger uploaded patch set 5 08/13/21, 12:20

  4. Paul H commented on patch set 5 08/13/21, 12:30

    Reply

    OK with putting Duplicate Form behind the action/overflow menu in order to give it a label and simplify the overall interface. Overall a nice improvement over v10 UI.
  5. core-ci voted on patch set 5 V -1 08/13/21, 12:38 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14956

  6. Andreas Steiger uploaded patch set 6 08/13/21, 12:45

  7. Paul H commented on patch set 6 08/13/21, 12:48

    I'm just noticing the wording change from "Remove" to "Delete". We use Delete elsewhere in TYPO3. What are your thoughts on this wording change?
  8. Andreas Steiger uploaded patch set 7 08/13/21, 12:58

  9. core-ci voted on patch set 6 V +1 08/13/21, 12:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14960

  10. Björn Jacob voted on patch set 7 V +1 CR +1 08/13/21, 13:08

  11. core-ci voted on patch set 7 V +1 08/13/21, 13:15 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14963

  12. waldhacker voted on patch set 7 V +1 CR +1 08/13/21, 13:19

  13. Paul H commented on patch set 7 CR -1 08/13/21, 14:07

    I think the empty title attributes need to be removed.
  14. waldhacker commented on patch set 8 08/13/21, 14:08

    Published edit on patch set 7.
  15. core-ci voted on patch set 8 V -1 08/13/21, 14:29 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14973

  16. Björn Jacob commented on patch set 9 08/13/21, 14:47

    Published edit on patch set 8.
  17. waldhacker rebased onto patch set 10 08/13/21, 14:55

  18. core-ci voted on patch set 9 V -1 08/13/21, 15:06 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14986

  19. waldhacker rebased onto patch set 11 08/13/21, 15:07

  20. core-ci voted on patch set 10 V -1 08/13/21, 15:14 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14987

  21. Paul H voted on patch set 11 V +1 CR +1 08/13/21, 15:19

  22. Björn Jacob voted on patch set 11 V +1 CR +1 08/13/21, 15:21

  23. core-ci voted on patch set 11 V +1 08/13/21, 15:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14990

  24. waldhacker voted on patch set 11 V +2 CR +2 08/13/21, 15:30

  25. waldhacker merged patch set 12 08/13/21, 15:30