Review main Merged

70452[FEATURE] Improve Usability in Workspaces module

Benni Mack CR +2 V +2 Hard +331 −345 updated 08/12/21, 13:17

Commit message

The workspaces module has a better style and some
improvements for editors and administrators:

* Editors now get feedback if an AJAX call shows no results
* Editors + Administrators now switch workspace via a selector,
  very helpful when having more than a couple of workspaces
* Administrators can now edit a workspace record
  directly from the module

The change cleans up a lot of unused code in the main workspaces
module and brings a few UX improvements within the module.

* Dropdowns instead of tabs (good when having a lot of workspaces)
* Language + Depth + Action selection is now rendered via
  Controller+Action instead of waiting for a first AJAX round trip
* Properly using "moduleData" from "uc" to store information
* Solved issues related to language icon rendering
* Removed unused inline settings
* Consistent usage of Persistent JS module accessing BE_Users' UC
* nProgress for showing progress of loading AJAX requests

Next steps in this area:
* Hand in the first payload as JSON to avoid AJAX call on
  initial page load
* Remove leftover inline JavaScript

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 1218

  1. Benni Mack uploaded patch set 1 08/11/21, 13:55

  2. core-ci voted on patch set 1 V +1 08/11/21, 14:20 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14600

  3. Benni Mack uploaded patch set 2 08/11/21, 18:31

  4. core-ci voted on patch set 2 V +1 08/11/21, 18:45 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14623

  5. Benni Mack uploaded patch set 3 08/11/21, 20:23

  6. Benni Mack uploaded patch set 4 08/11/21, 20:24

  7. core-ci voted on patch set 3 V +1 08/11/21, 20:46 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14637

  8. core-ci voted on patch set 4 V +1 08/11/21, 20:47 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14638

  9. Benni Mack uploaded patch set 5 08/11/21, 20:50

  10. core-ci voted on patch set 5 V +1 08/11/21, 21:06 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14642

  11. Christian Kuhn commented on patch set 5 CR -1 08/12/21, 12:09

    working on it.
  12. Christian Kuhn uploaded patch set 6 08/12/21, 12:47

  13. Christian Kuhn commented on patch set 6 V +1 CR +1 08/12/21, 12:47

    Backend.ts:371

    good catch.
  14. core-ci voted on patch set 6 V +1 08/12/21, 13:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14722

  15. Wouter Wolters voted on patch set 6 CR +1 08/12/21, 13:14

  16. Wouter Wolters voted on patch set 6 V +1 08/12/21, 13:16

  17. Christian Kuhn voted on patch set 6 V +2 CR +2 08/12/21, 13:17

  18. Christian Kuhn merged patch set 7 08/12/21, 13:17