Review main Merged

70456[BUGFIX] Rename class for vertical rule in access module

Oli Bartsch CR +2 V +2 Easy +8 −8 updated 08/12/21, 06:42

Commit message

Bootstrap 5.1.0, we updated to in #94752, introduced
a `.vr` (vertical rule) class. This collided with our
access module related styles, since we also use a `.vr`
class for the legend here. To resolve the collision, our
own implementation, which is only used in the access module,
is now prefixed with `t3`.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 2

Files 3

Review log 46

  1. Oli Bartsch uploaded patch set 1 08/11/21, 20:19

  2. Oli Bartsch updated the commit message in patch set 2 08/11/21, 20:21

  3. core-ci voted on patch set 1 V +1 08/11/21, 20:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14634

  4. core-ci voted on patch set 2 V +1 08/11/21, 20:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14635

  5. Georg Ringer commented on patch set 2 V +2 CR +2 08/12/21, 06:42

    merged as lowbrainer
  6. Georg Ringer merged patch set 3 08/12/21, 06:42