70460[BUGFIX] Ensure uncached forms in case of POST requests
Commit message
Review
-
Code review CR +2 Done
- waldhacker +2
- Oliver Hader +1
- Elias Häußler +1
-
Verified V +2 Done
- waldhacker +2
- Oliver Hader +1
- Elias Häußler +1
- core-ci +1 CI
Issues 2
Files 9
- typo3/sysext/form/Classes/Controller/FormFrontendController.php+9 −5
- typo3/sysext/form/Classes/Core/FormRequestHandler.php22new+244 −0
- typo3/sysext/form/Classes/Domain/Factory/FormFactoryInterface.php+1 −1
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php4+22 −26
- typo3/sysext/form/Classes/ViewHelpers/FormViewHelper.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/RenderViewHelper.php+17 −36
- typo3/sysext/form/Configuration/Services.yaml+3 −0
- typo3/sysext/form/Tests/Functional/RequestHandling/RequestHandlingTest.php+42 −54
- typo3/sysext/form/ext_localconf.php4+3 −1
Review log 115170
Show 94145 earlier messages
-
waldhacker uploaded patch set 1 08/12/21, 00:07
-
core-ci voted on patch set 1 V +1 08/12/21, 00:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14648
-
waldhacker uploaded patch set 2 08/12/21, 14:41
-
core-ci voted on patch set 2 V +1 08/12/21, 14:55 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14763
-
waldhacker rebased onto patch set 3 08/12/21, 15:07
-
waldhacker commented on patch set 3 08/12/21, 15:21
FYI: The ticket contains a little test extension which contains * extbase plugins which render forms (cached / uncached) * typoscript to add FLUIDTEMPLATE objects at the end of the page (cached / uncached) * ext:form overwrites to see hidden security fields -
core-ci voted on patch set 3 V +1 08/12/21, 15:27 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14774
-
Björn Jacob commented on patch set 3 CR -1 08/12/21, 15:27
Some improvements documentation-wise (spelling) needed 😊"when forms are""fluid template"Entrypoint.php:40Hard to read. Maybe better: "In order to render forms from fluid templates without a self-created extbase controller, the "integration entry point" is always the RenderViewHelper."Entrypoint.php:45"The additional data is then..."Entrypoint.php:49* The FormRuntime takes care of processing the form definition on * the basis of the FormSetup and renders the form or the finisher.Entrypoint.php:53Would write "CSRF".Entrypoint.php:55extbaseEntrypoint.php:57extbaseEntrypoint.php:59" * The Entrypoint converts the USER ContentObject into a USER_INT ContentObject"Entrypoint.php:61" * This INT_SCRIPT is processed by the TypoScriptFrontendController at"Entrypoint.php:73"* Finally, an extbase request is set up for the context to be rendered and the * form is rendered and output using the FormRuntime."Entrypoint.php:76extbaseEntrypoint.php:115"an" -> "a" (when speaking, there is no vocal at the beginning, more like a "ju").Entrypoint.php:115scriptEntrypoint.php:134"Setup"Entrypoint.php:142"Process"Entrypoint.php:157"Instantiate"Entrypoint.php:157"a"Entrypoint.php:167"Bootstrap"Entrypoint.php:171"Finally"FormRuntime.php:201"There"FormRuntime.php:206"There" -
waldhacker commented on patch set 4 08/12/21, 15:39
Published edit on patch set 3. -
waldhacker commented on patch set 4 08/12/21, 15:42
Reply
DoneReply
DoneEntrypoint.php:40ReplyDoneEntrypoint.php:45ReplyDoneEntrypoint.php:49ReplyDoneEntrypoint.php:53ReplyDoneEntrypoint.php:59ReplyDoneEntrypoint.php:61ReplyDoneEntrypoint.php:73ReplyDoneEntrypoint.php:115ReplyDoneEntrypoint.php:134ReplyDoneEntrypoint.php:142ReplyDoneEntrypoint.php:157ReplyDoneEntrypoint.php:167ReplyDoneEntrypoint.php:171ReplyDoneFormRuntime.php:201ReplyDoneFormRuntime.php:206ReplyDone -
waldhacker commented on patch set 5 08/12/21, 15:46
Published edit on patch set 4. -
waldhacker commented on patch set 5 08/12/21, 15:47
Entrypoint.php:55ReplyDoneEntrypoint.php:57ReplyDoneEntrypoint.php:76ReplyDoneEntrypoint.php:115ReplyDoneEntrypoint.php:157ReplyDone -
core-ci voted on patch set 4 V +1 08/12/21, 16:04 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14787
-
core-ci voted on patch set 5 V +1 08/12/21, 16:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14793
-
waldhacker updated the commit message in patch set 6 08/12/21, 17:31
-
core-ci voted on patch set 6 V +1 08/12/21, 17:45 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14812
-
waldhacker commented on patch set 7 08/12/21, 22:15
Published edit on patch set 6. -
core-ci voted on patch set 7 V +1 08/12/21, 22:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14864
-
waldhacker rebased onto patch set 8 08/12/21, 23:08
-
core-ci voted on patch set 8 V +1 08/12/21, 23:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14868
-
Mathias Brodala commented on patch set 9 08/13/21, 09:06
Published edit on patch set 8. -
Mathias Brodala commented on patch set 9 08/13/21, 09:07
Streamlined the entrypoint code (used more ??, grouped logical parts.) -
waldhacker commented on patch set 9 CR -1 08/13/21, 09:07
currently on it -
waldhacker commented on patch set 9 08/13/21, 09:09
Reply
the empty check is important because the properties are not null but empty string because of the user_int processing -
Mathias Brodala commented on patch set 9 V +1 08/13/21, 09:09
Entrypoint.php:83From the looks of it this should be moved to TYPO3\CMS\Form\ContentObject\FormUserObject. This would make the cObj context clearer. Also we can consider introducing an offical "FORM" TypoScript object later if desired. -
Mathias Brodala commented on patch set 9 08/13/21, 09:11
Reply
And here I am trying to make some sense. Thanks for catching this. -
core-ci voted on patch set 9 V +1 08/13/21, 09:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14904
-
waldhacker uploaded patch set 10 08/13/21, 09:41
-
core-ci voted on patch set 10 V +1 08/13/21, 10:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14914
-
waldhacker updated the commit message in patch set 11 08/13/21, 10:17
-
Mathias Brodala commented on patch set 11 08/13/21, 10:19
Entrypoint.php:84See my comment about this in PS9 -
waldhacker commented on patch set 11 08/13/21, 10:22
Entrypoint.php:84ReplyWouldn't moving to ext:frontend create a direct dependency on ext:form? -
waldhacker commented on patch set 11 08/13/21, 10:32
Discussions on the topic can be found here: https://typo3.slack.com/archives/C03AM9R17/p1628807266399400?thread_ts=1628796462.387800&cid=C03AM9R17 -
core-ci voted on patch set 11 V +1 08/13/21, 10:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14925
-
waldhacker commented on patch set 11 08/13/21, 11:02
A little summary: The patch does the following: * if you enable the honeypot for a form, ext:form ensures that the first unsubmitted form step is rendered uncached (only the cObj, not the whole page) <- prework for: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67642/25 / https://review.typo3.org/c/Packages/TYPO3.CMS/+/67656/ * if you disable the honeypot for a form, ext:form behaves like before (the first unsubmitted form step is rendered cached) except one further processing step by a USER cObj * since the form "bootstrap" is now always rendered via a USER cObj due to the refactoring of the viewhelper, regardless of whether the form is rendered via extbase with cached/uncached actions or a FLUIDTEMPLATE or a FLUIDTEMPLATE from a COA or COA_INT, the entry point can now determine for sure whether and how a form should be rendered (cached / uncached based on certain configuration parameters such as honeypot == enabled / POST = always uncached) <- fixes the regression from: https://forge.typo3.org/issues/93887 This is the current state of the patch -
waldhacker commented on patch set 11 08/13/21, 11:06
Reply
> can now determine for sure whether and how a form should be rendered can now determine (and control) for sure whether and how a form should be rendered -
waldhacker updated the commit message in patch set 12 08/13/21, 11:49
-
core-ci voted on patch set 12 V +1 08/13/21, 12:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14950
-
waldhacker commented on patch set 12 CR -1 08/13/21, 16:34
on it -
waldhacker uploaded patch set 13 08/13/21, 17:19
-
core-ci voted on patch set 13 V +1 08/13/21, 17:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15005
-
waldhacker uploaded patch set 14 08/13/21, 18:07
-
core-ci commented on patch set 14 08/13/21, 18:21 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15013
-
waldhacker voted on patch set 14 CR -1 08/13/21, 18:29
-
waldhacker uploaded patch set 15 08/13/21, 19:33
-
core-ci voted on patch set 15 V +1 08/13/21, 20:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15019
-
waldhacker updated the commit message in patch set 16 08/14/21, 08:55
-
core-ci voted on patch set 16 V +1 08/14/21, 09:09 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15040
-
Christian Kuhn commented on patch set 16 08/14/21, 12:03
When i submit form data, admin panel "Count of USER_INT objects" says "2", with patch applied. Without patch, that's "1". What's the reason for this? -
waldhacker uploaded patch set 17 08/14/21, 13:06
-
waldhacker updated the commit message in patch set 18 08/14/21, 13:10
-
waldhacker commented on patch set 18 08/14/21, 13:10
Reply
i'll take a look at this -
waldhacker rebased onto patch set 19 08/14/21, 13:13
-
core-ci voted on patch set 17 V +1 08/14/21, 13:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15074
-
core-ci voted on patch set 19 V +1 08/14/21, 13:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15079
-
core-ci voted on patch set 18 V +1 08/14/21, 13:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15078
-
waldhacker uploaded patch set 20 08/14/21, 14:03
-
waldhacker commented on patch set 20 08/14/21, 14:04
Reply
Now its "1" again -
core-ci voted on patch set 20 V +1 08/14/21, 14:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15083
-
waldhacker uploaded patch set 21 08/14/21, 15:57
-
core-ci commented on patch set 21 08/14/21, 16:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15091
-
waldhacker updated the commit message in patch set 22 08/14/21, 17:03
-
core-ci voted on patch set 22 V +1 08/14/21, 17:21 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15101
-
waldhacker rebased onto patch set 23 08/23/21, 20:44
-
core-ci voted on patch set 23 V +1 08/23/21, 20:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15467
-
Björn Jacob voted on patch set 23 V +1 CR +1 08/24/21, 07:36
-
Björn Jacob updated the commit message in patch set 24 09/02/21, 06:50
-
Björn Jacob voted on patch set 24 V +1 CR +1 09/02/21, 06:56
-
core-ci voted on patch set 24 V +1 09/02/21, 07:04 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16046
-
Andreas Häfner uploaded patch set 25 09/02/21, 09:10
-
Andreas Häfner voted on patch set 25 CR +1 09/02/21, 09:16
-
core-ci voted on patch set 25 V +1 09/02/21, 09:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16059
-
Björn Jacob voted on patch set 25 V +1 CR +1 09/02/21, 11:32
-
waldhacker uploaded patch set 26 10/22/21, 08:27
-
Oliver Hader commented on patch set 26 10/22/21, 08:28
Form.yaml:467Thus, the core would would deprecated functionality, correct? I'd prefer to either way: * either deprecate `perform` and avoid using it in core * or just keep it unmodified, and deprecate it in v12 The remark about "compatibility" probably is a good indicator, there should be a deprecation RST file as well - describing what developers have to change, and corresponding implications. -
core-ci voted on patch set 26 V +1 10/22/21, 08:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18418
-
Oliver Hader commented on patch set 26 V -1 CR -1 10/22/21, 15:18
Are there examples I can use to test a Fluid-based rendering? I just tested a plugin-based approach, which lead to forms not being processed anymore (since cache exists already), see screencast at https://forge.typo3.org/attachments/36493 * called directly /page-holding-plugin?tx_form_formframework%5Baction%5D=perform&tx_form_formframework%5Bcontroller%5D=FormFrontend&cHash=58366a8c711b178bc3d22b0165bf3b2c directly via GET * the same URI is used in `<form action="[that-URI]">` as POST request * however page cache does exist already The same happens when using the same URI path for both GET and POST requests - the "guessing" part would not work here. Instead, those actions should be explicit, which somehow contradicts the intention of this patch, to not separate between `render` and `perform` anymore in the controller layer. To have that functionally working with default TYPO3 page cache behavior, cache hash parameters need to support/distinguish between HTTP request method (which is not the case currently). See `$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['createHashBase']` in `TypoScriptFrontendController:: createHashBase` → that is defining the corresponding "cache-partition" based on an arbitrary request context. Besides that, requests are handled at multiple places, e.g. in `Entrypoint` as well as in `FormRuntime`. From an architectural point of view it would be nice to streamline the flow of this request - e.g. `RequestHandler` (deciding whether to cache or not) and then dispatching (explicitly) to underlying components and layers. -
waldhacker commented on patch set 26 10/22/21, 15:25
Reply
> Are there examples I can use to test a Fluid-based rendering? You can use / take a look in the provided test extension https://forge.typo3.org/issues/93887#note-17 -
waldhacker commented on patch set 26 10/22/21, 15:26
Reply
The attached testing extension contains: * extbase plugins which render forms (cached / uncached) * typoscript to add FLUIDTEMPLATE objects at the end of the page (cached / uncached) * ext:form overwrites to see hidden security fields -
Oliver Hader commented on patch set 26 10/22/21, 15:31
Reply
Screencast in better quality: https://forge.typo3.org/attachments/36494 -
Benni Mack wrote 11/29/21, 10:11
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 27 11/29/21, 13:31
-
core-ci voted on patch set 27 V +1 11/29/21, 14:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20042
-
waldhacker marked it work in progress 02/23/22, 08:18
-
Oliver Hader uploaded patch set 28 02/23/22, 17:02
-
Oliver Hader uploaded patch set 29 02/23/22, 17:08
-
core-ci voted on patch set 28 V -1 02/23/22, 17:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24132
-
core-ci voted on patch set 29 V -1 02/23/22, 17:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24133
-
waldhacker uploaded patch set 30 02/24/22, 10:49
-
core-ci voted on patch set 30 V -1 02/24/22, 11:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24178
-
Oliver Hader uploaded patch set 31 02/24/22, 11:54
-
core-ci voted on patch set 31 V -1 02/24/22, 12:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24186
-
Oliver Hader uploaded patch set 32 02/24/22, 17:54
-
core-ci voted on patch set 32 V -1 02/24/22, 18:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24212
-
Oliver Hader uploaded patch set 33 02/24/22, 18:20
-
core-ci voted on patch set 33 V +1 02/24/22, 18:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24217
-
Oliver Hader uploaded patch set 34 02/24/22, 19:27
-
core-ci voted on patch set 34 V +1 02/24/22, 19:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24226
-
waldhacker uploaded patch set 35 02/24/22, 21:41
-
core-ci voted on patch set 35 V +1 02/24/22, 21:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24236
-
waldhacker uploaded patch set 36 02/25/22, 01:51
-
core-ci voted on patch set 36 V -1 02/25/22, 01:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24251
-
waldhacker uploaded patch set 37 02/25/22, 07:58
-
core-ci voted on patch set 37 V -1 02/25/22, 08:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24254
-
waldhacker uploaded patch set 38 02/25/22, 09:34
-
core-ci voted on patch set 38 V +1 02/25/22, 09:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24255
-
Oliver Hader uploaded patch set 39 02/25/22, 16:38
-
Oliver Hader commented on patch set 39 02/25/22, 16:39
PS 39 is based on PS 34, adjusting the aspects that could not be addressed explicitly (e.g. since we cannot infer proper action names of custom Extbase controller actions). Test-cases are subject to be handled in a separate patch-set... -
core-ci voted on patch set 39 V -1 02/25/22, 16:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24296
-
waldhacker uploaded patch set 40 02/25/22, 17:15
-
Oliver Hader commented on patch set 40 02/25/22, 17:22
This change is ready for review. -
core-ci voted on patch set 40 V +1 02/25/22, 17:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24300
-
Oliver Hader commented on patch set 40 02/26/22, 09:08
→ Tests were extracted to https://review.typo3.org/c/Packages/TYPO3.CMS/+/73722 -
waldhacker uploaded patch set 41 02/26/22, 12:17
-
waldhacker uploaded patch set 42 02/26/22, 12:18
-
core-ci voted on patch set 42 V -1 02/26/22, 12:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24319
-
core-ci voted on patch set 41 V -1 02/26/22, 12:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24318
-
waldhacker commented on patch set 43 02/26/22, 12:34
Published edit on patch set 42. -
core-ci voted on patch set 43 V +1 02/26/22, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24320
-
Oliver Hader rebased onto patch set 44 02/26/22, 14:47
-
core-ci voted on patch set 44 V +1 02/26/22, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24330
-
Oliver Hader commented on patch set 44 V -1 02/26/22, 15:18
Unfortunately the behavior changed between https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460/40..43 again - bringing in the previous regression of directly calling the "perform-action" with GET request. Some remarks: * introducing honeypot handling is a good future enhancement * BUT: having honeypot enabled per default (which seems to be the case currently) makes all this effort here quite superfluous - actions could be uncached per default - and some simple request handler just ensures `$cObj->convertToUserIntObject` is called - without and constraints, alwaysFormRequestHandler.php:128This "request cleanup" does have any effect on caching. In case this request is not uncacheable (convertToUserIntObject), the problem I described months ago is back... * calling "perform-action" (copy from <form action=...>) once via GET * ... denies all future POST requests → no form processingFormRequestHandler.php:157even if it's `@internal` it should be `protected` from my POVFormRequestHandler.php:235it would be easier to just use `$formDefinition->bind($request);` like beforeext_localconf.php:58maybe add a comment here, that this is handled in request handler -
waldhacker commented on patch set 44 02/26/22, 15:26
Reply
Let me cover this with tests. After that, i will fix it. I remove the honeypot condition and we can handle it within the associated ticket.FormRequestHandler.php:128ReplyLet me cover this with tests. After that, i will fix it.FormRequestHandler.php:157ReplyAckFormRequestHandler.php:235ReplyAckext_localconf.php:58ReplyAck -
waldhacker uploaded patch set 45 02/26/22, 15:36
-
core-ci voted on patch set 45 V -1 02/26/22, 15:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24333
-
waldhacker uploaded patch set 46 02/26/22, 15:56
-
core-ci voted on patch set 46 V +1 02/26/22, 16:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24334
-
waldhacker uploaded patch set 47 02/26/22, 17:40
-
waldhacker commented on patch set 47 02/26/22, 17:44
FormRequestHandler.php:128ReplyDone -
core-ci voted on patch set 47 V +1 02/26/22, 17:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24335
-
waldhacker commented on patch set 47 04/28/22, 14:59
I have written tests for this patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73722/ -
Oliver Hader rebased onto patch set 48 06/30/22, 09:26
-
core-ci voted on patch set 48 V +1 06/30/22, 09:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28522
-
Oliver Hader commented on patch set 48 06/30/22, 13:00
FormRequestHandler.php:89maybe add key-name hintFormRequestHandler.php:130superfluous assignmentFormRequestHandler.php:155array-key type hints for param and return value e.g. `array{'factoryClass':?string, ...}` -
Oliver Hader commented on patch set 48 V +1 06/30/22, 13:09
Nice, worked in my scenarios. I was not able to reproduce previous behavior with GET/POST cached/non-cached overrides anymore. -
waldhacker uploaded patch set 49 06/30/22, 13:57
-
core-ci voted on patch set 49 V +1 06/30/22, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28535
-
waldhacker commented on patch set 49 07/01/22, 07:45
Reply
DoneReply
DoneEntrypoint.php:83ReplyDoneEntrypoint.php:84ReplyDoneForm.yaml:467ReplyDone -
Oliver Hader uploaded patch set 50 07/01/22, 08:17
-
Oliver Hader commented on patch set 50 07/01/22, 08:18
FormRequestHandler.php:89ReplyDoneFormRequestHandler.php:130ReplyDoneFormRequestHandler.php:155ReplyDone -
Oliver Hader voted on patch set 50 V +1 CR +1 07/01/22, 08:18
-
Björn Jacob updated the commit message in patch set 51 07/01/22, 08:20
-
Björn Jacob voted on patch set 51 V +1 CR +1 07/01/22, 08:23
-
core-ci voted on patch set 50 V +1 07/01/22, 08:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28549
-
core-ci voted on patch set 51 V +1 07/01/22, 08:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28550
-
Elias Häußler commented on patch set 51 07/01/22, 13:08
FormRequestHandler.php:55I'd suggest to mark this class `final` instead. What do you think? -
Elias Häußler uploaded patch set 52 07/01/22, 13:29
-
core-ci voted on patch set 52 V +1 07/01/22, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28575
-
Oliver Hader commented on patch set 52 07/01/22, 13:41
FormRequestHandler.php:55ReplyGood one! Since it is a new class, it does not have any implication on maybe-usages in older branches → `final` is is -
Oliver Hader commented on patch set 52 07/01/22, 13:43
FormRequestHandler.php:68I kept it without constructor property promotion - basically to ease back-ports... but fine like this, since it's just a matter of only a few minutes. -
Oliver Hader commented on patch set 52 07/01/22, 13:44
FormRequestHandler.php:55Reply*`final` it is -
Elias Häußler commented on patch set 52 07/01/22, 13:46
FormRequestHandler.php:65AFAICS the public property is only accessed prior to v11.5. Since #94956 the setter `setContentObjectRenderer()` is used. I'd suggest to drop the public property and add it to the 10.4 backport only. -
Elias Häußler uploaded patch set 53 07/01/22, 13:49
-
Elias Häußler commented on patch set 53 07/01/22, 13:50
FormRequestHandler.php:55ReplyAckFormRequestHandler.php:68ReplyAck -
Oliver Hader commented on patch set 53 07/01/22, 13:56
FormRequestHandler.php:65Reply👍 v11+v12: `setContentObjectRenderer(..)` - it even creates a deprecation warning in v11, and only `public $cObj` in v10 -
core-ci voted on patch set 53 V +1 07/01/22, 13:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28576
-
Elias Häußler uploaded patch set 54 07/01/22, 14:05
-
Elias Häußler commented on patch set 54 V +1 CR +1 07/01/22, 14:06
FormRequestHandler.php:65ReplyDone -
Oliver Hader voted on patch set 54 CR +1 07/01/22, 14:08
-
Elias Häußler commented on patch set 54 07/01/22, 14:09
ext_localconf.php:61One more thing 😄 This array could also be empty due to the `!empty()` check in `ExtensionUtility::configurePlugin()`, see https://github.com/TYPO3/typo3/blob/ef2a2d893da6cdab2fec61fb9493cb7bea828ae2/typo3/sysext/extbase/Classes/Utility/ExtensionUtility.php#L67. -
Oliver Hader voted on patch set 54 V +1 07/01/22, 14:13
-
core-ci voted on patch set 54 V +1 07/01/22, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28578
-
Oliver Hader commented on patch set 55 07/01/22, 14:53
Published edit on patch set 54. -
Oliver Hader commented on patch set 55 07/01/22, 14:54
ext_localconf.php:61ReplyDone -
Elias Häußler voted on patch set 55 V +1 CR +1 07/01/22, 14:56
-
Oliver Hader commented on patch set 55 V +1 CR +1 07/01/22, 14:56
Working on a v11 back-port right now... -
core-ci voted on patch set 55 V +1 07/01/22, 15:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28582
-
waldhacker voted on patch set 55 V +2 CR +2 07/02/22, 13:59
-
waldhacker merged patch set 56 07/02/22, 14:00
-
Christian Kuhn commented on patch set 56 11/20/22, 14:45
has been reverted with https://forge.typo3.org/issues/98336