Review main Merged

70460[BUGFIX] Ensure uncached forms in case of POST requests

waldhacker CR +2 V +2 Hard +342 −124 updated 11/20/22, 14:45

Commit message

A new `FormRequestHandler` has been introduced as entry point which
takes care of creating and rendering the actual `FormRuntime`.
Independent of the current application dispatcher (either the
default `FormFrontendController`, any custom Extbase controller
or a TypoScript `FLUIDTEMPLATE` cObject) any processing will
end up here.

To ensure proper caching, it is important to separate the two main
actions `render` and `perform`, which unfortunately cannot be resolved
easily, especially when using custom Extbase controller actions.
The term uncached refers to using cObject `USER_INT` instead of `USER`.

More details about the process flow are described in
`\TYPO3\CMS\Form\Core\FormRequestHandler`, introduced by this change.

Review

  • Code review CR +2 Done
    • waldhacker +2
    • Oliver Hader +1
    • Elias Häußler +1
  • Verified V +2 Done
    • waldhacker +2
    • Oliver Hader +1
    • Elias Häußler +1
    • core-ci +1 CI

Issues 2

Files 9

Review log 115170

Show 94145 earlier messages
  1. waldhacker uploaded patch set 1 08/12/21, 00:07

  2. core-ci voted on patch set 1 V +1 08/12/21, 00:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14648

  3. waldhacker uploaded patch set 2 08/12/21, 14:41

  4. core-ci voted on patch set 2 V +1 08/12/21, 14:55 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14763

  5. waldhacker rebased onto patch set 3 08/12/21, 15:07

  6. waldhacker commented on patch set 3 08/12/21, 15:21

    FYI: The ticket contains a little test extension which contains * extbase plugins which render forms (cached / uncached) * typoscript to add FLUIDTEMPLATE objects at the end of the page (cached / uncached) * ext:form overwrites to see hidden security fields
  7. core-ci voted on patch set 3 V +1 08/12/21, 15:27 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14774

  8. Björn Jacob commented on patch set 3 CR -1 08/12/21, 15:27

    Some improvements documentation-wise (spelling) needed 😊
    "when forms are"
    "fluid template"

    Entrypoint.php:40

    Hard to read. Maybe better: "In order to render forms from fluid templates without a self-created extbase controller, the "integration entry point" is always the RenderViewHelper."

    Entrypoint.php:45

    "The additional data is then..."

    Entrypoint.php:49

    * The FormRuntime takes care of processing the form definition on * the basis of the FormSetup and renders the form or the finisher.

    Entrypoint.php:53

    Would write "CSRF".

    Entrypoint.php:55

    extbase

    Entrypoint.php:57

    extbase

    Entrypoint.php:59

    " * The Entrypoint converts the USER ContentObject into a USER_INT ContentObject"

    Entrypoint.php:61

    " * This INT_SCRIPT is processed by the TypoScriptFrontendController at"

    Entrypoint.php:73

    "* Finally, an extbase request is set up for the context to be rendered and the * form is rendered and output using the FormRuntime."

    Entrypoint.php:76

    extbase

    Entrypoint.php:115

    "an" -> "a" (when speaking, there is no vocal at the beginning, more like a "ju").

    Entrypoint.php:115

    script

    Entrypoint.php:134

    "Setup"

    Entrypoint.php:142

    "Process"

    Entrypoint.php:157

    "Instantiate"

    Entrypoint.php:157

    "a"

    Entrypoint.php:167

    "Bootstrap"

    Entrypoint.php:171

    "Finally"

    FormRuntime.php:201

    "There"

    FormRuntime.php:206

    "There"
  9. waldhacker commented on patch set 4 08/12/21, 15:39

    Published edit on patch set 3.
  10. waldhacker commented on patch set 4 08/12/21, 15:42

    Reply

    Done

    Reply

    Done

    Entrypoint.php:40 Reply

    Done

    Entrypoint.php:45 Reply

    Done

    Entrypoint.php:49 Reply

    Done

    Entrypoint.php:53 Reply

    Done

    Entrypoint.php:59 Reply

    Done

    Entrypoint.php:61 Reply

    Done

    Entrypoint.php:73 Reply

    Done

    Entrypoint.php:115 Reply

    Done

    Entrypoint.php:134 Reply

    Done

    Entrypoint.php:142 Reply

    Done

    Entrypoint.php:157 Reply

    Done

    Entrypoint.php:167 Reply

    Done

    Entrypoint.php:171 Reply

    Done

    FormRuntime.php:201 Reply

    Done

    FormRuntime.php:206 Reply

    Done
  11. waldhacker commented on patch set 5 08/12/21, 15:46

    Published edit on patch set 4.
  12. waldhacker commented on patch set 5 08/12/21, 15:47

    Entrypoint.php:55 Reply

    Done

    Entrypoint.php:57 Reply

    Done

    Entrypoint.php:76 Reply

    Done

    Entrypoint.php:115 Reply

    Done

    Entrypoint.php:157 Reply

    Done
  13. core-ci voted on patch set 4 V +1 08/12/21, 16:04 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14787

  14. core-ci voted on patch set 5 V +1 08/12/21, 16:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14793

  15. waldhacker updated the commit message in patch set 6 08/12/21, 17:31

  16. core-ci voted on patch set 6 V +1 08/12/21, 17:45 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14812

  17. waldhacker commented on patch set 7 08/12/21, 22:15

    Published edit on patch set 6.
  18. core-ci voted on patch set 7 V +1 08/12/21, 22:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14864

  19. waldhacker rebased onto patch set 8 08/12/21, 23:08

  20. core-ci voted on patch set 8 V +1 08/12/21, 23:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14868

  21. Mathias Brodala commented on patch set 9 08/13/21, 09:06

    Published edit on patch set 8.
  22. Mathias Brodala commented on patch set 9 08/13/21, 09:07

    Streamlined the entrypoint code (used more ??, grouped logical parts.)
  23. waldhacker commented on patch set 9 CR -1 08/13/21, 09:07

    currently on it
  24. waldhacker commented on patch set 9 08/13/21, 09:09

    Reply

    the empty check is important because the properties are not null but empty string because of the user_int processing
  25. Mathias Brodala commented on patch set 9 V +1 08/13/21, 09:09

    Entrypoint.php:83

    From the looks of it this should be moved to TYPO3\CMS\Form\ContentObject\FormUserObject. This would make the cObj context clearer. Also we can consider introducing an offical "FORM" TypoScript object later if desired.
  26. Mathias Brodala commented on patch set 9 08/13/21, 09:11

    Reply

    And here I am trying to make some sense. Thanks for catching this.
  27. core-ci voted on patch set 9 V +1 08/13/21, 09:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14904

  28. waldhacker uploaded patch set 10 08/13/21, 09:41

  29. core-ci voted on patch set 10 V +1 08/13/21, 10:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14914

  30. waldhacker updated the commit message in patch set 11 08/13/21, 10:17

  31. Mathias Brodala commented on patch set 11 08/13/21, 10:19

    Entrypoint.php:84

    See my comment about this in PS9
  32. waldhacker commented on patch set 11 08/13/21, 10:22

    Entrypoint.php:84 Reply

    Wouldn't moving to ext:frontend create a direct dependency on ext:form?
  33. waldhacker commented on patch set 11 08/13/21, 10:32

  34. core-ci voted on patch set 11 V +1 08/13/21, 10:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14925

  35. waldhacker commented on patch set 11 08/13/21, 11:02

    A little summary: The patch does the following: * if you enable the honeypot for a form, ext:form ensures that the first unsubmitted form step is rendered uncached (only the cObj, not the whole page) <- prework for: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67642/25 / https://review.typo3.org/c/Packages/TYPO3.CMS/+/67656/ * if you disable the honeypot for a form, ext:form behaves like before (the first unsubmitted form step is rendered cached) except one further processing step by a USER cObj * since the form "bootstrap" is now always rendered via a USER cObj due to the refactoring of the viewhelper, regardless of whether the form is rendered via extbase with cached/uncached actions or a FLUIDTEMPLATE or a FLUIDTEMPLATE from a COA or COA_INT, the entry point can now determine for sure whether and how a form should be rendered (cached / uncached based on certain configuration parameters such as honeypot == enabled / POST = always uncached) <- fixes the regression from: https://forge.typo3.org/issues/93887 This is the current state of the patch
  36. waldhacker commented on patch set 11 08/13/21, 11:06

    Reply

    > can now determine for sure whether and how a form should be rendered can now determine (and control) for sure whether and how a form should be rendered
  37. waldhacker updated the commit message in patch set 12 08/13/21, 11:49

  38. core-ci voted on patch set 12 V +1 08/13/21, 12:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14950

  39. waldhacker commented on patch set 12 CR -1 08/13/21, 16:34

    on it
  40. waldhacker uploaded patch set 13 08/13/21, 17:19

  41. core-ci voted on patch set 13 V +1 08/13/21, 17:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15005

  42. waldhacker uploaded patch set 14 08/13/21, 18:07

  43. core-ci commented on patch set 14 08/13/21, 18:21 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15013

  44. waldhacker voted on patch set 14 CR -1 08/13/21, 18:29

  45. waldhacker uploaded patch set 15 08/13/21, 19:33

  46. core-ci voted on patch set 15 V +1 08/13/21, 20:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15019

  47. waldhacker updated the commit message in patch set 16 08/14/21, 08:55

  48. core-ci voted on patch set 16 V +1 08/14/21, 09:09 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15040

  49. Christian Kuhn commented on patch set 16 08/14/21, 12:03

    When i submit form data, admin panel "Count of USER_INT objects" says "2", with patch applied. Without patch, that's "1". What's the reason for this?
  50. waldhacker uploaded patch set 17 08/14/21, 13:06

  51. waldhacker updated the commit message in patch set 18 08/14/21, 13:10

  52. waldhacker commented on patch set 18 08/14/21, 13:10

    Reply

    i'll take a look at this
  53. waldhacker rebased onto patch set 19 08/14/21, 13:13

  54. core-ci voted on patch set 17 V +1 08/14/21, 13:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15074

  55. core-ci voted on patch set 19 V +1 08/14/21, 13:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15079

  56. core-ci voted on patch set 18 V +1 08/14/21, 13:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15078

  57. waldhacker uploaded patch set 20 08/14/21, 14:03

  58. waldhacker commented on patch set 20 08/14/21, 14:04

    Reply

    Now its "1" again
  59. core-ci voted on patch set 20 V +1 08/14/21, 14:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15083

  60. waldhacker uploaded patch set 21 08/14/21, 15:57

  61. core-ci commented on patch set 21 08/14/21, 16:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15091

  62. waldhacker updated the commit message in patch set 22 08/14/21, 17:03

  63. core-ci voted on patch set 22 V +1 08/14/21, 17:21 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15101

  64. waldhacker rebased onto patch set 23 08/23/21, 20:44

  65. core-ci voted on patch set 23 V +1 08/23/21, 20:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15467

  66. Björn Jacob voted on patch set 23 V +1 CR +1 08/24/21, 07:36

  67. Björn Jacob updated the commit message in patch set 24 09/02/21, 06:50

  68. Björn Jacob voted on patch set 24 V +1 CR +1 09/02/21, 06:56

  69. core-ci voted on patch set 24 V +1 09/02/21, 07:04 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16046

  70. Andreas Häfner uploaded patch set 25 09/02/21, 09:10

  71. Andreas Häfner voted on patch set 25 CR +1 09/02/21, 09:16

  72. core-ci voted on patch set 25 V +1 09/02/21, 09:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16059

  73. Björn Jacob voted on patch set 25 V +1 CR +1 09/02/21, 11:32

  74. waldhacker uploaded patch set 26 10/22/21, 08:27

  75. Oliver Hader commented on patch set 26 10/22/21, 08:28

    Form.yaml:467

    Thus, the core would would deprecated functionality, correct? I'd prefer to either way: * either deprecate `perform` and avoid using it in core * or just keep it unmodified, and deprecate it in v12 The remark about "compatibility" probably is a good indicator, there should be a deprecation RST file as well - describing what developers have to change, and corresponding implications.
  76. core-ci voted on patch set 26 V +1 10/22/21, 08:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18418

  77. Oliver Hader commented on patch set 26 V -1 CR -1 10/22/21, 15:18

    Are there examples I can use to test a Fluid-based rendering? I just tested a plugin-based approach, which lead to forms not being processed anymore (since cache exists already), see screencast at https://forge.typo3.org/attachments/36493 * called directly /page-holding-plugin?tx_form_formframework%5Baction%5D=perform&tx_form_formframework%5Bcontroller%5D=FormFrontend&cHash=58366a8c711b178bc3d22b0165bf3b2c directly via GET * the same URI is used in `<form action="[that-URI]">` as POST request * however page cache does exist already The same happens when using the same URI path for both GET and POST requests - the "guessing" part would not work here. Instead, those actions should be explicit, which somehow contradicts the intention of this patch, to not separate between `render` and `perform` anymore in the controller layer. To have that functionally working with default TYPO3 page cache behavior, cache hash parameters need to support/distinguish between HTTP request method (which is not the case currently). See `$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['createHashBase']` in `TypoScriptFrontendController:: createHashBase` → that is defining the corresponding "cache-partition" based on an arbitrary request context. Besides that, requests are handled at multiple places, e.g. in `Entrypoint` as well as in `FormRuntime`. From an architectural point of view it would be nice to streamline the flow of this request - e.g. `RequestHandler` (deciding whether to cache or not) and then dispatching (explicitly) to underlying components and layers.
  78. waldhacker commented on patch set 26 10/22/21, 15:25

    Reply

    > Are there examples I can use to test a Fluid-based rendering? You can use / take a look in the provided test extension https://forge.typo3.org/issues/93887#note-17
  79. waldhacker commented on patch set 26 10/22/21, 15:26

    Reply

    The attached testing extension contains: * extbase plugins which render forms (cached / uncached) * typoscript to add FLUIDTEMPLATE objects at the end of the page (cached / uncached) * ext:form overwrites to see hidden security fields
  80. Oliver Hader commented on patch set 26 10/22/21, 15:31

    Reply

    Screencast in better quality: https://forge.typo3.org/attachments/36494
  81. Benni Mack wrote 11/29/21, 10:11

    Change destination moved from master to main
  82. Benni Mack updated the commit message in patch set 27 11/29/21, 13:31

  83. core-ci voted on patch set 27 V +1 11/29/21, 14:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20042

  84. waldhacker marked it work in progress 02/23/22, 08:18

  85. Oliver Hader uploaded patch set 28 02/23/22, 17:02

  86. Oliver Hader uploaded patch set 29 02/23/22, 17:08

  87. core-ci voted on patch set 28 V -1 02/23/22, 17:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24132

  88. core-ci voted on patch set 29 V -1 02/23/22, 17:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24133

  89. waldhacker uploaded patch set 30 02/24/22, 10:49

  90. core-ci voted on patch set 30 V -1 02/24/22, 11:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24178

  91. Oliver Hader uploaded patch set 31 02/24/22, 11:54

  92. core-ci voted on patch set 31 V -1 02/24/22, 12:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24186

  93. Oliver Hader uploaded patch set 32 02/24/22, 17:54

  94. core-ci voted on patch set 32 V -1 02/24/22, 18:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24212

  95. Oliver Hader uploaded patch set 33 02/24/22, 18:20

  96. core-ci voted on patch set 33 V +1 02/24/22, 18:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24217

  97. Oliver Hader uploaded patch set 34 02/24/22, 19:27

  98. core-ci voted on patch set 34 V +1 02/24/22, 19:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24226

  99. waldhacker uploaded patch set 35 02/24/22, 21:41

  100. core-ci voted on patch set 35 V +1 02/24/22, 21:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24236

  101. waldhacker uploaded patch set 36 02/25/22, 01:51

  102. core-ci voted on patch set 36 V -1 02/25/22, 01:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24251

  103. waldhacker uploaded patch set 37 02/25/22, 07:58

  104. core-ci voted on patch set 37 V -1 02/25/22, 08:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24254

  105. waldhacker uploaded patch set 38 02/25/22, 09:34

  106. core-ci voted on patch set 38 V +1 02/25/22, 09:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24255

  107. Oliver Hader uploaded patch set 39 02/25/22, 16:38

  108. Oliver Hader commented on patch set 39 02/25/22, 16:39

    PS 39 is based on PS 34, adjusting the aspects that could not be addressed explicitly (e.g. since we cannot infer proper action names of custom Extbase controller actions). Test-cases are subject to be handled in a separate patch-set...
  109. core-ci voted on patch set 39 V -1 02/25/22, 16:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24296

  110. waldhacker uploaded patch set 40 02/25/22, 17:15

  111. Oliver Hader commented on patch set 40 02/25/22, 17:22

    This change is ready for review.
  112. core-ci voted on patch set 40 V +1 02/25/22, 17:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24300

  113. Oliver Hader commented on patch set 40 02/26/22, 09:08

  114. waldhacker uploaded patch set 41 02/26/22, 12:17

  115. waldhacker uploaded patch set 42 02/26/22, 12:18

  116. core-ci voted on patch set 42 V -1 02/26/22, 12:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24319

  117. core-ci voted on patch set 41 V -1 02/26/22, 12:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24318

  118. waldhacker commented on patch set 43 02/26/22, 12:34

    Published edit on patch set 42.
  119. core-ci voted on patch set 43 V +1 02/26/22, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24320

  120. Oliver Hader rebased onto patch set 44 02/26/22, 14:47

  121. core-ci voted on patch set 44 V +1 02/26/22, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24330

  122. Oliver Hader commented on patch set 44 V -1 02/26/22, 15:18

    Unfortunately the behavior changed between https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460/40..43 again - bringing in the previous regression of directly calling the "perform-action" with GET request. Some remarks: * introducing honeypot handling is a good future enhancement * BUT: having honeypot enabled per default (which seems to be the case currently) makes all this effort here quite superfluous - actions could be uncached per default - and some simple request handler just ensures `$cObj->convertToUserIntObject` is called - without and constraints, always

    FormRequestHandler.php:128

    This "request cleanup" does have any effect on caching. In case this request is not uncacheable (convertToUserIntObject), the problem I described months ago is back... * calling "perform-action" (copy from <form action=...>) once via GET * ... denies all future POST requests → no form processing

    FormRequestHandler.php:157

    even if it's `@internal` it should be `protected` from my POV

    FormRequestHandler.php:235

    it would be easier to just use `$formDefinition->bind($request);` like before

    ext_localconf.php:58

    maybe add a comment here, that this is handled in request handler
  123. waldhacker commented on patch set 44 02/26/22, 15:26

    Reply

    Let me cover this with tests. After that, i will fix it. I remove the honeypot condition and we can handle it within the associated ticket.

    FormRequestHandler.php:128 Reply

    Let me cover this with tests. After that, i will fix it.

    FormRequestHandler.php:157 Reply

    Ack

    FormRequestHandler.php:235 Reply

    Ack

    ext_localconf.php:58 Reply

    Ack
  124. waldhacker uploaded patch set 45 02/26/22, 15:36

  125. core-ci voted on patch set 45 V -1 02/26/22, 15:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24333

  126. waldhacker uploaded patch set 46 02/26/22, 15:56

  127. core-ci voted on patch set 46 V +1 02/26/22, 16:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24334

  128. waldhacker uploaded patch set 47 02/26/22, 17:40

  129. waldhacker commented on patch set 47 02/26/22, 17:44

    FormRequestHandler.php:128 Reply

    Done
  130. core-ci voted on patch set 47 V +1 02/26/22, 17:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24335

  131. waldhacker commented on patch set 47 04/28/22, 14:59

    I have written tests for this patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73722/
  132. Oliver Hader rebased onto patch set 48 06/30/22, 09:26

  133. core-ci voted on patch set 48 V +1 06/30/22, 09:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28522

  134. Oliver Hader commented on patch set 48 06/30/22, 13:00

    FormRequestHandler.php:89

    maybe add key-name hint

    FormRequestHandler.php:130

    superfluous assignment

    FormRequestHandler.php:155

    array-key type hints for param and return value e.g. `array{'factoryClass':?string, ...}`
  135. Oliver Hader commented on patch set 48 V +1 06/30/22, 13:09

    Nice, worked in my scenarios. I was not able to reproduce previous behavior with GET/POST cached/non-cached overrides anymore.
  136. waldhacker uploaded patch set 49 06/30/22, 13:57

  137. core-ci voted on patch set 49 V +1 06/30/22, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28535

  138. waldhacker commented on patch set 49 07/01/22, 07:45

    Reply

    Done

    Reply

    Done

    Entrypoint.php:83 Reply

    Done

    Entrypoint.php:84 Reply

    Done

    Form.yaml:467 Reply

    Done
  139. Oliver Hader uploaded patch set 50 07/01/22, 08:17

  140. Oliver Hader commented on patch set 50 07/01/22, 08:18

    FormRequestHandler.php:89 Reply

    Done

    FormRequestHandler.php:130 Reply

    Done

    FormRequestHandler.php:155 Reply

    Done
  141. Oliver Hader voted on patch set 50 V +1 CR +1 07/01/22, 08:18

  142. Björn Jacob updated the commit message in patch set 51 07/01/22, 08:20

  143. Björn Jacob voted on patch set 51 V +1 CR +1 07/01/22, 08:23

  144. core-ci voted on patch set 50 V +1 07/01/22, 08:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28549

  145. core-ci voted on patch set 51 V +1 07/01/22, 08:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28550

  1. Elias Häußler commented on patch set 51 07/01/22, 13:08

    FormRequestHandler.php:55

    I'd suggest to mark this class `final` instead. What do you think?
  2. Elias Häußler uploaded patch set 52 07/01/22, 13:29

  3. core-ci voted on patch set 52 V +1 07/01/22, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28575

  4. Oliver Hader commented on patch set 52 07/01/22, 13:41

    FormRequestHandler.php:55 Reply

    Good one! Since it is a new class, it does not have any implication on maybe-usages in older branches → `final` is is
  5. Oliver Hader commented on patch set 52 07/01/22, 13:43

    FormRequestHandler.php:68

    I kept it without constructor property promotion - basically to ease back-ports... but fine like this, since it's just a matter of only a few minutes.
  6. Oliver Hader commented on patch set 52 07/01/22, 13:44

    FormRequestHandler.php:55 Reply

    *`final` it is
  7. Elias Häußler commented on patch set 52 07/01/22, 13:46

    FormRequestHandler.php:65

    AFAICS the public property is only accessed prior to v11.5. Since #94956 the setter `setContentObjectRenderer()` is used. I'd suggest to drop the public property and add it to the 10.4 backport only.
  8. Elias Häußler uploaded patch set 53 07/01/22, 13:49

  9. Elias Häußler commented on patch set 53 07/01/22, 13:50

    FormRequestHandler.php:55 Reply

    Ack

    FormRequestHandler.php:68 Reply

    Ack
  10. Oliver Hader commented on patch set 53 07/01/22, 13:56

    FormRequestHandler.php:65 Reply

    👍 v11+v12: `setContentObjectRenderer(..)` - it even creates a deprecation warning in v11, and only `public $cObj` in v10
  11. core-ci voted on patch set 53 V +1 07/01/22, 13:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28576

  12. Elias Häußler uploaded patch set 54 07/01/22, 14:05

  13. Elias Häußler commented on patch set 54 V +1 CR +1 07/01/22, 14:06

    FormRequestHandler.php:65 Reply

    Done
  14. Oliver Hader voted on patch set 54 CR +1 07/01/22, 14:08

  15. Elias Häußler commented on patch set 54 07/01/22, 14:09

    ext_localconf.php:61

    One more thing 😄 This array could also be empty due to the `!empty()` check in `ExtensionUtility::configurePlugin()`, see https://github.com/TYPO3/typo3/blob/ef2a2d893da6cdab2fec61fb9493cb7bea828ae2/typo3/sysext/extbase/Classes/Utility/ExtensionUtility.php#L67.
  16. Oliver Hader voted on patch set 54 V +1 07/01/22, 14:13

  17. core-ci voted on patch set 54 V +1 07/01/22, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28578

  18. Oliver Hader commented on patch set 55 07/01/22, 14:53

    Published edit on patch set 54.
  19. Oliver Hader commented on patch set 55 07/01/22, 14:54

    ext_localconf.php:61 Reply

    Done
  20. Elias Häußler voted on patch set 55 V +1 CR +1 07/01/22, 14:56

  21. Oliver Hader commented on patch set 55 V +1 CR +1 07/01/22, 14:56

    Working on a v11 back-port right now...
  22. core-ci voted on patch set 55 V +1 07/01/22, 15:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28582

  23. waldhacker voted on patch set 55 V +2 CR +2 07/02/22, 13:59

  24. waldhacker merged patch set 56 07/02/22, 14:00

  25. Christian Kuhn commented on patch set 56 11/20/22, 14:45