70461[BUGFIX] Rebuild redirect cache after changing slug
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Tim Schreiner +1
-
Verified V +2 Done
- Benni Mack +2
- Tim Schreiner +1
- core-ci +1 CI
Issues 1
Files 1
Review log 89
-
Georg Ringer uploaded patch set 1 08/12/21, 06:31
-
Georg Ringer commented on patch set 1 08/12/21, 06:32
This change is ready for review. -
Tim Schreiner commented on patch set 1 V +1 CR +1 08/12/21, 06:39
Looks good. Have done this in a project the same way this patch works and it does the job. -
core-ci voted on patch set 1 V +1 08/12/21, 06:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14652
-
Benni Mack commented on patch set 1 08/12/21, 09:47
SlugService.php:128Unresolvedwhy not use DI here? the class is already autowired... makes it easier to add tests. -
Mathias Brodala commented on patch set 1 09/20/21, 07:20
IMO the redirect should be created using the DataHandler in the first place. Then the cache flush would be taken of automatically. -
Mathias Brodala commented on patch set 1 09/20/21, 07:22
Reply
I've created https://forge.typo3.org/issues/95272 for this. -
Benni Mack voted on patch set 1 V +2 CR +2 10/07/21, 14:10
-
Benni Mack merged patch set 2 10/07/21, 14:11