Review main Merged

70461[BUGFIX] Rebuild redirect cache after changing slug

Georg Ringer CR +2 V +2 Easy +1 −0 updated 10/07/21, 14:11

Commit message

If a slug is changed, the redirect cache must be rebuilt to make
the redirect actually work.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Tim Schreiner +1
  • Verified V +2 Done
    • Benni Mack +2
    • Tim Schreiner +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 89

  1. Georg Ringer uploaded patch set 1 08/12/21, 06:31

  2. Georg Ringer commented on patch set 1 08/12/21, 06:32

    This change is ready for review.
  3. Tim Schreiner commented on patch set 1 V +1 CR +1 08/12/21, 06:39

    Looks good. Have done this in a project the same way this patch works and it does the job.
  4. core-ci voted on patch set 1 V +1 08/12/21, 06:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14652

  5. Benni Mack commented on patch set 1 08/12/21, 09:47

    SlugService.php:128 Unresolved

    why not use DI here? the class is already autowired... makes it easier to add tests.
  6. Mathias Brodala commented on patch set 1 09/20/21, 07:20

    IMO the redirect should be created using the DataHandler in the first place. Then the cache flush would be taken of automatically.
  7. Mathias Brodala commented on patch set 1 09/20/21, 07:22

    Reply

  8. Benni Mack voted on patch set 1 V +2 CR +2 10/07/21, 14:10

  9. Benni Mack merged patch set 2 10/07/21, 14:11