Review main Merged

70465[BUGFIX] Include missing LL file in form flexform

Andreas Häfner CR +2 V +2 Easy +8 −1 updated 08/13/21, 09:53

Commit message

In patch #94429 inclusion of LL file has been removed accidentally.
To prevent multiple inclusion of LL-file in loop, incusion is done
in DataStructureIdentifierHook::__construct now.
Adds new constant for LLFile.

Review

  • Code review CR +2 Done
    • waldhacker +2
    • Wouter Wolters +1
    • Björn Jacob +1
    • Rudy Gnodde +1
  • Verified V +2 Done
    • waldhacker +2
    • Wouter Wolters +1
    • Björn Jacob +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1317

  1. Andreas Häfner uploaded patch set 1 08/12/21, 09:22

  2. Wouter Wolters commented on patch set 1 08/12/21, 09:28

    DataStructureIdentifierHook.php:55

    Why not use the constant here?
  3. Oli Bartsch commented on patch set 1 08/12/21, 09:31

    DataStructureIdentifierHook.php:55 Reply

    I assume because the constant contains a trailing `:`.
  4. Andreas Häfner updated the commit message in patch set 2 08/12/21, 09:37

  5. Andreas Häfner uploaded patch set 3 08/12/21, 09:38

  6. Wouter Wolters commented on patch set 2 08/12/21, 09:38

    DataStructureIdentifierHook.php:55 Reply

    Good point. I'm not awake yet 😋
  7. core-ci voted on patch set 1 V -1 08/12/21, 09:51 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14664

  8. core-ci voted on patch set 3 V -1 08/12/21, 10:08 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14670

  9. core-ci voted on patch set 2 V -1 08/12/21, 10:12 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14669

  10. Wouter Wolters uploaded patch set 4 08/12/21, 17:52

  11. Christian Kuhn commented on patch set 4 08/12/21, 18:03

    hmpf. my bad. thanks for the patch.
  12. core-ci voted on patch set 4 V +1 08/12/21, 18:09 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14819

  13. Wouter Wolters voted on patch set 4 V +1 CR +1 08/12/21, 18:34

  14. Björn Jacob commented on patch set 4 V +1 CR +1 08/12/21, 19:26

    Thanks for taking care and fixing the tests.
  15. Rudy Gnodde voted on patch set 4 CR +1 08/13/21, 09:43

  16. waldhacker voted on patch set 4 V +2 CR +2 08/13/21, 09:53

  17. waldhacker merged patch set 5 08/13/21, 09:53