Review main Merged

70480[TASK] Use Bootstrap's Cards instead of custom component

Christoph Schwob CR +2 V +2 Normal +51 −68 updated 08/24/21, 13:15

Commit message

Remove duplicate styles but some overrides for e.g. border already needed.
Changed class .card-content to .card-body
Add card-size-medium to card on ElementInformation to use some
empty space, cause there's only one card.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 1320

  1. Christoph Schwob uploaded patch set 1 08/12/21, 11:40

  2. core-ci voted on patch set 1 V +1 08/12/21, 11:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14710

  3. Nikita Hovratov commented on patch set 1 08/12/21, 12:04

    _card.scss:273

    I think this can be safely removed too, as it is the same as the default in line 253.
  4. Christoph Schwob uploaded patch set 2 08/12/21, 12:26

  5. core-ci voted on patch set 2 V -1 08/12/21, 12:49 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14720

  6. Christoph Schwob uploaded patch set 3 08/12/21, 12:49

  7. Christoph Schwob uploaded patch set 4 08/12/21, 12:53

  8. Nikita Hovratov voted on patch set 4 V +1 CR +1 08/12/21, 13:02

  9. Christoph Schwob commented on patch set 4 08/12/21, 13:04

    _card.scss:273 Reply

    Done
  10. core-ci voted on patch set 3 V -1 08/12/21, 13:09 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14723

  11. core-ci voted on patch set 4 V -1 08/12/21, 13:16 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14724

  12. Nikita Hovratov rebased onto patch set 5 08/12/21, 14:18

  13. core-ci voted on patch set 5 V +1 08/12/21, 14:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14757

  14. Nikita Hovratov uploaded patch set 6 08/20/21, 15:00

  15. core-ci voted on patch set 6 V +1 08/20/21, 15:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15329

  16. Benni Mack uploaded patch set 7 08/24/21, 12:51

  17. Benni Mack voted on patch set 7 V +1 CR +1 08/24/21, 12:52

  18. Oli Bartsch voted on patch set 7 V +2 CR +2 08/24/21, 13:04

  19. core-ci voted on patch set 7 V +1 08/24/21, 13:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15507

  20. Oli Bartsch merged patch set 8 08/24/21, 13:15