70481[FEATURE] Add allowDashCharacters option to slug field configuration
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 3
Review log 2741
Show 916 earlier messages
-
Stefan Bürk uploaded patch set 1 08/12/21, 11:45
-
core-ci voted on patch set 1 V -1 08/12/21, 12:05 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14711
-
core-ci commented on patch set 1 08/12/21, 12:45 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14711
-
Christine Zoglmeier commented on patch set 1 V +1 08/12/21, 13:01
Slug generation was tested successfully with the new TCA configuration. -
Stefan Bürk rebased onto patch set 2 08/12/21, 13:38
-
core-ci voted on patch set 1 V +1 08/12/21, 14:02 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14711
-
core-ci voted on patch set 2 V -1 08/12/21, 14:13 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14738
-
Stefan Bürk rebased onto patch set 3 08/12/21, 20:20
-
core-ci voted on patch set 3 V +1 08/12/21, 20:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14847
-
Lina Wolf commented on patch set 3 08/14/21, 07:58
Feature-94162-AllowDashAndLowdashInSlugGenerationAllowDashCharacters.rst:12duplicate slug here -
Stefan Bürk uploaded patch set 4 08/14/21, 10:05
-
Stefan Bürk commented on patch set 4 08/14/21, 10:06
Feature-94162-AllowDashAndLowdashInSlugGenerationAllowDashCharacters.rst:12Replydone -
core-ci voted on patch set 4 V +1 08/14/21, 10:19 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15051
-
Stefan Bürk rebased onto patch set 5 08/19/21, 16:47
-
core-ci voted on patch set 5 V +1 08/19/21, 17:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15311
-
Stefan Bürk rebased onto patch set 6 08/23/21, 17:09
-
core-ci voted on patch set 6 V +1 08/23/21, 17:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15428
-
Simon Schaufelberger commented on patch set 6 08/24/21, 19:35
SlugHelperTest.php:176unused variable -
Stefan Bürk uploaded patch set 7 08/24/21, 20:31
-
Stefan Bürk commented on patch set 7 08/24/21, 20:32
SlugHelperTest.php:176ReplyDebug breakpint. Removed -
core-ci voted on patch set 7 V +1 08/24/21, 20:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15534
-
Simon Schaufelberger commented on patch set 7 CR +1 08/25/21, 10:52
Code looks good to me, didn't test -
Markus Timtner commented on patch set 7 V +1 CR +1 08/25/21, 14:50
Hi there, Seems to work as intended. Thank you for this! -
Jonas Eberle commented on patch set 7 08/31/21, 08:05
Sorry for being so late, but I have a general suggestion: This seems to arbitrarily treat $dash characters. What about a more generic $allowCharacters => ['-', '_']? Actually the SlugHelper API would profit IMHO if it would be rebuilt into using (language-aware) $replacements for all characters so I would be a bit hesitant to adding new features now? I don't know if there are any plans.SlugHelper.php:117The escaping `\` is (also was) not needed for `-` in a character class. The comment above is IMHO not correct any more. IMHO this function is getting much less readable. I suggest splitting into smaller logical chunks in such a vital part. -
Jonas Eberle commented on patch set 7 09/06/21, 16:11
SlugHelper.php:117ReplyThat first comment was not correct. Of course '-' needs escaping in a character class. -
Sybille Peters commented on patch set 7 10/15/21, 13:28
Feature-94162-AllowDashAndLowdashInSlugGenerationAllowDashCharacters.rst:12Unresolvedsuggestion: "Add configuration option `allowDashCharacters`" to type `slug` in TCA". This way you have more context later and get hits when searching for TCA (not sure if the index is currently used in search). -
Jonas Eberle commented on patch set 7 10/15/21, 13:54
SlugHelper.php:117ReplyDone -
Oli Bartsch uploaded patch set 8 11/19/21, 13:32
-
core-ci voted on patch set 8 V -1 11/19/21, 13:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19560
-
Stefan Bürk uploaded patch set 9 11/19/21, 13:41
-
core-ci voted on patch set 9 V +1 11/19/21, 13:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19563
-
Stefan Bürk rebased onto patch set 10 11/25/21, 19:31
-
core-ci voted on patch set 10 V +1 11/25/21, 19:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19759
-
Benni Mack wrote 11/29/21, 10:20
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 11 11/29/21, 14:10
-
core-ci voted on patch set 11 V +1 11/29/21, 18:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20116
-
Stefan Bürk rebased onto patch set 12 06/11/22, 15:24
-
core-ci voted on patch set 12 V -1 06/11/22, 15:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27978
-
Chris Müller commented on patch set 12 06/11/22, 15:52
Feature-94162-AllowDashAndLowdashInSlugGenerationAllowDashCharacters.rst:12"low dashes (underscores)" Had to look up "low dash" also I could imagine what it means;-)Feature-94162-AllowDashAndLowdashInSlugGenerationAllowDashCharacters.rst:19UnresolvedHere too, without "-" -
Oliver Klee commented on patch set 12 06/11/22, 16:19
Feature-94162-AllowDashAndLowdashInSlugGenerationAllowDashCharacters.rst:12Reply UnresolvedI'd propose to use the term "underscore" only (as this is AFAIK the most common term for this). -
Stefan Bürk abandoned the change 07/07/22, 21:27