Review main Merged

70482[BUGFIX] Optimize JavaScript implementation of new functionality

Benni Mack CR +2 V +2 Easy +24 −20 updated 09/15/21, 21:41

Commit message

This change
* removes an unneeded CSS class from all tree items, making the DOM
  smaller
* adds passive listeners for touch events in Resizables. This
  way browsers do not complain anymore

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1622

  1. Benni Mack uploaded patch set 1 08/12/21, 11:54

  2. core-ci voted on patch set 1 V -1 08/12/21, 12:17 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14712

  3. Benni Mack uploaded patch set 2 08/12/21, 14:08

  4. core-ci voted on patch set 2 V -1 08/12/21, 14:42 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14753

  5. Benni Mack rebased onto patch set 3 08/13/21, 10:13

  6. core-ci voted on patch set 3 V -1 08/13/21, 10:39 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14923

  7. Benni Mack uploaded patch set 4 08/13/21, 19:55

  8. core-ci voted on patch set 4 V +1 08/13/21, 20:11 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15022

  9. Tymoteusz Motylewski commented on patch set 4 08/14/21, 12:14

    SvgTree.ts:799

    seems safe, as getNodeClass returns the same value as one stored in element id. But what about the this.getNodeClass method? its not used any more then. Should we remove it? or maybe keep it here and change the getNodeClass function body to return 'node' (this allows other trees which inherits from SvgTree to style the tree in the way they want).
  10. Tymoteusz Motylewski commented on patch set 4 08/14/21, 12:19

    there is also one place in Testing Framework to change (in the comment, so can be fixed separately) testing_framework/Classes/Core/Acceptance/Step/FrameSteps.php line 93
  11. Benni Mack commented on patch set 4 08/23/21, 15:54

    Reply

    thx. will take care once this is merged.

    SvgTree.ts:799 Reply Unresolved

    I think the customization of tree can be achieved by custom CSS classes as we already do with "class" (we highlight custom areas in the page tree with this logic already").
  12. Anja Leichsenring voted on patch set 4 V +1 08/23/21, 16:50

  13. Wouter Wolters voted on patch set 4 CR +1 08/23/21, 18:25

  14. Benni Mack uploaded patch set 5 08/24/21, 11:45

  15. core-ci voted on patch set 5 V +1 08/24/21, 12:02 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15496

  16. Benni Mack uploaded patch set 6 08/25/21, 21:44

  17. core-ci voted on patch set 6 V +1 08/25/21, 21:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15631

  18. Oliver Hader voted on patch set 6 CR +1 09/15/21, 09:17

  19. Oliver Hader commented on patch set 6 V +1 09/15/21, 09:24

    Tested Chrome, Safari, Edge
  20. Oli Bartsch voted on patch set 6 V +1 CR +1 09/15/21, 16:20

  21. Oli Bartsch voted on patch set 6 V +2 CR +2 09/15/21, 21:41

  22. Oli Bartsch merged patch set 7 09/15/21, 21:41