70482[BUGFIX] Optimize JavaScript implementation of new functionality
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Oliver Hader +1
-
Verified V +2 Done
- Oli Bartsch +2
- Oliver Hader +1
- core-ci +1 CI
Issues 1
Files 8
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Viewport/ResizableNavigation.ts+13 −5
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/SvgTree.ts2+1 −5
- typo3/sysext/backend/Resources/Public/JavaScript/Viewport/ResizableNavigation.js+4 −4
- typo3/sysext/backend/Resources/Public/JavaScript/SvgTree.js+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/CategoryTreeCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/Impexp/ExportCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/Impexp/UsersCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/Page/AddPageInPageModuleCest.php+1 −1
Review log 1622
-
Benni Mack uploaded patch set 1 08/12/21, 11:54
-
core-ci voted on patch set 1 V -1 08/12/21, 12:17 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14712
-
Benni Mack uploaded patch set 2 08/12/21, 14:08
-
core-ci voted on patch set 2 V -1 08/12/21, 14:42 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14753
-
Benni Mack rebased onto patch set 3 08/13/21, 10:13
-
core-ci voted on patch set 3 V -1 08/13/21, 10:39 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14923
-
Benni Mack uploaded patch set 4 08/13/21, 19:55
-
core-ci voted on patch set 4 V +1 08/13/21, 20:11 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15022
-
Tymoteusz Motylewski commented on patch set 4 08/14/21, 12:14
-
Tymoteusz Motylewski commented on patch set 4 08/14/21, 12:19
there is also one place in Testing Framework to change (in the comment, so can be fixed separately) testing_framework/Classes/Core/Acceptance/Step/FrameSteps.php line 93 -
Benni Mack commented on patch set 4 08/23/21, 15:54
Reply
thx. will take care once this is merged.SvgTree.ts:799Reply UnresolvedI think the customization of tree can be achieved by custom CSS classes as we already do with "class" (we highlight custom areas in the page tree with this logic already"). -
Anja Leichsenring voted on patch set 4 V +1 08/23/21, 16:50
-
Wouter Wolters voted on patch set 4 CR +1 08/23/21, 18:25
-
Benni Mack uploaded patch set 5 08/24/21, 11:45
-
core-ci voted on patch set 5 V +1 08/24/21, 12:02 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15496
-
Benni Mack uploaded patch set 6 08/25/21, 21:44
-
core-ci voted on patch set 6 V +1 08/25/21, 21:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15631
-
Oliver Hader voted on patch set 6 CR +1 09/15/21, 09:17
-
Oliver Hader commented on patch set 6 V +1 09/15/21, 09:24
Tested Chrome, Safari, Edge -
Oli Bartsch voted on patch set 6 V +1 CR +1 09/15/21, 16:20
-
Oli Bartsch voted on patch set 6 V +2 CR +2 09/15/21, 21:41
-
Oli Bartsch merged patch set 7 09/15/21, 21:41
SvgTree.ts:799