Review main Merged

70485[BUGFIX] Fix "View" button on pages with doktype > 200

Łukasz Uznański CR +2 V +2 Easy +22 −4 updated 10/13/21, 12:13

Commit message

When editing a content element on a page with doktype > 200
the view button will not render this page
in the frontend. This patch fixes this issue

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 2025

  1. Łukasz Uznański uploaded patch set 1 08/12/21, 12:15

  2. Oli Bartsch commented on patch set 1 08/12/21, 12:28

    EditDocumentController.php:947

    Have you considered that with this change it's not longer possible for devs to avoid the "view" link for their custom doktyes?
  3. core-ci voted on patch set 1 V +1 08/12/21, 12:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14717

  4. Łukasz Uznański commented on patch set 1 08/12/21, 13:17

    EditDocumentController.php:947 Reply

    good point, I will take it into account
  5. Łukasz Uznański commented on patch set 1 08/12/21, 14:21

    EditDocumentController.php:947 Reply

    Ok, looks like it's not a way to avoid "view" link, as it's visible anyway for other doktypes, but right now, URL which is generated for doktypes above 199 is not valid. This patch fixes URL for view link.
  6. Oli Bartsch commented on patch set 1 08/12/21, 14:36

    EditDocumentController.php:947 Reply

    Ack
  7. kharaf voted on patch set 1 V +1 CR +1 08/12/21, 15:00

  8. Mathias Brodala commented on patch set 1 08/13/21, 07:01

    EditDocumentController.php:950

    Until we decide how to proceed in general I'd recommend to move this at least to a method "canViewDoktype()" on this class. Then the comment above can be dropped since the code explains itself.
  9. Oli Bartsch commented on patch set 1 08/13/21, 07:47

    We might also think of the `web_list.noViewWithDokTypes` TSconfig. However this is a recordlist specific config currently.
  10. Łukasz Uznański rebased onto patch set 2 08/13/21, 07:59

  11. core-ci voted on patch set 2 V +1 08/13/21, 08:19 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14891

  12. Łukasz Uznański uploaded patch set 3 08/13/21, 10:47

  13. core-ci voted on patch set 3 V +1 08/13/21, 11:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14934

  14. Mathias Brodala voted on patch set 3 CR +1 08/13/21, 12:24

  15. kharaf voted on patch set 3 V +1 CR +1 08/13/21, 13:08

  16. Łukasz Uznański rebased onto patch set 4 08/13/21, 14:22

  17. core-ci voted on patch set 4 V +1 08/13/21, 14:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14977

  18. Benni Mack commented on patch set 4 CR +1 10/08/21, 08:14

    EditDocumentController.php:950 Reply

    Ack
  19. Guido Schmechel voted on patch set 4 CR +1 10/09/21, 12:03

  20. Oli Bartsch uploaded patch set 5 10/13/21, 11:31

  21. Oli Bartsch voted on patch set 5 V +1 CR +1 10/13/21, 11:32

  22. Benni Mack voted on patch set 5 V +1 CR +1 10/13/21, 12:00

  23. core-ci voted on patch set 5 V +1 10/13/21, 12:02 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18031

  24. Oli Bartsch voted on patch set 5 V +2 CR +2 10/13/21, 12:13

  25. Oli Bartsch merged patch set 6 10/13/21, 12:13