70485[BUGFIX] Fix "View" button on pages with doktype > 200
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2025
-
Łukasz Uznański uploaded patch set 1 08/12/21, 12:15
-
Oli Bartsch commented on patch set 1 08/12/21, 12:28
-
core-ci voted on patch set 1 V +1 08/12/21, 12:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14717
-
Łukasz Uznański commented on patch set 1 08/12/21, 13:17
EditDocumentController.php:947Replygood point, I will take it into account -
Łukasz Uznański commented on patch set 1 08/12/21, 14:21
EditDocumentController.php:947ReplyOk, looks like it's not a way to avoid "view" link, as it's visible anyway for other doktypes, but right now, URL which is generated for doktypes above 199 is not valid. This patch fixes URL for view link. -
Oli Bartsch commented on patch set 1 08/12/21, 14:36
EditDocumentController.php:947ReplyAck -
kharaf voted on patch set 1 V +1 CR +1 08/12/21, 15:00
-
Mathias Brodala commented on patch set 1 08/13/21, 07:01
EditDocumentController.php:950Until we decide how to proceed in general I'd recommend to move this at least to a method "canViewDoktype()" on this class. Then the comment above can be dropped since the code explains itself. -
Oli Bartsch commented on patch set 1 08/13/21, 07:47
We might also think of the `web_list.noViewWithDokTypes` TSconfig. However this is a recordlist specific config currently. -
Łukasz Uznański rebased onto patch set 2 08/13/21, 07:59
-
core-ci voted on patch set 2 V +1 08/13/21, 08:19 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14891
-
Łukasz Uznański uploaded patch set 3 08/13/21, 10:47
-
core-ci voted on patch set 3 V +1 08/13/21, 11:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14934
-
Mathias Brodala voted on patch set 3 CR +1 08/13/21, 12:24
-
kharaf voted on patch set 3 V +1 CR +1 08/13/21, 13:08
-
Łukasz Uznański rebased onto patch set 4 08/13/21, 14:22
-
core-ci voted on patch set 4 V +1 08/13/21, 14:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14977
-
Benni Mack commented on patch set 4 CR +1 10/08/21, 08:14
EditDocumentController.php:950ReplyAck -
Guido Schmechel voted on patch set 4 CR +1 10/09/21, 12:03
-
Oli Bartsch uploaded patch set 5 10/13/21, 11:31
-
Oli Bartsch voted on patch set 5 V +1 CR +1 10/13/21, 11:32
-
Benni Mack voted on patch set 5 V +1 CR +1 10/13/21, 12:00
-
core-ci voted on patch set 5 V +1 10/13/21, 12:02 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18031
-
Oli Bartsch voted on patch set 5 V +2 CR +2 10/13/21, 12:13
-
Oli Bartsch merged patch set 6 10/13/21, 12:13
EditDocumentController.php:947