70487[TASK] Relax some errors for SQLite
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 7
- Build/Sources/TypeScript/install/module/maintenance/database-analyzer.ts+1 −1
- typo3/sysext/core/Classes/Database/Schema/ConnectionMigrator.php+3 −3
- typo3/sysext/core/Classes/Database/Schema/MigratorResult.phpnew+104 −0
- typo3/sysext/core/Classes/Database/Schema/SchemaMigrator.php+7 −6
- typo3/sysext/install/Classes/Controller/InstallerController.php+8 −6
- typo3/sysext/install/Classes/Controller/MaintenanceController.php+8 −6
- typo3/sysext/install/Resources/Public/JavaScript/module/maintenance/database-analyzer.js+1 −1
Review log 2337
Show 612 earlier messages
-
Simon Gilli uploaded patch set 1 08/12/21, 13:32
-
Simon Gilli uploaded patch set 2 08/12/21, 13:37
-
Simon Gilli updated the commit message in patch set 3 08/12/21, 13:39
-
Simon Gilli uploaded patch set 4 08/12/21, 13:40
-
core-ci voted on patch set 4 V -1 08/12/21, 13:51 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14740
-
core-ci voted on patch set 1 V -1 08/12/21, 13:52 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14734
-
core-ci voted on patch set 2 V -1 08/12/21, 13:54 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14737
-
Simon Gilli uploaded patch set 5 08/12/21, 13:56
-
core-ci voted on patch set 3 V -1 08/12/21, 14:01 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14739
-
core-ci voted on patch set 5 V -1 08/12/21, 14:19 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14746
-
Simon Gilli uploaded patch set 6 08/12/21, 15:50
-
core-ci voted on patch set 6 V -1 08/12/21, 15:57 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14794
-
Simon Gilli uploaded patch set 7 08/12/21, 15:58
-
core-ci voted on patch set 7 V -1 08/12/21, 16:31 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14802
-
core-ci commented on patch set 7 08/12/21, 18:37 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14802
-
Simon Gilli rebased onto patch set 8 08/12/21, 18:40
-
Simon Gilli uploaded patch set 9 08/12/21, 18:56
-
core-ci voted on patch set 8 V -1 08/12/21, 18:59 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14830
-
core-ci voted on patch set 9 V +1 08/12/21, 19:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14833
-
Daniel Siepmann commented on patch set 9 V +1 08/17/21, 10:29
Tested with sqlite on a real world instance. Didn't test against other dbms like MySQL. -
Simon Gilli commented on patch set 9 08/18/21, 15:08
Reply
Thanks. Other should realy not be affected see https://review.typo3.org/c/Packages/TYPO3.CMS/+/70487/9/typo3/sysext/core/Classes/Database/Schema/MigratorResult.php#90 -
crell commented on patch set 9 08/25/21, 14:02
The code looks reasonable, but I'd like to see a docblock on the new class that explains why "hide errors and try again" is the correct strategy, as that's rather weird and disturbing without context. (Or, if that already exists in the code, a @see or @link to such an explanation.) -
Simon Gilli commented on patch set 10 09/16/21, 17:32
Published edit on patch set 9. -
Simon Gilli commented on patch set 10 09/16/21, 17:33
Reply
I've added a description to the class. Hopefully its better understandable now. -
core-ci voted on patch set 10 V -1 09/16/21, 17:56 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16825
-
Benni Mack rebased onto patch set 11 09/23/21, 08:40
-
core-ci voted on patch set 11 V +1 09/23/21, 08:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17096
-
Benni Mack wrote 11/29/21, 10:08
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 12 11/29/21, 13:28
-
core-ci voted on patch set 12 V +1 11/29/21, 17:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20036
-
Simon Schaufelberger uploaded patch set 13 03/22/22, 23:12
-
core-ci voted on patch set 13 V -1 03/22/22, 23:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25062
-
Oliver Klee commented on patch set 13 07/14/23, 12:03
Simon, would you be willing to rebase/update this PR and fix the PHPStan warning? -
Simon Schaufelberger commented on patch set 13 07/16/23, 11:05
Reply Unresolved
if you mean me, I can do that in a few weeks. -
Christian Kuhn commented on patch set 13 08/06/24, 14:55
hey. we've had quite a few changes in this area, and the patch has lots of merge conflicts right now. i think it would be good to restart a fresh patch in case this is still an issue. i hope it is ok to abandon here for now. -
Christian Kuhn abandoned the change 08/06/24, 14:55
-
Oliver Klee wrote 08/06/24, 15:02
Removed cc Oliver Klee.