Review main Abandoned

70487[TASK] Relax some errors for SQLite

Simon Gilli CR 0 V 0 Normal +132 −23 updated 08/06/24, 15:02

Commit message

SQLite shows some errors during the database migration which will be
resolved automatically on the next run. These errors are converted to
warnings and an additional hint about the possible resolvent on the
next run is shown so these errors are less confusing for the system
administrators.

This patch also increases the showing duration for the FlashMessages
of the database migration from 5 to 10 seconds so the administrator
has a chance to read the messages.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 7

Review log 2337

Show 612 earlier messages
  1. Simon Gilli uploaded patch set 1 08/12/21, 13:32

  2. Simon Gilli uploaded patch set 2 08/12/21, 13:37

  3. Simon Gilli updated the commit message in patch set 3 08/12/21, 13:39

  4. Simon Gilli uploaded patch set 4 08/12/21, 13:40

  5. core-ci voted on patch set 4 V -1 08/12/21, 13:51 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14740

  6. core-ci voted on patch set 1 V -1 08/12/21, 13:52 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14734

  7. core-ci voted on patch set 2 V -1 08/12/21, 13:54 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14737

  8. Simon Gilli uploaded patch set 5 08/12/21, 13:56

  9. core-ci voted on patch set 3 V -1 08/12/21, 14:01 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14739

  10. core-ci voted on patch set 5 V -1 08/12/21, 14:19 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14746

  11. Simon Gilli uploaded patch set 6 08/12/21, 15:50

  12. core-ci voted on patch set 6 V -1 08/12/21, 15:57 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14794

  1. Simon Gilli uploaded patch set 7 08/12/21, 15:58

  2. core-ci voted on patch set 7 V -1 08/12/21, 16:31 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14802

  3. core-ci commented on patch set 7 08/12/21, 18:37 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14802

  4. Simon Gilli rebased onto patch set 8 08/12/21, 18:40

  5. Simon Gilli uploaded patch set 9 08/12/21, 18:56

  6. core-ci voted on patch set 8 V -1 08/12/21, 18:59 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14830

  7. core-ci voted on patch set 9 V +1 08/12/21, 19:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14833

  8. Daniel Siepmann commented on patch set 9 V +1 08/17/21, 10:29

    Tested with sqlite on a real world instance. Didn't test against other dbms like MySQL.
  9. Simon Gilli commented on patch set 9 08/18/21, 15:08

  10. crell commented on patch set 9 08/25/21, 14:02

    The code looks reasonable, but I'd like to see a docblock on the new class that explains why "hide errors and try again" is the correct strategy, as that's rather weird and disturbing without context. (Or, if that already exists in the code, a @see or @link to such an explanation.)
  11. Simon Gilli commented on patch set 10 09/16/21, 17:32

    Published edit on patch set 9.
  12. Simon Gilli commented on patch set 10 09/16/21, 17:33

    Reply

    I've added a description to the class. Hopefully its better understandable now.
  13. core-ci voted on patch set 10 V -1 09/16/21, 17:56 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16825

  14. Benni Mack rebased onto patch set 11 09/23/21, 08:40

  15. core-ci voted on patch set 11 V +1 09/23/21, 08:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17096

  16. Benni Mack wrote 11/29/21, 10:08

    Change destination moved from master to main
  17. Benni Mack updated the commit message in patch set 12 11/29/21, 13:28

  18. core-ci voted on patch set 12 V +1 11/29/21, 17:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20036

  19. Simon Schaufelberger uploaded patch set 13 03/22/22, 23:12

  20. core-ci voted on patch set 13 V -1 03/22/22, 23:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25062

  21. Oliver Klee commented on patch set 13 07/14/23, 12:03

    Simon, would you be willing to rebase/update this PR and fix the PHPStan warning?
  22. Simon Schaufelberger commented on patch set 13 07/16/23, 11:05

    Reply Unresolved

    if you mean me, I can do that in a few weeks.
  23. Christian Kuhn commented on patch set 13 08/06/24, 14:55

    hey. we've had quite a few changes in this area, and the patch has lots of merge conflicts right now. i think it would be good to restart a fresh patch in case this is still an issue. i hope it is ok to abandon here for now.
  24. Christian Kuhn abandoned the change 08/06/24, 14:55

  25. Oliver Klee wrote 08/06/24, 15:02

    Removed cc Oliver Klee.