Review main Merged

70488[TASK] Reduce inline JavaScript in Page Module Paste logic

Benni Mack CR +2 V +2 Hard +85 −238 updated 08/13/21, 09:47

Commit message

When having a content element on the clipboard (normal mode)
the page module dynamically shows paste icons
everywhere.

This change centralizes the generation of the Paste icons
into JavaScript, so the inline javascript usage of "top.*"
functionality to park code somewhere has been removed,
and the actual items are generated in JavaScript.

In addition, as this code is only affecting the page module
when a tt_content element is on the clipboard, the Paste.js
JS module is only loaded when appropriate, thus reducing
the actual loading time for "regular" visits on the Page Module.

The icon in the paste button is now loaded via a native web component,
and only necessary logic is used in the Paste JS module.

The outer rendering for the Page Module has been simplified,
moving this functionality all into PageLayoutController,
reducing cross-dependencies between the PageLayout* classes.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 811

  1. Benni Mack uploaded patch set 1 08/12/21, 13:35

  2. core-ci voted on patch set 1 V -1 08/12/21, 13:59 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14736

  3. Benni Mack uploaded patch set 2 08/12/21, 14:02

  4. core-ci voted on patch set 2 V -1 08/12/21, 14:34 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14747

  5. Benni Mack rebased onto patch set 3 08/12/21, 20:34

  6. core-ci voted on patch set 3 V +1 08/12/21, 20:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14851

  7. Wouter Wolters voted on patch set 3 CR +1 08/12/21, 22:43

  8. Jochen Roth voted on patch set 3 V +1 CR +1 08/13/21, 08:46

  9. Oli Bartsch voted on patch set 3 V +1 CR +1 08/13/21, 09:45

  10. Benni Mack voted on patch set 3 V +2 CR +2 08/13/21, 09:47

  11. Benni Mack merged patch set 4 08/13/21, 09:47