Review main Abandoned

70491[TASK] Enable UTF8 filesystem by default

Krzysztof Gutkowski CR 0 V 0 Normal +239 −7 updated 09/16/22, 12:45

Commit message

This commit sets the
$GLOBALS['TYPO3_CONF_VARS']['SYS']['UTF8Filesystem'] config value by
default on TYPO3 installations that haven't explicitly disabled it in
their own configurations.

With that setting enabled, it is required to explicitly set the
$GLOBALS['TYPO3_CONF_VARS']['SYS']['systemLocale'] config value.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 9

Review log 2332

Show 57 earlier messages
  1. Krzysztof Gutkowski uploaded patch set 1 08/12/21, 14:04

  2. Oliver Klee updated the commit message in patch set 2 08/12/21, 14:07

  3. Krzysztof Gutkowski wrote 08/12/21, 14:10

    Description "Edit commit message" removed from patch set 2
  4. Krzysztof Gutkowski wrote 08/12/21, 14:10

    Description of patch set 2 set to "Edit commit message"
  5. core-ci voted on patch set 1 V -1 08/12/21, 14:23 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14748

  6. core-ci voted on patch set 2 V -1 08/12/21, 14:30 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14752

  7. Krzysztof Gutkowski uploaded patch set 3 08/12/21, 14:51

  1. Krzysztof Gutkowski updated the commit message in patch set 4 08/12/21, 14:52

  2. core-ci voted on patch set 3 V +1 08/12/21, 15:03 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14766

  3. core-ci voted on patch set 4 V +1 08/12/21, 15:15 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14767

  4. Wouter Wolters commented on patch set 4 CR -1 08/12/21, 18:48

    Is an upgrade wizard possible to detect those installations that don't have the locale set? That way it is upgradable and not in this way hard breaking.
  5. Krzysztof Gutkowski uploaded patch set 5 08/14/21, 09:03

  6. Krzysztof Gutkowski updated the commit message in patch set 6 08/14/21, 09:04

  7. Krzysztof Gutkowski commented on patch set 6 08/14/21, 09:05

    Reply

    I've added in an upgrade wizard that sets the locale to the machine's default system locale, and shows a warning if said locale doesn't support UTF-8.
  8. core-ci voted on patch set 5 V -1 08/14/21, 09:28 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15043

  9. core-ci voted on patch set 6 V -1 08/14/21, 09:30 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15044

  10. Krzysztof Gutkowski uploaded patch set 7 08/14/21, 09:44

  11. core-ci voted on patch set 7 V +1 08/14/21, 10:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15049

  12. Christian Kuhn commented on patch set 7 08/14/21, 10:17

    I'd really love to have UTF8Filesystem enabled by default to get rid of these "changed" filenames when editors for instance upload files. The dependency to locale however is unfortunate: It does not always exist. I'm unsure about windows, but for instance alpine based linux images do not have locale since they rely on musl. And bringing locale into such images is kinda hard - I was unable to achieve that with the typo3/core-testing images. Not sure how to proceed with this in mind.
  13. Krzysztof Gutkowski commented on patch set 7 08/14/21, 10:20

    Reply Unresolved

    Yeah I've already noticed this when I wanted to write some tests; they just flat out didn't work in the testing container.
  14. Christian Kuhn commented on patch set 7 08/14/21, 10:22

    The second problem with locale is, that the PHP api does not answer in a sane way whether calls have been successful. We run into this multiple times in various tests already and I currently have the conclusion there is no good way to detect errors. At best, core should drop that dependency somehow altogether und use "something else", but I didn't dig deeper, yet. If that locale stuff is a hard dependency for UTF8Filesystem, I'm unsure how to find a good solution right now.
  15. Krzysztof Gutkowski commented on patch set 7 08/14/21, 10:34

    Reply Unresolved

    Still, I think we could direct people who can't enable locale in their systems to explicitly disable UTF8filesystem in their configs, at least for the time being, until we figure out what stuff needs to be replaced in core to accommodate for that. I suppose I should add that bit to documentation/upgrade wizard.
  16. Benni Mack wrote 11/29/21, 10:10

    Change destination moved from master to main
  17. Benni Mack updated the commit message in patch set 8 11/29/21, 13:25

  18. core-ci voted on patch set 8 V +1 11/29/21, 14:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20020

  19. Simon Schaufelberger uploaded patch set 9 08/19/22, 10:31

  20. Andreas Kienast commented on patch set 9 CR -1 08/19/22, 10:42

    DefaultConfiguration.php:96

    Please don't do this for now. See the reasoning at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75378.
  21. core-ci voted on patch set 9 V -1 08/19/22, 10:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30305

  22. Simon Schaufelberger commented on patch set 9 08/19/22, 21:38

    should we then abandon it?
  23. Stefan Bürk commented on patch set 9 08/23/22, 19:13

    Reply Unresolved

    Maybe we should, as we may take https://review.typo3.org/c/Packages/TYPO3.CMS/+/75378 as "first" step in this direction (already merged).

    DefaultConfiguration.php:96 Reply Unresolved

    I would say, with following already merged: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75378 we have a "good start" on it.
  24. Christian Kuhn commented on patch set 9 09/16/22, 12:45

    I think we should abandon this for now since https://forge.typo3.org/issues/98090 has been done with v12 now. We may come back to this in v13, though.
  25. Christian Kuhn abandoned the change 09/16/22, 12:45